Bugzilla – Attachment 145235 Details for
Bug 29100
Add checkouts data loop to predue/due notices script (advance_notices.pl)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 29100: (QA follow-up) Rename issue(s) keys to checkout(s)
Bug-29100-QA-follow-up-Rename-issues-keys-to-check.patch (text/plain), 3.57 KB, created by
Tomás Cohen Arazi (tcohen)
on 2023-01-12 12:22:02 UTC
(
hide
)
Description:
Bug 29100: (QA follow-up) Rename issue(s) keys to checkout(s)
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2023-01-12 12:22:02 UTC
Size:
3.57 KB
patch
obsolete
>From 1728102f14544280e84e3833d96f3182b14db105 Mon Sep 17 00:00:00 2001 >From: Kyle Hall <kyle@bywatersolutions.com> >Date: Tue, 15 Nov 2022 06:57:44 -0500 >Subject: [PATCH] Bug 29100: (QA follow-up) Rename issue(s) keys to checkout(s) >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Adapted test plan: > >1) Apply this patch >2) For DUE and PREDUE notices, set the message body to the following: > Title: [% checkout.title %] >3) For DUEDGST and PREDUEDGST notices, set the message body to the following: > Titles: > [% FOREACH c IN checkouts %] > * [% c.title %][% END %] >4) Generate PREDUE and DUE notices for patrons including digests >5) Verify those notices contain the checkout titles > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Edit: tcohen renamed @issues => @checkouts as well >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > misc/cronjobs/advance_notices.pl | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl >index e964873e0ce..b13e5cdeba4 100755 >--- a/misc/cronjobs/advance_notices.pl >+++ b/misc/cronjobs/advance_notices.pl >@@ -306,7 +306,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) { > itemnumber => $upcoming->{'itemnumber'}, > substitute => { > 'items.content' => $title, >- issue => $item_info, >+ checkout => $item_info, > }, > message_transport_type => $transport, > } ) >@@ -355,7 +355,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) { > itemnumber => $upcoming->{'itemnumber'}, > substitute => { > 'items.content' => $title, >- issue => $item_info, >+ checkout => $item_info, > }, > message_transport_type => $transport, > } ) >@@ -595,10 +595,10 @@ sub send_digests { > }); > my $titles = ""; > my @itemnumbers; >- my @issues; >+ my @checkouts; > while ( my $item_info = $next_item_info->()) { > push @itemnumbers, $item_info->{itemnumber}; >- push( @issues, $item_info ); >+ push( @checkouts, $item_info ); > $titles .= C4::Letters::get_item_content( { item => $item_info, item_content_fields => \@item_content_fields } ); > } > >@@ -608,11 +608,11 @@ sub send_digests { > { > letter_code => $params->{letter_code}, > borrowernumber => $borrowernumber, >- issues => \@issues, >+ checkouts => \@checkouts, > substitute => { > count => $count, > 'items.content' => $titles, >- issues => \@issues, >+ checkouts => \@checkouts, > %branch_info > }, > itemnumbers => \@itemnumbers, >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 29100
:
125217
|
125218
|
125219
|
134489
|
134490
|
134926
|
134927
|
137996
|
143898
|
143910
|
143911
|
143912
| 145235