Bug 29100 - Add checkouts data loop to predue notices script ( advance_notices.pl )
Summary: Add checkouts data loop to predue notices script ( advance_notices.pl )
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-09-23 17:18 UTC by Kyle M Hall
Modified: 2022-07-29 10:51 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 29100: Add checkouts data loop to predue notices script ( advance_notices.pl ) (4.90 KB, patch)
2021-09-23 17:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29100: Remove unnecessary loops (3.87 KB, patch)
2021-09-23 17:42 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29100: Remove unnecessary loops (3.86 KB, patch)
2021-09-23 17:47 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29100: Add checkouts data loop to predue notices script ( advance_notices.pl ) (4.97 KB, patch)
2022-05-03 09:58 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 29100: Remove unnecessary loops (3.93 KB, patch)
2022-05-03 09:58 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 29100: Add checkouts data loop to predue notices script ( advance_notices.pl ) (5.00 KB, patch)
2022-05-12 13:45 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29100: Remove unnecessary loops (3.93 KB, patch)
2022-05-12 13:46 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 29100: Remove unnecessary loops (3.98 KB, patch)
2022-07-21 23:11 UTC, George Veranis
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2021-09-23 17:18:03 UTC
Predue / due notices are limited to using itemscontent to display checkouts data. It would be nice to make all the checkouts data available for those notices so that libraries could format that data more nicely if they wish.
Comment 1 Kyle M Hall 2021-09-23 17:37:53 UTC
Created attachment 125217 [details] [review]
Bug 29100: Add checkouts data loop to predue notices script ( advance_notices.pl )

Predue / due notices are limited to using itemscontent to display checkouts data. It would be nice to make all the checkouts data available for those notices so that libraries could format that data more nicely if they wish.

1) Apply this patch
2) For DUE and PREDUE notices, set the message body to the following:
Title: [% issue.title %]
3) For DUEDGST and PREDUEDGST notices, set the message body to the following:
Titles:
[% FOREACH i IN issues %]
* [% i.title %]
[% END %]
4) Generate PREDUE and DUE notices for patrons including digests
5) Verify those notices contain the checkout titles
Comment 2 Kyle M Hall 2021-09-23 17:42:23 UTC
Created attachment 125218 [details] [review]
Bug 29100: Remove unnecessary loops

Remove loops that only operate one one result only
Comment 3 Kyle M Hall 2021-09-23 17:47:05 UTC
Created attachment 125219 [details] [review]
Bug 29100: Remove unnecessary loops

Remove loops that only operate one one result only
Comment 4 Nick Clemens 2022-05-03 09:58:23 UTC
Created attachment 134489 [details] [review]
Bug 29100: Add checkouts data loop to predue notices script ( advance_notices.pl )

Predue / due notices are limited to using itemscontent to display checkouts data. It would be nice to make all the checkouts data available for those notices so that libraries could format that data more nicely if they wish.

1) Apply this patch
2) For DUE and PREDUE notices, set the message body to the following:
Title: [% issue.title %]
3) For DUEDGST and PREDUEDGST notices, set the message body to the following:
Titles:
[% FOREACH i IN issues %]
* [% i.title %]
[% END %]
4) Generate PREDUE and DUE notices for patrons including digests
5) Verify those notices contain the checkout titles

Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov>
Comment 5 Nick Clemens 2022-05-03 09:58:27 UTC
Created attachment 134490 [details] [review]
Bug 29100: Remove unnecessary loops

Remove loops that only operate one one result only

Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov>
Comment 6 Kyle M Hall 2022-05-12 13:45:53 UTC
Created attachment 134926 [details] [review]
Bug 29100: Add checkouts data loop to predue notices script ( advance_notices.pl )

Predue / due notices are limited to using itemscontent to display checkouts data. It would be nice to make all the checkouts data available for those notices so that libraries could format that data more nicely if they wish.

1) Apply this patch
2) For DUE and PREDUE notices, set the message body to the following:
Title: [% issue.title %]
3) For DUEDGST and PREDUEDGST notices, set the message body to the following:
Titles:
[% FOREACH i IN issues %]
* [% i.title %]
[% END %]
4) Generate PREDUE and DUE notices for patrons including digests
5) Verify those notices contain the checkout titles

Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov>
Comment 7 Kyle M Hall 2022-05-12 13:46:03 UTC
Created attachment 134927 [details] [review]
Bug 29100: Remove unnecessary loops

Remove loops that only operate one one result only

Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov>
Comment 8 Victor Grousset/tuxayo 2022-07-12 00:40:04 UTC
Hi :)

If I understand correctly there will be a change for existing notices. items.content now is the 1st title instead of the concatenation of all of them. Is that correct?
I don't know what is the template variable where it end but it's content will change then.
Comment 9 George Veranis 2022-07-21 23:11:41 UTC
Created attachment 137996 [details] [review]
Bug 29100: Remove unnecessary loops

Remove loops that only operate one one result only

Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov>
Signed-off-by: George Veranis <gveranis@dataly.gr>
Comment 10 Sally 2022-07-29 10:51:14 UTC
This will be a great enhancement, thank you, Kyle :)