Predue / due notices are limited to using itemscontent to display checkouts data. It would be nice to make all the checkouts data available for those notices so that libraries could format that data more nicely if they wish.
Created attachment 125217 [details] [review] Bug 29100: Add checkouts data loop to predue notices script ( advance_notices.pl ) Predue / due notices are limited to using itemscontent to display checkouts data. It would be nice to make all the checkouts data available for those notices so that libraries could format that data more nicely if they wish. 1) Apply this patch 2) For DUE and PREDUE notices, set the message body to the following: Title: [% issue.title %] 3) For DUEDGST and PREDUEDGST notices, set the message body to the following: Titles: [% FOREACH i IN issues %] * [% i.title %] [% END %] 4) Generate PREDUE and DUE notices for patrons including digests 5) Verify those notices contain the checkout titles
Created attachment 125218 [details] [review] Bug 29100: Remove unnecessary loops Remove loops that only operate one one result only
Created attachment 125219 [details] [review] Bug 29100: Remove unnecessary loops Remove loops that only operate one one result only
Created attachment 134489 [details] [review] Bug 29100: Add checkouts data loop to predue notices script ( advance_notices.pl ) Predue / due notices are limited to using itemscontent to display checkouts data. It would be nice to make all the checkouts data available for those notices so that libraries could format that data more nicely if they wish. 1) Apply this patch 2) For DUE and PREDUE notices, set the message body to the following: Title: [% issue.title %] 3) For DUEDGST and PREDUEDGST notices, set the message body to the following: Titles: [% FOREACH i IN issues %] * [% i.title %] [% END %] 4) Generate PREDUE and DUE notices for patrons including digests 5) Verify those notices contain the checkout titles Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov>
Created attachment 134490 [details] [review] Bug 29100: Remove unnecessary loops Remove loops that only operate one one result only Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov>
Created attachment 134926 [details] [review] Bug 29100: Add checkouts data loop to predue notices script ( advance_notices.pl ) Predue / due notices are limited to using itemscontent to display checkouts data. It would be nice to make all the checkouts data available for those notices so that libraries could format that data more nicely if they wish. 1) Apply this patch 2) For DUE and PREDUE notices, set the message body to the following: Title: [% issue.title %] 3) For DUEDGST and PREDUEDGST notices, set the message body to the following: Titles: [% FOREACH i IN issues %] * [% i.title %] [% END %] 4) Generate PREDUE and DUE notices for patrons including digests 5) Verify those notices contain the checkout titles Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov>
Created attachment 134927 [details] [review] Bug 29100: Remove unnecessary loops Remove loops that only operate one one result only Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov>
Hi :) If I understand correctly there will be a change for existing notices. items.content now is the 1st title instead of the concatenation of all of them. Is that correct? I don't know what is the template variable where it end but it's content will change then.
Created attachment 137996 [details] [review] Bug 29100: Remove unnecessary loops Remove loops that only operate one one result only Signed-off-by: Felicity Brown <Felicity.Brown@montgomerycountymd.gov> Signed-off-by: George Veranis <gveranis@dataly.gr>
This will be a great enhancement, thank you, Kyle :)