Bugzilla – Attachment 145763 Details for
Bug 19188
Self checkout: Fine blocking checkout is missing currency symbol
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19188: Self checkout missing currency symbol
Bug-19188-Self-checkout-missing-currency-symbol.patch (text/plain), 3.14 KB, created by
David Nind
on 2023-01-27 17:30:12 UTC
(
hide
)
Description:
Bug 19188: Self checkout missing currency symbol
Filename:
MIME Type:
Creator:
David Nind
Created:
2023-01-27 17:30:12 UTC
Size:
3.14 KB
patch
obsolete
>From a7ffe503cd501000e751fd2f8a93b7794b6ee8ae Mon Sep 17 00:00:00 2001 >From: Jenny Way <jwayway@hotmail.com> >Date: Tue, 16 Jan 2018 22:05:39 +0000 >Subject: [PATCH] Bug 19188: Self checkout missing currency symbol > >Test plan: >1. Under administration and system preferences, enable WebBasedSelfCheck >2. In OPAC give user fine by going to 'my account' at top right >3. Then under fines tab 'create manual invoice' >4. Make sure this amount is more than noissuescharge which can be > changed under system preferences >5. Go to the web based self check from the OPAC URL >6. Log in as your user >7. Try to check out an item >7. Error 'Item cannot be checked out' should occur >8. With the patch, the currency symbol should show for the amount. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >Updated test plan. >Signed-off-by: David Nind <david@davidnind.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt | 4 ++-- > opac/sco/sco-main.pl | 2 ++ > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >index d25f0eb645..2d644a4c71 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt >@@ -1,4 +1,4 @@ >- [% USE raw %] >+[% USE raw %] > [% USE Asset %] > [% USE Koha %] > [% USE KohaDates %] >@@ -69,7 +69,7 @@ > [% ELSIF ( circ_error_NOT_FOR_LOAN ) %] > <span id="ce_not_for_loan">This item is not for loan.</span> > [% ELSIF ( circ_error_DEBT ) %] >- <span id="ce_too_much_debt">You owe the library [% DEBT | $Price %] and cannot check out.</span> >+ <span id="ce_too_much_debt">You owe the library [% currencySym %] [% DEBT | $Price %] and cannot check out.</span> > [% ELSIF ( circ_error_WTHDRAWN ) %] > <span id="ce_wthdrawn">This item has been withdrawn from the collection.</span> > [% ELSIF ( circ_error_RESTRICTED ) %] >diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl >index ac89db749c..56e7b48b6c 100755 >--- a/opac/sco/sco-main.pl >+++ b/opac/sco/sco-main.pl >@@ -200,6 +200,7 @@ elsif ( $patron && ( $op eq 'checkout' ) ) { > ); > if ($issue_error eq 'DEBT') { > $template->param(DEBT => $impossible->{DEBT}); >+ $template->param(currencySym => $currencySymbol); > } > if ( $issue_error eq "NO_MORE_RENEWALS" ) { > $return_only = 1; >@@ -224,6 +225,7 @@ elsif ( $patron && ( $op eq 'checkout' ) ) { > ); > if ($issue_error eq 'DEBT') { > $template->param(DEBT => $needconfirm->{DEBT}); >+ $template->param(currencySym => $currencySymbol); > } > } else { > if ( $confirmed || $issuenoconfirm ) { # we'll want to call getpatroninfo again to get updated issues. >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19188
:
70577
|
70608
|
70624
|
71124
|
145708
|
145709
|
145763
|
145764
|
145864
|
145865