Bug 19188 - Self checkout: missing space if fine amount is blocking renewal
Summary: Self checkout: missing space if fine amount is blocking renewal
Status: Patch doesn't apply
Alias: None
Product: Koha
Classification: Unclassified
Component: Self checkout (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: jwayway
QA Contact: Marcel de Rooy
URL:
Keywords: Academy
Depends on: 4078
Blocks:
  Show dependency treegraph
 
Reported: 2017-08-27 11:33 UTC by Katrin Fischer
Modified: 2018-03-30 21:37 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug-19188: Self checkout missing space for price (3.24 KB, patch)
2018-01-16 22:17 UTC, jwayway
Details | Diff | Splinter Review
Bug 19188: Self checkout missing space for price (3.30 KB, patch)
2018-01-17 13:12 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 19188: Self checkout missing space for price (3.39 KB, patch)
2018-01-17 15:51 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 19188: Use the Price template plugin with_symbol => 1 (3.06 KB, patch)
2018-02-01 17:44 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2017-08-27 11:33:48 UTC
When a fine amount is blocking the renewal in the web based self checkout, the message reads like:

... EUR15.00 ...

EUR is the active currency in my system, so display might vary a bit. We should add a space there and it might be nice to use the Price TT plugin for formatting the fine nicely.
Comment 1 Aleisha Amohia 2018-01-08 02:07:47 UTC
Can you please provide a plan of how to reproduce this and where the message shows? I can't seem to reproduce the bug but I may be trying to create it in the wrong place.
Comment 2 Katrin Fischer 2018-01-08 02:10:41 UTC
It's been a little while, did you try the web based self check with a fine amount on the account over what is set in OPACFineNoRenewals?
Comment 3 Katrin Fischer 2018-01-08 02:15:28 UTC
The problem is here:

sco-main.tt
  55 [% ELSIF ( circ_error_DEBT ) %]
  56 You owe the library [% amount %] and cannot check out.

 opac / sco / sco-main.pl
 165         if ($issue_error eq 'DEBT') {
 166             $template->param(amount => $currencySymbol.$impossible->{DEBT});
Comment 4 jwayway 2018-01-16 22:17:00 UTC
Created attachment 70577 [details] [review]
Bug-19188: Self checkout missing space for price

Test plan:
1. Under administration and system preferences, enable WebBasedSelfCheck
2. Login to localhost:8081 and issue a book
3. In OPAC give user fine by going to 'my account' at top right
4. Then under fines tab 'create manual invoice'
5. Make sure this amount is more than OPACFineNoRenenwals which can be
changed  under System prefernces
6. Back in localhost:8081, try renewing the book
7. Error 'Item cannot be checked out' should occur
8. Without patch the currency symbol and amount is together
9. With patch there should be a space in between
Comment 5 Owen Leonard 2018-01-17 13:12:58 UTC
Created attachment 70608 [details] [review]
Bug 19188: Self checkout missing space for price

Test plan:
1. Under administration and system preferences, enable WebBasedSelfCheck
2. Login to localhost:8081 and issue a book
3. In OPAC give user fine by going to 'my account' at top right
4. Then under fines tab 'create manual invoice'
5. Make sure this amount is more than OPACFineNoRenenwals which can be
   changed  under System prefernces
6. Back in localhost:8081, try renewing the book
7. Error 'Item cannot be checked out' should occur
8. Without patch the currency symbol and amount is together
9. With patch there should be a space in between

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 6 Marcel de Rooy 2018-01-17 15:51:26 UTC
Created attachment 70624 [details] [review]
Bug 19188: Self checkout missing space for price

Test plan:
1. Under administration and system preferences, enable WebBasedSelfCheck
2. Login to localhost:8081 and issue a book
3. In OPAC give user fine by going to 'my account' at top right
4. Then under fines tab 'create manual invoice'
5. Make sure this amount is more than OPACFineNoRenenwals which can be
   changed  under System prefernces
6. Back in localhost:8081, try renewing the book
7. Error 'Item cannot be checked out' should occur
8. Without patch the currency symbol and amount is together
9. With patch there should be a space in between

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Jonathan Druart 2018-01-19 18:31:53 UTC
I am wondering if we should not display the currency with the Price plugin instead.
Delaying the push for now as I do not have time to deep more into it.
Comment 8 Jonathan Druart 2018-02-01 17:44:32 UTC
Created attachment 71124 [details] [review]
Bug 19188: Use the Price template plugin with_symbol => 1

To make it displayed correctly depending on the configuration of the
currency
Comment 9 Jonathan Druart 2018-02-01 17:45:07 UTC
I have added a follow-up based on top of bug 4078.
Comment 10 Charles Farmer 2018-03-30 21:37:48 UTC
Got 2 conflicts trying to apply the patch.