When a fine amount is blocking the renewal in the web based self checkout, the message reads like: ... EUR15.00 ... EUR is the active currency in my system, so display might vary a bit. We should add a space there and it might be nice to use the Price TT plugin for formatting the fine nicely.
Can you please provide a plan of how to reproduce this and where the message shows? I can't seem to reproduce the bug but I may be trying to create it in the wrong place.
It's been a little while, did you try the web based self check with a fine amount on the account over what is set in OPACFineNoRenewals?
The problem is here: sco-main.tt 55 [% ELSIF ( circ_error_DEBT ) %] 56 You owe the library [% amount %] and cannot check out. opac / sco / sco-main.pl 165 if ($issue_error eq 'DEBT') { 166 $template->param(amount => $currencySymbol.$impossible->{DEBT});
Created attachment 70577 [details] [review] Bug-19188: Self checkout missing space for price Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. Login to localhost:8081 and issue a book 3. In OPAC give user fine by going to 'my account' at top right 4. Then under fines tab 'create manual invoice' 5. Make sure this amount is more than OPACFineNoRenenwals which can be changed under System prefernces 6. Back in localhost:8081, try renewing the book 7. Error 'Item cannot be checked out' should occur 8. Without patch the currency symbol and amount is together 9. With patch there should be a space in between
Created attachment 70608 [details] [review] Bug 19188: Self checkout missing space for price Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. Login to localhost:8081 and issue a book 3. In OPAC give user fine by going to 'my account' at top right 4. Then under fines tab 'create manual invoice' 5. Make sure this amount is more than OPACFineNoRenenwals which can be changed under System prefernces 6. Back in localhost:8081, try renewing the book 7. Error 'Item cannot be checked out' should occur 8. Without patch the currency symbol and amount is together 9. With patch there should be a space in between Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 70624 [details] [review] Bug 19188: Self checkout missing space for price Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. Login to localhost:8081 and issue a book 3. In OPAC give user fine by going to 'my account' at top right 4. Then under fines tab 'create manual invoice' 5. Make sure this amount is more than OPACFineNoRenenwals which can be changed under System prefernces 6. Back in localhost:8081, try renewing the book 7. Error 'Item cannot be checked out' should occur 8. Without patch the currency symbol and amount is together 9. With patch there should be a space in between Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
I am wondering if we should not display the currency with the Price plugin instead. Delaying the push for now as I do not have time to deep more into it.
Created attachment 71124 [details] [review] Bug 19188: Use the Price template plugin with_symbol => 1 To make it displayed correctly depending on the configuration of the currency
I have added a follow-up based on top of bug 4078.
Got 2 conflicts trying to apply the patch.
Created attachment 145708 [details] [review] Bug 19188: Self checkout missing currency symbol Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. In OPAC give user fine by going to 'my account' at top right 3. Then under fines tab 'create manual invoice' 4. Make sure this amount is more than noissuescharge which can be changed under system preferences 5. Go to the web based self check from the OPAC URL 6. Log in as your user 7. Try to check out an item 7. Error 'Item cannot be checked out' should occur 8. With the patch, the currency symbol should show for the amount. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Updated test plan.
Created attachment 145709 [details] [review] Bug 19188: Use the Price template plugin with_symbol => 1 To make it displayed correctly depending on the configuration of the currency Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
This is a bit of a rescue mission for Jenny's patch. Rebased the original patch set, fixed test plan and made sure it worked with current code.
Created attachment 145763 [details] [review] Bug 19188: Self checkout missing currency symbol Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. In OPAC give user fine by going to 'my account' at top right 3. Then under fines tab 'create manual invoice' 4. Make sure this amount is more than noissuescharge which can be changed under system preferences 5. Go to the web based self check from the OPAC URL 6. Log in as your user 7. Try to check out an item 7. Error 'Item cannot be checked out' should occur 8. With the patch, the currency symbol should show for the amount. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Updated test plan. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 145764 [details] [review] Bug 19188: Use the Price template plugin with_symbol => 1 To make it displayed correctly depending on the configuration of the currency Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com>
Created attachment 145864 [details] [review] Bug 19188: Self checkout missing currency symbol Test plan: 1. Under administration and system preferences, enable WebBasedSelfCheck 2. In OPAC give user fine by going to 'my account' at top right 3. Then under fines tab 'create manual invoice' 4. Make sure this amount is more than noissuescharge which can be changed under system preferences 5. Go to the web based self check from the OPAC URL 6. Log in as your user 7. Try to check out an item 7. Error 'Item cannot be checked out' should occur 8. With the patch, the currency symbol should show for the amount. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 145865 [details] [review] Bug 19188: Use the Price template plugin with_symbol => 1 To make it displayed correctly depending on the configuration of the currency Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Great to see this rescued, Passing QA
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work, thanks everyone! Pushed to 22.11.x for the next release.
Backported to 22.05.x for upcoming 22.05.10
applied to 21.11.1x for 21.11.16
Not backported to 21.05.x