Bugzilla – Attachment 14670 Details for
Bug 9117
Reports hierarchies management improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 9117 [Follow-up] Reports hierarchies management improvements
Bug-9117-Follow-up-Reports-hierarchies-management-.patch (text/plain), 2.96 KB, created by
Jonathan Druart
on 2013-01-17 13:53:04 UTC
(
hide
)
Description:
Bug 9117 [Follow-up] Reports hierarchies management improvements
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2013-01-17 13:53:04 UTC
Size:
2.96 KB
patch
obsolete
>From ef60267cb989a7411313be11510f630b3de030d2 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Thu, 22 Nov 2012 10:48:08 +0100 >Subject: [PATCH] Bug 9117 [Follow-up] Reports hierarchies management > improvements > >This patch avoid javascript bugs when user hasn't 'create_reports' >permission (last column is hidden in this case but <th> remains) >+ fix a typo 'selelcted' > 'selected' > >Amended patch: >- add use Modern::Perl; in reports/guided_reports.pl >- remove a simple-quote string in guided_reports_start.tt > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../prog/en/modules/reports/guided_reports_start.tt | 8 +++++--- > reports/guided_reports.pl | 1 + > 2 files changed, 6 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >index 819cd0a..b2aacdb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt >@@ -67,7 +67,7 @@ $(document).ready(function(){ > { 'bSearchable': false, 'aTargets': [3, 4] } > ], > 'oLanguage': { >- 'sZeroRecords': _('No matching reports found') >+ 'sZeroRecords': _("No matching reports found") > } > })); > >@@ -280,7 +280,9 @@ canned reports and writing custom SQL reports.</p> > <th>Saved results</th> > <th>Saved SQL</th> > <th> </th> >- <th> </th> >+ [% IF ( CAN_user_reports_create_reports ) %] >+ <th> </th> >+ [% END %] > </tr> > </thead> > <tbody> >@@ -808,7 +810,7 @@ Sub report:<select name="subreport"> > [% IF (public) %] > <li><label for="public">Report is public:</label><select id="public" name="public"> <option value="0">No (default)</option> <option value="1" selected="selected">Yes</option> </select></li> > [% ELSE %] >- <li><label for="public">Report is public:</label><select id="public" name="public"> <option value="0" selected="selelcted">No (default)</option> <option value="1">Yes</option> </select></li> >+ <li><label for="public">Report is public:</label><select id="public" name="public"> <option value="0" selected="selected">No (default)</option> <option value="1">Yes</option> </select></li> > [% END %] > [% IF (usecache) %] <li> > <label for="cache_expiry">Cache expiry:</label><input type="text" id="cache_expiry" name="cache_expiry" value="[% cache_expiry %]"></input> >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index ed9aa6e..d920e09 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -18,6 +18,7 @@ > # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. > > >+use Modern::Perl; > use CGI; > use Text::CSV; > use URI::Escape; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9117
:
13560
|
13578
|
13597
|
13627
|
13628
|
13931
|
14668
|
14669
|
14670
|
16241
|
16244
|
16246
|
16270
|
16271
|
16282
|
16283
|
16284
|
16285
|
16286
|
16287
|
16288
|
16290
|
16292
|
16293
|
16294
|
16295
|
16296
|
16653