Bugzilla – Attachment 147260 Details for
Bug 32611
Not for loan items don't show the specific not for loan value in OPAC detail page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32611: Not for loan items don't show the specific not for loan value in OPAC detail page
Bug-32611-Not-for-loan-items-dont-show-the-specifi.patch (text/plain), 2.53 KB, created by
Owen Leonard
on 2023-02-23 17:21:11 UTC
(
hide
)
Description:
Bug 32611: Not for loan items don't show the specific not for loan value in OPAC detail page
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2023-02-23 17:21:11 UTC
Size:
2.53 KB
patch
obsolete
>From 1766884706a57270911244734c6e7027d52ff1c6 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 23 Feb 2023 17:10:32 +0000 >Subject: [PATCH] Bug 32611: Not for loan items don't show the specific not for > loan value in OPAC detail page > >This patch corrects what appear to be some copy-paste errors which >resulted in the "not for loan" authorized value description not >displaying, instead the generic "Not for loan" is shown. > >The patch also adds another case for displaying the item restricted >status. Previously items.restricted would only display if the item >*also* had a notforloan value. > >To test it's probably easiest to find a record with multiple items and >set various item statuses (damaged, notforloan, lost, restricted) and >confirm that the right description is shown. >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc >index 0d5713d5aa8..aac8ece2ee3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc >@@ -91,10 +91,10 @@ > [% END %] > > >-[% SET restricted_lib = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.withdrawn', authorised_value => item.withdrawn, opac => 1 ) %] >+[% SET restricted_lib = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.restricted', authorised_value => item.restricted, opac => 1 ) %] > [% IF item.notforloan %] > [% SET itemavailable = 0 %] >- [% notforloan_lib = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.withdrawn', authorised_value => item.withdrawn, opac => 1 ) %] >+ [% notforloan_lib = AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.notforloan', authorised_value => item.notforloan, opac => 1 ) %] > [% IF notforloan_lib %] > <span class="item-status notforloan">[% notforloan_lib | html %] [% IF restricted_lib %]<span class="restricted">([% restricted_lib | html %])</span>[% END %]</span> > [% ELSE %] >@@ -103,6 +103,10 @@ > [% ELSIF item.itemtype.notforloan %] > [% SET itemavailable = 0 %] > <span class="item-status notforloan">Not for loan [% IF restricted_lib %]<span class="restricted">([% restricted_lib | html %])</span>[% END %]</span> >+[% ELSE %] >+ [% IF restricted_lib %] >+ <span class="item-status restricted">[% restricted_lib | html %]</span> >+ [% END %] > [% END %] > > [% IF ( item.bundle_host ) %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32611
:
147260
|
147268
|
147400