When viewing a detailed record on the OPAC, we used to see the specific value of Not for loan (e.g. Ordered). Right now, any Not for loan value displays as "Not for loan" no matter what the authorized value description (or description (OPAC)) is. To test: 1. In the staff interface, edit an item 2. Change the Not for loan value to Ordered 3. Save 4. Click on "Normal" to see the detailed record --> Status is "Not for loan (Ordered)" 5. Click on "OPAC view: Open in new window." --> Status is "Not for loan". It should be "Ordered" 6. Try with any not for loan value --> Status stays "Not for loan". It should be whatever value you chose 7. Try changing the descriptions or descriptions (OPAC) in Administration > Authorized values > NOT_LOAN --> Status stays "Not for loan". It should be whatever you put in description (OPAC) or description, if description (OPAC) is empty I tested in 22.05(.07) and it shows Ordered (or whatever value I put). In master, it always shows "Not for loan".
Could this be Bug 32445 - Status display of 'not for loan' items is broken in OPAC/staff ?
(In reply to Katrin Fischer from comment #1) > Could this be Bug 32445 - Status display of 'not for loan' items is broken > in OPAC/staff ? That is what I thought too, but I didn't want to presume since the display was already broken before that patch.
Created attachment 147260 [details] [review] Bug 32611: Not for loan items don't show the specific not for loan value in OPAC detail page This patch corrects what appear to be some copy-paste errors which resulted in the "not for loan" authorized value description not displaying, instead the generic "Not for loan" is shown. The patch also adds another case for displaying the item restricted status. Previously items.restricted would only display if the item *also* had a notforloan value. To test it's probably easiest to find a record with multiple items and set various item statuses (damaged, notforloan, lost, restricted) and confirm that the right description is shown.
Created attachment 147268 [details] [review] Bug 32611: Not for loan items don't show the specific not for loan value in OPAC detail page This patch corrects what appear to be some copy-paste errors which resulted in the "not for loan" authorized value description not displaying, instead the generic "Not for loan" is shown. The patch also adds another case for displaying the item restricted status. Previously items.restricted would only display if the item *also* had a notforloan value. To test it's probably easiest to find a record with multiple items and set various item statuses (damaged, notforloan, lost, restricted) and confirm that the right description is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 147400 [details] [review] Bug 32611: Not for loan items don't show the specific not for loan value in OPAC detail page This patch corrects what appear to be some copy-paste errors which resulted in the "not for loan" authorized value description not displaying, instead the generic "Not for loan" is shown. The patch also adds another case for displaying the item restricted status. Previously items.restricted would only display if the item *also* had a notforloan value. To test it's probably easiest to find a record with multiple items and set various item statuses (damaged, notforloan, lost, restricted) and confirm that the right description is shown. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Pushed to master for 23.05. Nice work everyone, thanks!
Nice work everyone! Pushed to stable for 22.11.x
Does not apply cleanly to 22.05.x, no backport.
Think this has introduced a different regression...