Bugzilla – Attachment 147323 Details for
Bug 33005
Use template wrapper for breadcrumbs: Acquisitions part 3
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33005: (follow-up) Add spans for translatability
Bug-33005-follow-up-Add-spans-for-translatability.patch (text/plain), 8.96 KB, created by
Owen Leonard
on 2023-02-24 12:48:32 UTC
(
hide
)
Description:
Bug 33005: (follow-up) Add spans for translatability
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2023-02-24 12:48:32 UTC
Size:
8.96 KB
patch
obsolete
>From f77625d224b819bd8c2f6557f6f54b12119fa6f4 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Fri, 24 Feb 2023 12:44:31 +0000 >Subject: [PATCH] Bug 33005: (follow-up) Add spans for translatability > >This patch finds places in the updated breadcrumbs markup where a >translatable string is isolated in a way that makes it hard for the >translation script to find it, and wraps these strings with <span> >--- > .../prog/en/modules/acqui/newordersuggestion.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt | 2 +- > .../intranet-tmpl/prog/en/modules/acqui/orderreceive.tt | 8 +++++--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt | 7 ++++--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/acqui/z3950_search.tt | 4 ++-- > 9 files changed, 19 insertions(+), 16 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt >index 6dfaadc5107..817e0eddd28 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt >@@ -26,7 +26,7 @@ > <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno | uri %]">Basket [% basketno | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Add order from a suggestion >+ <span>Add order from a suggestion</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt >index ade84344d5a..891002ad20d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/ordered.tt >@@ -21,7 +21,7 @@ > <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Ordered - [% fund_code | html %] >+ <span>Ordered - [% fund_code | html %]</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index aeac1ea1c4a..755cb879fc1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -26,9 +26,11 @@ > <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% order.basket.booksellerid | uri %]">[% name | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Receive items from : [% name | html %] [% IF ( invoice ) %] >- [[% invoice | html %]] >- [% END %] (order #[% order.ordernumber | html %]) >+ [% IF ( invoice ) %] >+ <span>Receive items from: [% name | html %] [[% invoice | html %]] (order #[% order.ordernumber | html %])</span> >+ [% ELSE %] >+ <span>Receive items from: [% name | html %] (order #[% order.ordernumber | html %])</span> >+ [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index 268c309a042..5ec656850f8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -29,9 +29,10 @@ > [% END %] > [% IF invoiceclosedate %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Receipt summary for <em>[% name | html %]</em> > [% IF ( invoice ) %] >- <em>[ [% invoice | html %] ]</em> >+ <span>Receipt summary for <em>[% name | html %] [ [% invoice | html %] ]</em></span> >+ [% ELSE %] >+ <span>Receipt summary for <em>[% name | html %]</em></span> > [% END %] > [% END %] > [% ELSE %] >@@ -39,7 +40,7 @@ > <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | uri %]">[% name | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Receive orders from [% name | html %] >+ <span>Receive orders from [% name | html %]</span> > [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >index f0a6e0356b6..1139e4ad99b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >@@ -21,7 +21,7 @@ > <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | uri %]">[% name | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Receive shipment from vendor [% name | html %] >+ <span>Receive shipment from vendor [% name | html %]</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt >index 9c64849bc61..158e0077e07 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/spent.tt >@@ -21,7 +21,7 @@ > <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Spent - [% fund_code | html %] >+ <span>Spent - [% fund_code | html %]</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >index 88331af598e..06a6f684bbd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/supplier.tt >@@ -109,11 +109,11 @@ > <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | uri %]">[% name | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Update: [% name | html %] >+ <span>Update: [% name | html %]</span> > [% END %] > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Add vendor >+ <span>Add vendor</span> > [% END %] > [% END %] > [% ELSE %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt >index 1aa6df55cd4..2e9c6abf0fd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt >@@ -23,11 +23,11 @@ > <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | uri %]">[% booksellername | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Uncertain prices for vendor [% booksellername | html %] >+ <span>Uncertain prices for vendor [% booksellername | html %]</span> > [% END %] > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Uncertain prices >+ <span>Uncertain prices</span> > [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >index 94e068518e2..e79843fbc1c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >@@ -57,14 +57,14 @@ tr.selected td { > [% END %] > [% IF ( opsearch ) %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Order from external source >+ <span>Order from external source</span> > [% END %] > [% ELSE %] > [% WRAPPER breadcrumb_item %] > <a href="/cgi-bin/koha/acqui/z3950_search.pl?booksellerid=[% booksellerid | uri %]&basketno=[% basketno | uri %]">Order from external source</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Search results >+ <span>Search results</span> > [% END %] > [% END # /IF opsearch %] > [% END #/ WRAPPER breadcrumbs %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33005
:
146922
|
147323
|
149241
|
149242
|
149340
|
149341
|
149342
|
149343
|
149344
|
149345
|
149346