Bugzilla – Attachment 147391 Details for
Bug 32991
Improve our Dialog component and remove routes for deletion
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog
Bug-32991-Allow-for-a-confirmation-title-message-a.patch (text/plain), 5.36 KB, created by
Pedro Amorim
on 2023-02-24 18:19:54 UTC
(
hide
)
Description:
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-02-24 18:19:54 UTC
Size:
5.36 KB
patch
obsolete
>From 8d2912c2efcdded10ce1d4e8cbc12925a6e610ca Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Fri, 24 Feb 2023 17:31:13 +0000 >Subject: [PATCH] Bug 32991: Allow for a confirmation title, message, > accept_label and cancel_label in the dialog > >--- > .../prog/js/vue/components/Dialog.vue | 7 +++--- > .../js/vue/components/ERM/AgreementsList.vue | 23 ++++++++++++++----- > .../intranet-tmpl/prog/js/vue/stores/main.js | 2 +- > 3 files changed, 22 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue >index 45aa8f4661..c7b167faf9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Dialog.vue >@@ -10,7 +10,8 @@ > </div> > <div class="modal_centered" v-if="confirmation"> > <div class="dialog alert confirmation"> >- <h1 v-html="confirmation"></h1> >+ <h1 v-html="confirmation.title"></h1> >+ <p v-html="confirmation.message"></p> > <button > v-if="accept_callback" > id="accept_modal" >@@ -18,11 +19,11 @@ > @click="accept_callback" > > > <i class="fa fa-fw fa-check"></i> >- {{ $__("Accept") }} >+ <span v-html="confirmation.accept_label"></span> > </button> > <button id="close_modal" class="deny" @click="removeMessages"> > <i class="fa fa-fw fa-remove"></i> >- {{ $__("Close") }} >+ <span v-html="confirmation.cancel_label"></span> > </button> > </div> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >index 251c4c892a..28d05ead9e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >@@ -49,7 +49,7 @@ export default { > const AVStore = inject("AVStore") > const { get_lib_from_av, map_av_dt_filter } = AVStore > >- const { setConfirmation, setMessage } = inject("mainStore") >+ const { setConfirmationDialog, setMessage } = inject("mainStore") > > const table_id = "agreement_list" > useDataTable(table_id) >@@ -59,7 +59,7 @@ export default { > get_lib_from_av, > map_av_dt_filter, > table_id, >- setConfirmation, >+ setConfirmationDialog, > setMessage, > } > }, >@@ -114,9 +114,16 @@ export default { > "/cgi-bin/koha/erm/agreements/edit/" + agreement_id > ) > }, >- delete_agreement: function (agreement_id) { >- this.setConfirmation( >- this.$__("Are you sure you want to remove this agreement?"), >+ delete_agreement: function (agreement_id, agreement_name) { >+ this.setConfirmationDialog( >+ { >+ title: this.$__( >+ "Are you sure you want to remove this agreement?" >+ ), >+ message: agreement_name, >+ accept_label: this.$__("Yes, delete"), >+ cancel_label: this.$__("No, do not delete"), >+ }, > () => { > const client = APIClient.erm > client.agreements.delete(agreement_id).then( >@@ -314,6 +321,7 @@ export default { > let agreement_id = api > .row(tr) > .data().agreement_id >+ let agreement_name = api.row(tr).data().name > let editButton = createVNode( > "a", > { >@@ -338,7 +346,10 @@ export default { > class: "btn btn-default btn-xs", > role: "button", > onClick: () => { >- delete_agreement(agreement_id) >+ delete_agreement( >+ agreement_id, >+ agreement_name >+ ) > }, > }, > [ >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js b/koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js >index 838ac6c9c9..21e04f69ec 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/stores/main.js >@@ -35,7 +35,7 @@ export const useMainStore = defineStore("main", { > this._confirmation = null; > this.displayed_already = displayed; /* Is displayed on the current view */ > }, >- setConfirmation(confirmation, accept_callback, displayed = true){ >+ setConfirmationDialog(confirmation, accept_callback, displayed = true){ > if(accept_callback) { > this._accept_callback = async () => { > await accept_callback() >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32991
:
146828
|
146829
|
147051
|
147052
|
147053
|
147054
|
147082
|
147083
|
147281
|
147282
|
147291
|
147305
|
147350
|
147383
|
147384
|
147385
|
147387
|
147388
|
147389
|
147390
|
147391
|
147392
|
147393
|
147394
|
147429
|
147439
|
147445
|
147447
|
147448
|
147449
|
147450
|
147451
|
147452
|
147453
|
147454
|
147455
|
147456
|
147461
|
147483
|
147485
|
147486
|
147487
|
147542
|
147543
|
147544
|
147545
|
147546
|
147547
|
147548
|
147549
|
147550
|
147551
|
147552
|
147553
|
147554
|
147569
|
147573
|
147584
|
147588
|
147589
|
147590
|
147591
|
147592
|
147593
|
147594
|
147595
|
147596
|
147597
|
147598
|
147599
|
147600
|
147601
|
147602
|
147603
|
147604
|
147937
|
147938
|
147939
|
147940
|
147941
|
147942
|
147943
|
147944
|
147945
|
147946
|
147947
|
147948
|
147949
|
147950
|
147951