Bug 32991 - Improve our Dialog component and remove routes for deletion
Summary: Improve our Dialog component and remove routes for deletion
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on: 32983
Blocks: 33169 32807 33066 33648
  Show dependency treegraph
 
Reported: 2023-02-17 10:58 UTC by Jonathan Druart
Modified: 2023-12-28 20:43 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.04


Attachments
Bug 32991: Improve our Dialog component (10.55 KB, patch)
2023-02-17 11:28 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Add a confirmation message (8.01 KB, patch)
2023-02-17 11:28 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Improve our Dialog component (10.29 KB, patch)
2023-02-21 14:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Add a confirmation message (8.01 KB, patch)
2023-02-21 14:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Improve our Dialog component (10.54 KB, patch)
2023-02-21 14:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Add a confirmation message (8.01 KB, patch)
2023-02-21 14:29 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Improve our Dialog component (10.62 KB, patch)
2023-02-21 17:35 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32991: Add a confirmation message (8.09 KB, patch)
2023-02-21 17:35 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 32991: Improve our Dialog component (10.61 KB, patch)
2023-02-24 07:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Add a confirmation message (8.07 KB, patch)
2023-02-24 07:41 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: (QA follow-up) Add margin to buttons; Fix duplicate HTML element ID (1.17 KB, patch)
2023-02-24 11:32 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID (2.71 KB, patch)
2023-02-24 12:19 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Fix agreements tests with new dialog instead of confirm delete page. Squash this later with other tests updates (1.94 KB, patch)
2023-02-24 16:06 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: accept is a callback, rename accept to accept_callback (3.86 KB, patch)
2023-02-24 17:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title and a confirmation message in the dialog (7.39 KB, patch)
2023-02-24 17:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Add delete dialog to licenses list (3.00 KB, patch)
2023-02-24 17:38 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title and a confirmation message in the dialog (4.92 KB, patch)
2023-02-24 18:10 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Add delete dialog to licenses list (3.23 KB, patch)
2023-02-24 18:10 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog (4.93 KB, patch)
2023-02-24 18:13 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Add delete dialog to licenses list (3.67 KB, patch)
2023-02-24 18:19 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog (5.36 KB, patch)
2023-02-24 18:19 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in the dialog (5.36 KB, patch)
2023-02-24 18:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Add delete dialog to licenses list (3.67 KB, patch)
2023-02-24 18:23 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Add delete dialog to local packages list (3.80 KB, patch)
2023-02-24 18:31 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Add delete dialog to local titles list (3.81 KB, patch)
2023-02-27 11:09 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (11.91 KB, patch)
2023-02-27 12:27 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (12.05 KB, patch)
2023-02-27 14:52 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes (10.83 KB, patch)
2023-02-27 15:03 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue (2.39 KB, patch)
2023-02-27 15:10 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes (11.12 KB, patch)
2023-02-27 15:24 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: accept is a callback, rename accept to accept_callback (3.86 KB, patch)
2023-02-27 15:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue (2.39 KB, patch)
2023-02-27 15:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (11.91 KB, patch)
2023-02-27 15:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (12.05 KB, patch)
2023-02-27 15:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes (10.83 KB, patch)
2023-02-27 15:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes (11.12 KB, patch)
2023-02-27 15:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Fix agreements tests with new dialog instead of confirm delete page. Squash this later with other tests updates (1.94 KB, patch)
2023-02-27 15:26 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Fix cypress tests. Added new test for when deleting from show view. (13.57 KB, patch)
2023-02-27 16:31 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Flag the deletion messages as displayed already (7.32 KB, patch)
2023-02-28 10:26 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Don't remove all messages when confirm box is closed (2.98 KB, patch)
2023-02-28 10:49 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Don't remove all messages when confirm box is closed (2.98 KB, patch)
2023-02-28 11:18 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Add cypress tests for the dialog box (5.84 KB, patch)
2023-02-28 11:22 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Improve our Dialog component (10.68 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Add a confirmation message (8.15 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID (2.78 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: accept is a callback, rename accept to accept_callback (3.94 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue (2.47 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (11.98 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (12.13 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes (10.91 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes (11.20 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Fix cypress tests. Added new test for when deleting from show view. (13.65 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Flag the deletion messages as displayed already (7.40 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Don't remove all messages when confirm box is closed (3.05 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Add cypress tests for the dialog box (5.91 KB, patch)
2023-03-01 09:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning (2.95 KB, patch)
2023-03-01 15:58 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning (3.00 KB, patch)
2023-03-01 17:57 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 32991: Don't display breadcrumb if pref is off (1.24 KB, patch)
2023-03-02 10:04 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Improve our Dialog component (10.86 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Add a confirmation message (8.35 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID (2.99 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: accept is a callback, rename accept to accept_callback (4.14 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue (2.67 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (12.19 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (12.33 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes (11.11 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes (11.40 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Fix cypress tests. Added new test for when deleting from show view. (13.85 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Flag the deletion messages as displayed already (7.60 KB, patch)
2023-03-02 10:17 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Don't remove all messages when confirm box is closed (3.25 KB, patch)
2023-03-02 10:18 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Add cypress tests for the dialog box (6.11 KB, patch)
2023-03-02 10:18 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning (3.01 KB, patch)
2023-03-02 10:18 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Don't display breadcrumb if pref is off (1.44 KB, patch)
2023-03-02 10:18 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning (3.01 KB, patch)
2023-03-02 10:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Don't display breadcrumb if pref is off (1.44 KB, patch)
2023-03-02 10:24 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 32991: Improve our Dialog component (10.85 KB, patch)
2023-03-08 14:39 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Add a confirmation message (8.34 KB, patch)
2023-03-08 14:39 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID (2.98 KB, patch)
2023-03-08 14:39 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: accept is a callback, rename accept to accept_callback (4.13 KB, patch)
2023-03-08 14:39 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue (2.66 KB, patch)
2023-03-08 14:39 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (12.18 KB, patch)
2023-03-08 14:39 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes. (12.32 KB, patch)
2023-03-08 14:39 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes (11.11 KB, patch)
2023-03-08 14:39 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes (11.39 KB, patch)
2023-03-08 14:40 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Fix cypress tests. Added new test for when deleting from show view. (13.84 KB, patch)
2023-03-08 14:40 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Flag the deletion messages as displayed already (7.58 KB, patch)
2023-03-08 14:40 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Don't remove all messages when confirm box is closed (3.25 KB, patch)
2023-03-08 14:40 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Add cypress tests for the dialog box (6.11 KB, patch)
2023-03-08 14:40 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning (3.01 KB, patch)
2023-03-08 14:40 UTC, Agustín Moyano
Details | Diff | Splinter Review
Bug 32991: Don't display breadcrumb if pref is off (1.44 KB, patch)
2023-03-08 14:40 UTC, Agustín Moyano
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-02-17 10:58:57 UTC
Agustin suggested some nice improvements on bug 32607 that would be great to have in a separate bug.

We should embed the changes here, and eventually remove the specific routes (and components) we have to delete object.
Comment 1 Jonathan Druart 2023-02-17 11:28:44 UTC
Created attachment 146828 [details] [review]
Bug 32991: Improve our Dialog component

This is picking some improvements made by Agustin on bug 32607.
This patch is only a POC and we should apply this change to the
different delete route.

We will then remove the *FormConfirmDelete components, and the /delete routes

Initially I wanted to have the same behaviour as in other areas of Koha,
and have a separate view for the deletion step. But it's too much
overhead for not much gain.

Additionally we will have to remove messages.js, the aim of this file
was to import the methods to add messages very easily (only 1 import
line). Now we will need 2 lines (it was more when I added messages.js,
because I didn't inject the store). Not a big deal.

Finally, there is something weird in Main.vue we need to fix. The
console is showing a warning
"[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."

I had a hard time to display this "loading" modal when the app is
loading all the things it needs. Pinia/store is not available as we are
accessing the methods/actions too earlier. It will be good to fix that
before we decide to move forward with this approach.
Comment 2 Jonathan Druart 2023-02-17 11:28:46 UTC
Created attachment 146829 [details] [review]
Bug 32991: Add a confirmation message

Looks easier to have a separate variable for the confirmation box, and
easier for styling as well.
Comment 3 Jonathan Druart 2023-02-17 11:29:49 UTC
Patches applied on top of the tree at https://gitlab.com/joubu/Koha/-/commits/bug_32991
Comment 4 Jonathan Druart 2023-02-21 14:20:38 UTC
Created attachment 147051 [details] [review]
Bug 32991: Improve our Dialog component

This is picking some improvements made by Agustin on bug 32607.
This patch is only a POC and we should apply this change to the
different delete route.

We will then remove the *FormConfirmDelete components, and the /delete routes

Initially I wanted to have the same behaviour as in other areas of Koha,
and have a separate view for the deletion step. But it's too much
overhead for not much gain.

Additionally we will have to remove messages.js, the aim of this file
was to import the methods to add messages very easily (only 1 import
line). Now we will need 2 lines (it was more when I added messages.js,
because I didn't inject the store). Not a big deal.

Finally, there is something weird in Main.vue we need to fix. The
console is showing a warning
"[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."

I had a hard time to display this "loading" modal when the app is
loading all the things it needs. Pinia/store is not available as we are
accessing the methods/actions too earlier. It will be good to fix that
before we decide to move forward with this approach.
Comment 5 Jonathan Druart 2023-02-21 14:20:41 UTC
Created attachment 147052 [details] [review]
Bug 32991: Add a confirmation message

Looks easier to have a separate variable for the confirmation box, and
easier for styling as well.
Comment 6 Jonathan Druart 2023-02-21 14:29:19 UTC
Created attachment 147053 [details] [review]
Bug 32991: Improve our Dialog component

This is picking some improvements made by Agustin on bug 32607.
This patch is only a POC and we should apply this change to the
different delete route.

We will then remove the *FormConfirmDelete components, and the /delete routes

Initially I wanted to have the same behaviour as in other areas of Koha,
and have a separate view for the deletion step. But it's too much
overhead for not much gain.

Additionally we will have to remove messages.js, the aim of this file
was to import the methods to add messages very easily (only 1 import
line). Now we will need 2 lines (it was more when I added messages.js,
because I didn't inject the store). Not a big deal.

Finally, there is something weird in Main.vue we need to fix. The
console is showing a warning
"[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."

I had a hard time to display this "loading" modal when the app is
loading all the things it needs. Pinia/store is not available as we are
accessing the methods/actions too earlier. It will be good to fix that
before we decide to move forward with this approach.
Comment 7 Jonathan Druart 2023-02-21 14:29:21 UTC
Created attachment 147054 [details] [review]
Bug 32991: Add a confirmation message

Looks easier to have a separate variable for the confirmation box, and
easier for styling as well.
Comment 8 Matt Blenkinsop 2023-02-21 17:35:22 UTC
Created attachment 147082 [details] [review]
Bug 32991: Improve our Dialog component

This is picking some improvements made by Agustin on bug 32607.
This patch is only a POC and we should apply this change to the
different delete route.

We will then remove the *FormConfirmDelete components, and the /delete routes

Initially I wanted to have the same behaviour as in other areas of Koha,
and have a separate view for the deletion step. But it's too much
overhead for not much gain.

Additionally we will have to remove messages.js, the aim of this file
was to import the methods to add messages very easily (only 1 import
line). Now we will need 2 lines (it was more when I added messages.js,
because I didn't inject the store). Not a big deal.

Finally, there is something weird in Main.vue we need to fix. The
console is showing a warning
"[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."

I had a hard time to display this "loading" modal when the app is
loading all the things it needs. Pinia/store is not available as we are
accessing the methods/actions too earlier. It will be good to fix that
before we decide to move forward with this approach.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 9 Matt Blenkinsop 2023-02-21 17:35:25 UTC
Created attachment 147083 [details] [review]
Bug 32991: Add a confirmation message

Looks easier to have a separate variable for the confirmation box, and
easier for styling as well.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 10 Matt Blenkinsop 2023-02-21 17:39:01 UTC
(In reply to Jonathan Druart from comment #6)

> Finally, there is something weird in Main.vue we need to fix. The
> console is showing a warning
> "[Vue warn]: setup() return property "_is_loading" should not start with "$"
> or "_" which are reserved prefixes for Vue internals."

This appears to just need a new variable name - Vue won't accept variables prefixed with "_" in root components so "_is_loading" will need renaming. We can't just remove the "_" as there is a getter called "is_loading" and this will conflict. Maybe "content_is_loading"?
Comment 11 Jonathan Druart 2023-02-22 06:59:00 UTC
(In reply to Matt Blenkinsop from comment #10)
> (In reply to Jonathan Druart from comment #6)
> 
> > Finally, there is something weird in Main.vue we need to fix. The
> > console is showing a warning
> > "[Vue warn]: setup() return property "_is_loading" should not start with "$"
> > or "_" which are reserved prefixes for Vue internals."
> 
> This appears to just need a new variable name - Vue won't accept variables
> prefixed with "_" in root components so "_is_loading" will need renaming. We
> can't just remove the "_" as there is a getter called "is_loading" and this
> will conflict. Maybe "content_is_loading"?

Yes, the thing is that Agustin decided to prefix the store variables with '_', to get a good getter method name.

We should not only rename is_loading, but others as well (for consistency), and so we need to provide a clean solution for all of them. But first I wanted to make sure the trick in Main was necessary and there was no better alternative.
Comment 12 Jonathan Druart 2023-02-24 07:41:51 UTC
Created attachment 147281 [details] [review]
Bug 32991: Improve our Dialog component

This is picking some improvements made by Agustin on bug 32607.
This patch is only a POC and we should apply this change to the
different delete route.

We will then remove the *FormConfirmDelete components, and the /delete routes

Initially I wanted to have the same behaviour as in other areas of Koha,
and have a separate view for the deletion step. But it's too much
overhead for not much gain.

Additionally we will have to remove messages.js, the aim of this file
was to import the methods to add messages very easily (only 1 import
line). Now we will need 2 lines (it was more when I added messages.js,
because I didn't inject the store). Not a big deal.

Finally, there is something weird in Main.vue we need to fix. The
console is showing a warning
"[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."

I had a hard time to display this "loading" modal when the app is
loading all the things it needs. Pinia/store is not available as we are
accessing the methods/actions too earlier. It will be good to fix that
before we decide to move forward with this approach.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 13 Jonathan Druart 2023-02-24 07:41:54 UTC
Created attachment 147282 [details] [review]
Bug 32991: Add a confirmation message

Looks easier to have a separate variable for the confirmation box, and
easier for styling as well.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Comment 14 Jonathan Druart 2023-02-24 07:42:33 UTC
Rebased on top of bug 32983's last changes.
Comment 15 Pedro Amorim 2023-02-24 11:32:49 UTC Comment hidden (obsolete)
Comment 16 Pedro Amorim 2023-02-24 12:19:24 UTC
Created attachment 147305 [details] [review]
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID
Comment 17 Pedro Amorim 2023-02-24 15:19:26 UTC
Putting this back to NSO, it's causing Cypress tests to fail. I'm working on it.
Comment 18 Pedro Amorim 2023-02-24 15:30:12 UTC
Also need to:
- Remove no longer needed Vue files
- Abstract the dialog button labels to be set by whatever component that invokes it, i.e. "Yes, delete" instead of the current hard-coded "Accept", etc.
- Fix the "is_loading" console error
Comment 19 Pedro Amorim 2023-02-24 16:06:54 UTC Comment hidden (obsolete)
Comment 20 Pedro Amorim 2023-02-24 17:38:40 UTC Comment hidden (obsolete)
Comment 21 Pedro Amorim 2023-02-24 17:38:43 UTC Comment hidden (obsolete)
Comment 22 Pedro Amorim 2023-02-24 17:38:46 UTC Comment hidden (obsolete)
Comment 23 Pedro Amorim 2023-02-24 18:10:18 UTC Comment hidden (obsolete)
Comment 24 Pedro Amorim 2023-02-24 18:10:21 UTC Comment hidden (obsolete)
Comment 25 Pedro Amorim 2023-02-24 18:13:45 UTC Comment hidden (obsolete)
Comment 26 Pedro Amorim 2023-02-24 18:19:51 UTC Comment hidden (obsolete)
Comment 27 Pedro Amorim 2023-02-24 18:19:54 UTC Comment hidden (obsolete)
Comment 28 Pedro Amorim 2023-02-24 18:23:00 UTC Comment hidden (obsolete)
Comment 29 Pedro Amorim 2023-02-24 18:23:03 UTC Comment hidden (obsolete)
Comment 30 Pedro Amorim 2023-02-24 18:31:49 UTC Comment hidden (obsolete)
Comment 31 Pedro Amorim 2023-02-27 11:09:08 UTC Comment hidden (obsolete)
Comment 32 Pedro Amorim 2023-02-27 12:27:39 UTC Comment hidden (obsolete)
Comment 33 Pedro Amorim 2023-02-27 14:52:34 UTC Comment hidden (obsolete)
Comment 34 Pedro Amorim 2023-02-27 15:03:30 UTC Comment hidden (obsolete)
Comment 35 Pedro Amorim 2023-02-27 15:10:19 UTC Comment hidden (obsolete)
Comment 36 Pedro Amorim 2023-02-27 15:24:08 UTC Comment hidden (obsolete)
Comment 37 Pedro Amorim 2023-02-27 15:26:29 UTC
Created attachment 147450 [details] [review]
Bug 32991: accept is a callback, rename accept to accept_callback
Comment 38 Pedro Amorim 2023-02-27 15:26:31 UTC
Created attachment 147451 [details] [review]
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue
Comment 39 Pedro Amorim 2023-02-27 15:26:34 UTC
Created attachment 147452 [details] [review]
Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes.
Comment 40 Pedro Amorim 2023-02-27 15:26:37 UTC
Created attachment 147453 [details] [review]
Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes.
Comment 41 Pedro Amorim 2023-02-27 15:26:40 UTC
Created attachment 147454 [details] [review]
Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes
Comment 42 Pedro Amorim 2023-02-27 15:26:43 UTC
Created attachment 147455 [details] [review]
Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes
Comment 43 Pedro Amorim 2023-02-27 15:26:46 UTC
Created attachment 147456 [details] [review]
Bug 32991: Fix agreements tests with new dialog instead of confirm delete page. Squash this later with other tests updates
Comment 44 Pedro Amorim 2023-02-27 16:31:20 UTC
Created attachment 147461 [details] [review]
Bug 32991: Fix cypress tests. Added new test for when deleting from show view.
Comment 45 Jonathan Druart 2023-02-28 10:26:06 UTC
Created attachment 147483 [details] [review]
Bug 32991: Flag the deletion messages as displayed already

Or they will be displayed again on the next view
Comment 46 Jonathan Druart 2023-02-28 10:49:33 UTC
Created attachment 147485 [details] [review]
Bug 32991: Don't remove all messages when confirm box is closed

If we cancel the confirmation box we should not clear all the messages
Comment 47 Jonathan Druart 2023-02-28 11:18:55 UTC
Created attachment 147486 [details] [review]
Bug 32991: Don't remove all messages when confirm box is closed

If we cancel the confirmation box we should not clear all the messages
Comment 48 Jonathan Druart 2023-02-28 11:22:23 UTC
Created attachment 147487 [details] [review]
Bug 32991: Add cypress tests for the dialog box
Comment 49 Jonathan Druart 2023-03-01 09:50:04 UTC
Created attachment 147542 [details] [review]
Bug 32991: Improve our Dialog component

This is picking some improvements made by Agustin on bug 32607.
This patch is only a POC and we should apply this change to the
different delete route.

We will then remove the *FormConfirmDelete components, and the /delete routes

Initially I wanted to have the same behaviour as in other areas of Koha,
and have a separate view for the deletion step. But it's too much
overhead for not much gain.

Additionally we will have to remove messages.js, the aim of this file
was to import the methods to add messages very easily (only 1 import
line). Now we will need 2 lines (it was more when I added messages.js,
because I didn't inject the store). Not a big deal.

Finally, there is something weird in Main.vue we need to fix. The
console is showing a warning
"[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."

I had a hard time to display this "loading" modal when the app is
loading all the things it needs. Pinia/store is not available as we are
accessing the methods/actions too earlier. It will be good to fix that
before we decide to move forward with this approach.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 50 Jonathan Druart 2023-03-01 09:50:07 UTC
Created attachment 147543 [details] [review]
Bug 32991: Add a confirmation message

Looks easier to have a separate variable for the confirmation box, and
easier for styling as well.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 51 Jonathan Druart 2023-03-01 09:50:10 UTC
Created attachment 147544 [details] [review]
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 52 Jonathan Druart 2023-03-01 09:50:13 UTC
Created attachment 147545 [details] [review]
Bug 32991: accept is a callback, rename accept to accept_callback

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 53 Jonathan Druart 2023-03-01 09:50:16 UTC
Created attachment 147546 [details] [review]
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 54 Jonathan Druart 2023-03-01 09:50:20 UTC
Created attachment 147547 [details] [review]
Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 55 Jonathan Druart 2023-03-01 09:50:23 UTC
Created attachment 147548 [details] [review]
Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 56 Jonathan Druart 2023-03-01 09:50:26 UTC
Created attachment 147549 [details] [review]
Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 57 Jonathan Druart 2023-03-01 09:50:29 UTC
Created attachment 147550 [details] [review]
Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 58 Jonathan Druart 2023-03-01 09:50:32 UTC
Created attachment 147551 [details] [review]
Bug 32991: Fix cypress tests. Added new test for when deleting from show view.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 59 Jonathan Druart 2023-03-01 09:50:35 UTC
Created attachment 147552 [details] [review]
Bug 32991: Flag the deletion messages as displayed already

Or they will be displayed again on the next view

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 60 Jonathan Druart 2023-03-01 09:50:39 UTC
Created attachment 147553 [details] [review]
Bug 32991: Don't remove all messages when confirm box is closed

If we cancel the confirmation box we should not clear all the messages

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 61 Jonathan Druart 2023-03-01 09:50:42 UTC
Created attachment 147554 [details] [review]
Bug 32991: Add cypress tests for the dialog box

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 62 Jonathan Druart 2023-03-01 09:50:58 UTC
Added my stamp to Pedro's patches.
Comment 63 Agustín Moyano 2023-03-01 15:58:18 UTC
Created attachment 147569 [details] [review]
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning
Comment 64 Agustín Moyano 2023-03-01 16:02:24 UTC
Hi Jonathan and Pedro!

Excellent job on this Dialog component. I added a little fix on 'Main.vue' to not depend on the '_is_loading' flag

I believe we can squash these commits now.
Comment 65 Pedro Amorim 2023-03-01 17:57:42 UTC
Created attachment 147573 [details] [review]
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 66 Jonathan Druart 2023-03-02 10:04:44 UTC
Created attachment 147584 [details] [review]
Bug 32991: Don't display breadcrumb if pref is off
Comment 67 Jonathan Druart 2023-03-02 10:05:17 UTC
Thanks, Agustín!
Comment 68 Jonathan Druart 2023-03-02 10:17:20 UTC
Created attachment 147588 [details] [review]
Bug 32991: Improve our Dialog component

This is picking some improvements made by Agustin on bug 32607.
This patch is only a POC and we should apply this change to the
different delete route.

We will then remove the *FormConfirmDelete components, and the /delete routes

Initially I wanted to have the same behaviour as in other areas of Koha,
and have a separate view for the deletion step. But it's too much
overhead for not much gain.

Additionally we will have to remove messages.js, the aim of this file
was to import the methods to add messages very easily (only 1 import
line). Now we will need 2 lines (it was more when I added messages.js,
because I didn't inject the store). Not a big deal.

Finally, there is something weird in Main.vue we need to fix. The
console is showing a warning
"[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."

I had a hard time to display this "loading" modal when the app is
loading all the things it needs. Pinia/store is not available as we are
accessing the methods/actions too earlier. It will be good to fix that
before we decide to move forward with this approach.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 69 Jonathan Druart 2023-03-02 10:17:24 UTC
Created attachment 147589 [details] [review]
Bug 32991: Add a confirmation message

Looks easier to have a separate variable for the confirmation box, and
easier for styling as well.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 70 Jonathan Druart 2023-03-02 10:17:29 UTC
Created attachment 147590 [details] [review]
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 71 Jonathan Druart 2023-03-02 10:17:32 UTC
Created attachment 147591 [details] [review]
Bug 32991: accept is a callback, rename accept to accept_callback

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 72 Jonathan Druart 2023-03-02 10:17:36 UTC
Created attachment 147592 [details] [review]
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 73 Jonathan Druart 2023-03-02 10:17:40 UTC
Created attachment 147593 [details] [review]
Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 74 Jonathan Druart 2023-03-02 10:17:43 UTC
Created attachment 147594 [details] [review]
Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 75 Jonathan Druart 2023-03-02 10:17:47 UTC
Created attachment 147595 [details] [review]
Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 76 Jonathan Druart 2023-03-02 10:17:50 UTC
Created attachment 147596 [details] [review]
Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 77 Jonathan Druart 2023-03-02 10:17:53 UTC
Created attachment 147597 [details] [review]
Bug 32991: Fix cypress tests. Added new test for when deleting from show view.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 78 Jonathan Druart 2023-03-02 10:17:57 UTC
Created attachment 147598 [details] [review]
Bug 32991: Flag the deletion messages as displayed already

Or they will be displayed again on the next view

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 79 Jonathan Druart 2023-03-02 10:18:00 UTC
Created attachment 147599 [details] [review]
Bug 32991: Don't remove all messages when confirm box is closed

If we cancel the confirmation box we should not clear all the messages

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 80 Jonathan Druart 2023-03-02 10:18:04 UTC
Created attachment 147600 [details] [review]
Bug 32991: Add cypress tests for the dialog box

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 81 Jonathan Druart 2023-03-02 10:18:07 UTC
Created attachment 147601 [details] [review]
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 82 Jonathan Druart 2023-03-02 10:18:11 UTC
Created attachment 147602 [details] [review]
Bug 32991: Don't display breadcrumb if pref is off

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 83 Jonathan Druart 2023-03-02 10:24:09 UTC
Created attachment 147603 [details] [review]
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 84 Jonathan Druart 2023-03-02 10:24:13 UTC
Created attachment 147604 [details] [review]
Bug 32991: Don't display breadcrumb if pref is off

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 85 Jonathan Druart 2023-03-02 10:24:46 UTC
Rebased on top of 32983 to integrate the prettier change.

Added Agustín and Pedro signed-off-by lines and considering this set PQA.

Thanks!
Comment 86 Agustín Moyano 2023-03-02 19:31:01 UTC
\o/
Comment 87 Agustín Moyano 2023-03-08 14:39:32 UTC
Created attachment 147937 [details] [review]
Bug 32991: Improve our Dialog component

This is picking some improvements made by Agustin on bug 32607.
This patch is only a POC and we should apply this change to the
different delete route.

We will then remove the *FormConfirmDelete components, and the /delete routes

Initially I wanted to have the same behaviour as in other areas of Koha,
and have a separate view for the deletion step. But it's too much
overhead for not much gain.

Additionally we will have to remove messages.js, the aim of this file
was to import the methods to add messages very easily (only 1 import
line). Now we will need 2 lines (it was more when I added messages.js,
because I didn't inject the store). Not a big deal.

Finally, there is something weird in Main.vue we need to fix. The
console is showing a warning
"[Vue warn]: setup() return property "_is_loading" should not start with "$" or "_" which are reserved prefixes for Vue internals."

I had a hard time to display this "loading" modal when the app is
loading all the things it needs. Pinia/store is not available as we are
accessing the methods/actions too earlier. It will be good to fix that
before we decide to move forward with this approach.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 88 Agustín Moyano 2023-03-08 14:39:36 UTC
Created attachment 147938 [details] [review]
Bug 32991: Add a confirmation message

Looks easier to have a separate variable for the confirmation box, and
easier for styling as well.

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 89 Agustín Moyano 2023-03-08 14:39:40 UTC
Created attachment 147939 [details] [review]
Bug 32991: Style the dialog to be in line with rest of Koha; Fix duplicate HTML element ID

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 90 Agustín Moyano 2023-03-08 14:39:44 UTC
Created attachment 147940 [details] [review]
Bug 32991: accept is a callback, rename accept to accept_callback

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 91 Agustín Moyano 2023-03-08 14:39:47 UTC
Created attachment 147941 [details] [review]
Bug 32991: Allow for a confirmation title, message, accept_label and cancel_label in Dialog.vue

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 92 Agustín Moyano 2023-03-08 14:39:51 UTC
Created attachment 147942 [details] [review]
Bug 32991: Local titles: Add delete dialog to list and show. Removed FormConfirmDelete component and routes.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 93 Agustín Moyano 2023-03-08 14:39:55 UTC
Created attachment 147943 [details] [review]
Bug 32991: Local Packages: Add delete dialog to list and show. Removed FormConfirmDelete component and routes.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 94 Agustín Moyano 2023-03-08 14:39:59 UTC
Created attachment 147944 [details] [review]
Bug 32991: Licenses: Add delete dialog to list and show. Removed FormConfirmDelete component and routes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 95 Agustín Moyano 2023-03-08 14:40:03 UTC
Created attachment 147945 [details] [review]
Bug 32991: Agreements: Add delete dialog to show. Removed FormConfirmDelete component and routes

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 96 Agustín Moyano 2023-03-08 14:40:07 UTC
Created attachment 147946 [details] [review]
Bug 32991: Fix cypress tests. Added new test for when deleting from show view.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 97 Agustín Moyano 2023-03-08 14:40:11 UTC
Created attachment 147947 [details] [review]
Bug 32991: Flag the deletion messages as displayed already

Or they will be displayed again on the next view

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 98 Agustín Moyano 2023-03-08 14:40:15 UTC
Created attachment 147948 [details] [review]
Bug 32991: Don't remove all messages when confirm box is closed

If we cancel the confirmation box we should not clear all the messages

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 99 Agustín Moyano 2023-03-08 14:40:19 UTC
Created attachment 147949 [details] [review]
Bug 32991: Add cypress tests for the dialog box

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 100 Agustín Moyano 2023-03-08 14:40:23 UTC
Created attachment 147950 [details] [review]
Bug 32991: Remove _is_loading warning, and improve 'ERMModule' disabled warning

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>

Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 101 Agustín Moyano 2023-03-08 14:40:27 UTC
Created attachment 147951 [details] [review]
Bug 32991: Don't display breadcrumb if pref is off

Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Comment 102 Agustín Moyano 2023-03-08 14:41:05 UTC
Rebased patches that didn't apply
Comment 103 Tomás Cohen Arazi 2023-03-10 14:15:01 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 104 Jacob O'Mara 2023-03-16 19:49:14 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.
Comment 105 Lucas Gass 2023-04-14 18:09:56 UTC
Missing dependencies for 22.05.x, no backport