Bugzilla – Attachment 14777 Details for
Bug 9455
Embedded mysql quotes in sql string
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-Bug-9455-Remove-unnecessary-quoting-from-sql.patch (text/plain), 1.44 KB, created by
Colin Campbell
on 2013-01-23 12:01:30 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2013-01-23 12:01:30 UTC
Size:
1.44 KB
patch
obsolete
>From b8018a73d0a3d2f927ed5f1873cff7b0d81470c9 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Wed, 23 Jan 2013 10:31:31 +0000 >Subject: [PATCH] Bug 9455: Remove unnecessary quoting from sql > >Wa've removed the mysql specific back quotes from sql files >But this case remained of them embedded in an sql string >Also removed the unnecessary call to finish >and temporary variable in the subroutine return >--- > C4/Acquisition.pm | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 4a03e2c..ef4ab7c 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -798,14 +798,12 @@ Returns a reference to the array of all the basketgroups of bookseller $booksell > > sub GetBasketgroups { > my $booksellerid = shift; >- die "bookseller id is required to edit a basketgroup" unless $booksellerid; >- my $query = "SELECT * FROM aqbasketgroups WHERE booksellerid=? ORDER BY `id` DESC"; >+ die 'bookseller id is required to edit a basketgroup' unless $booksellerid; >+ my $query = 'SELECT * FROM aqbasketgroups WHERE booksellerid=? ORDER BY id DESC'; > my $dbh = C4::Context->dbh; > my $sth = $dbh->prepare($query); > $sth->execute($booksellerid); >- my $results = $sth->fetchall_arrayref({}); >- $sth->finish; >- return $results >+ return $sth->fetchall_arrayref({}); > } > > #------------------------------------------------------------# >-- >1.8.1.1.347.g9591fcc >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9455
:
14777
|
14897
|
15480