Attachment 148236 Details for Bug 33137 – Bug 33137: Add Home library to pay-fines-table and table settings

[patch] Bug 33137: Add Home library to pay-fines-table and table settings

Bug-33137-Add-Home-library-to-pay-fines-table-and-.patch (text/plain), 2.47 KB, created by Martin Renvoize (ashimema) on 2023-03-15 17:58:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2023-03-15 17:58:20 UTC

Size: 2.47 KB

patch

obsolete

>From 58b82362b127069ca3944a73845970f6fe4c8ae8 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 8 Mar 2023 16:24:26 +0000
>Subject: [PATCH] Bug 33137: Add Home library to pay-fines-table and table
> settings
>
>To test:
>1. Apply patch and restart_All
>2. From a patron's Accounting tab add some invoices that are related to an item.
>3. From the 'Make a payemnt' notice the new Home library column. Make sure it displays correctly and is the same as what you see on the 'Transactions' tab.
>4. Using Table settings, make sure you can properly hide the column.
>
>Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> admin/columns_settings.yml | 2 ++
> koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt | 6 ++++++
> 2 files changed, 8 insertions(+)
>
>diff --git a/admin/columns_settings.yml b/admin/columns_settings.yml
>index aa29dfd4d6..0783724910 100644
>--- a/admin/columns_settings.yml
>+++ b/admin/columns_settings.yml
>@@ -971,6 +971,8 @@ modules:
> columnname: issuedate
> -
> columnname: checked_out_from
>+ -
>+ columnname: homebranch
> -
> columnname: note
> -
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>index 0e5771c382..f30c002d33 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/pay.tt
>@@ -86,6 +86,7 @@
> <th>Checkin date</th>
> <th>Checkout date</th>
> <th class="checked_out_from">Checked out from</th>
>+ <th>Home library</th>
> <th class="NoSort">Payment note</th>
> <th>Amount</th>
> <th>Amount outstanding</th>
>@@ -150,6 +151,11 @@
> [% line.checkout.library.branchname | html %]
> [% END %]
> </td>
>+ <td>
>+ [% IF line.itemnumber %]
>+ [% Branches.GetName( line.item.homebranch ) | html %]
>+ [% END %]
>+ </td>
> <td class="actions">
> <a href="#" class="add-note" data-accountlines_id="[% line.accountlines_id | html %]"> Add note</a>
> <input type="text" size="10" name="payment_note_[% line.accountlines_id | html %]" value="" /> <a href="#" class="cancel-note"></a>
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 33137: 147967 | 147968 | 147990 | 147991 | 148000 | 148001 | 148002 | 148003 | 148236 | 148237 | 148238