Bugzilla – Attachment 148629 Details for
Bug 33329
GET /biblios encoding wrong when UNIMARC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33329: Regression tests
Bug-33329-Regression-tests.patch (text/plain), 2.51 KB, created by
Tomás Cohen Arazi
on 2023-03-23 23:48:24 UTC
(
hide
)
Description:
Bug 33329: Regression tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi
Created:
2023-03-23 23:48:24 UTC
Size:
2.51 KB
patch
obsolete
>From 9d6358150cd94f1f4e1438bdac874fc755abc7f8 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 23 Mar 2023 20:46:44 -0300 >Subject: [PATCH] Bug 33329: Regression tests > >This patch introduces tests for the bug highlighted on bug 32336, but in >the context of lists of records. > >To reproduce: >1. Run: > $ prove t/db_dependent/api/v1/biblios.t >=> SUCCESS: Tests pass! >2. Apply this patch >3. Repeat 1 >=> FAIL: Test fail, encoding is bad! >--- > t/db_dependent/api/v1/biblios.t | 28 ++++++++++++++++++++++++---- > 1 file changed, 24 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/api/v1/biblios.t b/t/db_dependent/api/v1/biblios.t >index d0740842388..3b7e1b81026 100755 >--- a/t/db_dependent/api/v1/biblios.t >+++ b/t/db_dependent/api/v1/biblios.t >@@ -1616,7 +1616,8 @@ subtest 'put() tests' => sub { > }; > > subtest 'list() tests' => sub { >- plan tests => 14; >+ >+ plan tests => 15; > > $schema->storage->txn_begin; > >@@ -1631,7 +1632,23 @@ subtest 'list() tests' => sub { > $patron->discard_changes; > my $userid = $patron->userid; > >- my $biblionumber1 = $builder->build_sample_biblio->biblionumber; >+ t::lib::Mocks::mock_preference('marcflavour', 'UNIMARC'); >+ >+ my $title_with_diacritics = "L'insoutenable légèreté de l'être"; >+ my $biblio = $builder->build_sample_biblio( >+ { >+ title => $title_with_diacritics, >+ author => "Milan Kundera" >+ } >+ ); >+ >+ my $record = $biblio->metadata->record; >+ $record->leader(' nam 3 4500'); >+ $biblio->metadata->metadata($record->as_xml_record('UNIMARC'))->store; >+ >+ my $biblionumber1 = $biblio->biblionumber; >+ >+ t::lib::Mocks::mock_preference('marcflavour', 'MARC21'); > my $biblionumber2 = $builder->build_sample_biblio->biblionumber; > > my $search = >@@ -1650,9 +1667,12 @@ subtest 'list() tests' => sub { > { Accept => 'application/json', 'x-koha-query' => $search } ) > ->status_is(200); > >- $t->get_ok( "//$userid:$password@/api/v1/biblios/" => >+ my $result = $t->get_ok( "//$userid:$password@/api/v1/biblios/" => > { Accept => 'application/marcxml+xml', 'x-koha-query' => $search } ) >- ->status_is(200); >+ ->status_is(200)->tx->res->body; >+ >+ my $encoded_title = Encode::encode( "UTF-8", $title_with_diacritics ); >+ like( $result, qr/\Q$encoded_title/, "The title is not double encoded" ); > > $t->get_ok( "//$userid:$password@/api/v1/biblios/" => > { Accept => 'application/marc-in-json', 'x-koha-query' => $search } ) >-- >2.40.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33329
:
148629
|
149708
|
149734
|
149735
|
150375
|
150376