Bug 33329 - GET /biblios encoding wrong when UNIMARC
Summary: GET /biblios encoding wrong when UNIMARC
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: REST API (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact:
URL:
Keywords:
Depends on: 32336 32734
Blocks: 32735
  Show dependency treegraph
 
Reported: 2023-03-23 23:45 UTC by Tomás Cohen Arazi
Modified: 2023-06-13 15:50 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 33329: Regression tests (2.51 KB, patch)
2023-03-23 23:48 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 33329: Correctly handle UNIMARC encoding for biblios (1.63 KB, patch)
2023-04-14 20:25 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 33329: Regression tests (2.56 KB, patch)
2023-04-16 22:49 UTC, David Nind
Details | Diff | Splinter Review
Bug 33329: Correctly handle UNIMARC encoding for biblios (1.68 KB, patch)
2023-04-16 22:49 UTC, David Nind
Details | Diff | Splinter Review
Bug 33329: Regression tests (2.61 KB, patch)
2023-04-28 13:32 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 33329: Correctly handle UNIMARC encoding for biblios (1.73 KB, patch)
2023-04-28 13:32 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2023-03-23 23:45:47 UTC
Same as bug 32336 but for listing biblios.
Comment 1 Tomás Cohen Arazi 2023-03-23 23:48:24 UTC
Created attachment 148629 [details] [review]
Bug 33329: Regression tests

This patch introduces tests for the bug highlighted on bug 32336, but in
the context of lists of records.

To reproduce:
1. Run:
   $ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Repeat 1
=> FAIL: Test fail, encoding is bad!
Comment 2 Tomás Cohen Arazi 2023-03-23 23:49:14 UTC
Hi, only submitted regression tests while waiting for my flight. Now is time to take off! See you soon!
Comment 3 Tomás Cohen Arazi 2023-04-14 20:25:59 UTC
Created attachment 149708 [details] [review]
Bug 33329: Correctly handle UNIMARC encoding for biblios

This patch introduces the same treatment we had for bug 32336, this time
for Koha::Objects::Record::Collections.

To test:
1. Apply the regression tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> FAIL: Tests fail! Encoding is wrong for UNIMARC!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D
Comment 4 David Nind 2023-04-16 22:49:28 UTC
Created attachment 149734 [details] [review]
Bug 33329: Regression tests

This patch introduces tests for the bug highlighted on bug 32336, but in
the context of lists of records.

To reproduce:
1. Run:
   $ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Repeat 1
=> FAIL: Test fail, encoding is bad!

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 David Nind 2023-04-16 22:49:31 UTC
Created attachment 149735 [details] [review]
Bug 33329: Correctly handle UNIMARC encoding for biblios

This patch introduces the same treatment we had for bug 32336, this time
for Koha::Objects::Record::Collections.

To test:
1. Apply the regression tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> FAIL: Tests fail! Encoding is wrong for UNIMARC!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Comment 6 Nick Clemens 2023-04-28 13:32:21 UTC
Created attachment 150375 [details] [review]
Bug 33329: Regression tests

This patch introduces tests for the bug highlighted on bug 32336, but in
the context of lists of records.

To reproduce:
1. Run:
   $ prove t/db_dependent/api/v1/biblios.t
=> SUCCESS: Tests pass!
2. Apply this patch
3. Repeat 1
=> FAIL: Test fail, encoding is bad!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens 2023-04-28 13:32:23 UTC
Created attachment 150376 [details] [review]
Bug 33329: Correctly handle UNIMARC encoding for biblios

This patch introduces the same treatment we had for bug 32336, this time
for Koha::Objects::Record::Collections.

To test:
1. Apply the regression tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/biblios.t
=> FAIL: Tests fail! Encoding is wrong for UNIMARC!
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 8 Tomás Cohen Arazi 2023-05-05 13:15:29 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 9 Martin Renvoize 2023-05-12 14:42:45 UTC
Many hands makes light work, thankyou everyone!

Pushed to 22.11.x for the next release
Comment 10 Lucas Gass 2023-06-13 15:50:50 UTC
Missing dependencies for 22.05.x, no backport.