Bugzilla – Attachment 149183 Details for
Bug 33066
We need a KohaTable Vue component
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33066: Fix table style
Bug-33066-Fix-table-style.patch (text/plain), 5.41 KB, created by
Jonathan Druart
on 2023-04-05 07:23:11 UTC
(
hide
)
Description:
Bug 33066: Fix table style
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2023-04-05 07:23:11 UTC
Size:
5.41 KB
patch
obsolete
>From ca6af7850af0e7bdedc2c14d4ad0faf577783056 Mon Sep 17 00:00:00 2001 >From: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Date: Sun, 26 Mar 2023 10:53:25 +0000 >Subject: [PATCH] Bug 33066: Fix table style >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Move table rendering outside <ol> to prevent unintended style in _forms.scss from being applied and causing table to not be full width >Remove unecessary table styling > >JD: following commit has been squashed. Patch from Pedro is fixing the >FIXME >""" >Bug 33066: Fix style - FIXME > >This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 >The table is not taking width: 100% >I fixed it previously with the display: table in the style block, but >here it's not applied. > >There is also the "green tick" (fa-check-square-o) that is not on the >same line https://snipboard.io/jma923.jpg >""" > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> > >Signed-off-by: AgustÃn Moyano <agustinmoyano@theke.io> >--- > .../prog/js/vue/components/ERM/AgreementsList.vue | 3 --- > .../ERM/EHoldingsEBSCOPackageTitlesList.vue | 3 --- > .../components/ERM/EHoldingsEBSCOPackagesShow.vue | 12 +++++------- > .../ERM/EHoldingsLocalPackageTitlesList.vue | 6 ------ > .../components/ERM/EHoldingsLocalPackagesShow.vue | 12 +++++------- > 5 files changed, 10 insertions(+), 26 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >index 12b0a5ea269..90e4f1b6c64 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >@@ -326,9 +326,6 @@ export default { > </script> > > <style scoped> >-#agreement_list { >- display: table; >-} > .filters > label[for="by_mine_filter"], > .filters > input[type="checkbox"], > .filters > input[type="button"] { >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue >index a9bc8c68d56..27441804e09 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackageTitlesList.vue >@@ -199,9 +199,6 @@ export default { > </script> > > <style scoped> >-#title_list { >- display: table; >-} > #filters { > margin: 0; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesShow.vue >index a90b0d1523f..4b440346726 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsEBSCOPackagesShow.vue >@@ -90,15 +90,13 @@ > <label > >Titles ({{ erm_package.resources_count }})</label > > >- <div v-if="erm_package.resources_count"> >- <EHoldingsPackageTitlesList >- :package_id="erm_package.package_id.toString()" >- /> >- </div> > </li> >- >- <li></li> > </ol> >+ <div v-if="erm_package.resources_count"> >+ <EHoldingsPackageTitlesList >+ :package_id="erm_package.package_id.toString()" >+ /> >+ </div> > </fieldset> > <fieldset class="action"> > <router-link >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageTitlesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageTitlesList.vue >index 7374c30675b..b94b44ca40b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageTitlesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackageTitlesList.vue >@@ -93,9 +93,3 @@ export default { > name: "EHoldingsLocalPackageTitlesList", > } > </script> >- >-<style scoped> >-#title_list { >- display: table; >-} >-</style> >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue >index 918205b6f14..5cf5455f56b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesShow.vue >@@ -82,15 +82,13 @@ > erm_package.resources_count > ) > }}</label> >- <div v-if="erm_package.resources_count"> >- <EHoldingsPackageTitlesList >- :package_id="erm_package.package_id.toString()" >- /> >- </div> > </li> >- >- <li></li> > </ol> >+ <div v-if="erm_package.resources_count"> >+ <EHoldingsPackageTitlesList >+ :package_id="erm_package.package_id.toString()" >+ /> >+ </div> > </fieldset> > <fieldset class="action"> > <router-link >-- >2.25.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33066
:
147352
|
147353
|
147354
|
147692
|
147693
|
147694
|
147713
|
147846
|
147847
|
147848
|
147849
|
147850
|
147851
|
147852
|
147853
|
147855
|
147856
|
147857
|
147858
|
147862
|
147865
|
147902
|
147903
|
147904
|
147905
|
147906
|
147907
|
147908
|
147909
|
147910
|
147911
|
147912
|
147913
|
147914
|
147915
|
147916
|
147917
|
147918
|
147921
|
147922
|
147923
|
147925
|
147926
|
147928
|
147957
|
147960
|
147971
|
147972
|
148718
|
149158
|
149159
|
149160
|
149161
|
149162
|
149163
|
149164
|
149165
|
149166
|
149167
|
149168
|
149169
|
149170
|
149171
|
149172
|
149173
|
149174
|
149175
|
149176
|
149177
|
149178
|
149179
|
149180
|
149181
|
149182
| 149183