The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now.
Created attachment 147352 [details] [review] Bug 33066: Introduce a KohaTable Vue component The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. The goal of this patch is to not duplicate the code in datatables.js, we don't want to maintain two version of this code (one is enough already!) We split the huge function in datatables.js in small ones to make them reusable from the Vue component. This is quite ugly, and it needs to lot more addition, but it's a first start! Help, ideas, and feedback welcome (and needed!)
Created attachment 147353 [details] [review] Bug 33066: Fix dt - no need to reselect
Created attachment 147354 [details] [review] Bug 33066: Add colvis
still needs to be done: * column filter needs to be dropdown list when needed (see preDrawCallback in AgreementsList.vue) * Remove useless code from AgreementsList.vue * Fix UI display when using ColVis * Improve "actions", it's really not nice how it's done (the -1 especifically) * Confirm default_search is working * Confirm default_filters is working
Hi Jonathan!, Great, I'll take a look at this as soon as I can. Thanks
Created attachment 147692 [details] [review] Bug 33066: Introduce a KohaTable Vue component The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. The goal of this patch is to not duplicate the code in datatables.js, we don't want to maintain two version of this code (one is enough already!) We split the huge function in datatables.js in small ones to make them reusable from the Vue component. This is quite ugly, and it needs to lot more addition, but it's a first start! Help, ideas, and feedback welcome (and needed!)
Created attachment 147693 [details] [review] Bug 33066: Fix dt - no need to reselect
Created attachment 147694 [details] [review] Bug 33066: Add colvis
When I fixed the dependency from bug 23991 to bug 32991 patches no longer applied, so I rebased it. The little code I could see it's ok and works as expected.
Created attachment 147713 [details] [review] Bug 33066: Fix search by vendor
(In reply to Agustín Moyano from comment #10) > Created attachment 147713 [details] [review] [review] > Bug 33066: Fix search by vendor Can you detail a bit? This is not working as expected: the empty table should not be displayed if there are no agreements, but the "There are no agreements defined" message instead. And so we need the "Loading..." back.
The table is not loading with this last patch, I get "Uncaught TypeError: row.vendor is null"
Created attachment 147846 [details] [review] Bug 33066: Fix "Loading..."
Created attachment 147847 [details] [review] Bug 33066: Reintroduce column filters
Created attachment 147848 [details] [review] Bug 33066: Fix name display
Created attachment 147849 [details] [review] Bug 33066: Remove build_datatable
Created attachment 147850 [details] [review] Bug 33066: Embed vendor and retrieve vendor name from the request
Created attachment 147851 [details] [review] Bug 33066: Remove duplicate 'Actions' column
Created attachment 147852 [details] [review] Bug 33066: Fix default_search
Created attachment 147853 [details] [review] Bug 33066: Fix default_filters Will need to be tested when EHoldingsEBSCOTitlesList.vue will be adjusted
Created attachment 147855 [details] [review] Bug 33066: Fix ColVis The filter (header) was not removed alongwith the column
Created attachment 147856 [details] [review] Bug 33066: Fix width after ColVis change This fixes the width to 100%, otherwise it is not recalculated correctly
Created attachment 147857 [details] [review] Bug 33066: Fix agreement name in delete confirmation dialog
Created attachment 147858 [details] [review] Bug 33066: Use KohaTable for LicensesList
Created attachment 147862 [details] [review] Bug 33066: Use KohaTable for LicensesList
Created attachment 147865 [details] [review] Bug 33066: Restore HTML escaping And we add a render function that will escape by default
I am done for today, feel free to have a look. I will continue tomorrow and adjust the other tables. Basically the diff that is needed can be seen on "Bug 33066: Use KohaTable for LicensesList".
Created attachment 147902 [details] [review] Bug 33066: Introduce a KohaTable Vue component The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. The goal of this patch is to not duplicate the code in datatables.js, we don't want to maintain two version of this code (one is enough already!) We split the huge function in datatables.js in small ones to make them reusable from the Vue component. This is quite ugly, and it needs to lot more addition, but it's a first start! Help, ideas, and feedback welcome (and needed!)
Created attachment 147903 [details] [review] Bug 33066: Fix dt - no need to reselect
Created attachment 147904 [details] [review] Bug 33066: Add colvis
Created attachment 147905 [details] [review] Bug 33066: Fix "Loading..."
Created attachment 147906 [details] [review] Bug 33066: Reintroduce column filters
Created attachment 147907 [details] [review] Bug 33066: Fix name display
Created attachment 147908 [details] [review] Bug 33066: Remove build_datatable
Created attachment 147909 [details] [review] Bug 33066: Embed vendor and retrieve vendor name from the request
Created attachment 147910 [details] [review] Bug 33066: Remove duplicate 'Actions' column
Created attachment 147911 [details] [review] Bug 33066: Fix default_search
Created attachment 147912 [details] [review] Bug 33066: Fix default_filters Will need to be tested when EHoldingsEBSCOTitlesList.vue will be adjusted
Created attachment 147913 [details] [review] Bug 33066: Fix ColVis The filter (header) was not removed alongwith the column
Created attachment 147914 [details] [review] Bug 33066: Fix width after ColVis change This fixes the width to 100%, otherwise it is not recalculated correctly
Created attachment 147915 [details] [review] Bug 33066: Fix agreement name in delete confirmation dialog
Created attachment 147916 [details] [review] Bug 33066: Use KohaTable for LicensesList
Created attachment 147917 [details] [review] Bug 33066: Restore HTML escaping And we add a render function that will escape by default
Created attachment 147918 [details] [review] Bug 33066: Restore filter by mine
Rebased patches + last patch is fixing the "additional filters" we are passing to KohaTable. I have tried several things and it's the only way that makes things work, it reads weird and ugly however. Suggestions welcomed!
Created attachment 147921 [details] [review] Bug 33066: Use KohaTable for EHoldingsLocalPackagesList
Created attachment 147922 [details] [review] Bug 33066: Use KohaTable for EHoldingsLocalPackageTitlesList
Created attachment 147923 [details] [review] Bug 33066: Fix style - FIXME This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 The table is not taking width: 100% I fixed it previously with the display: table in the style block, but here it's not applied.
(In reply to Jonathan Druart from comment #48) > Created attachment 147923 [details] [review] [review] > Bug 33066: Fix style - FIXME > > This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 > The table is not taking width: 100% > I fixed it previously with the display: table in the style block, but > here it's not applied. This patch is not working, I don't understand what's happening!
Created attachment 147925 [details] [review] Bug 33066: Use KohaTable for EHoldingsLocalTitlePackagesList
Created attachment 147926 [details] [review] Bug 33066: Use KohaTable for EHoldingsLocalPackagesList
(In reply to Jonathan Druart from comment #51) > Created attachment 147926 [details] [review] [review] > Bug 33066: Use KohaTable for EHoldingsLocalPackagesList This is not working because we were not using kohaTable from this component, but dataTable => not ajax but data from array directly. We could adjust our KohaTable Vue component to deal with that, but that's for another day...
Created attachment 147928 [details] [review] Bug 33066: Use KohaTable for EHoldingsLocalTitlesList
Created attachment 147957 [details] [review] Bug 33066: (follow-up) Use KohaTable for EHoldingsLocalTitlePackagesList
Created attachment 147960 [details] [review] Bug 33066: Use KohaTable for EHoldingsEBSCOPackagesList
(In reply to Jonathan Druart from comment #55) This needs the last patch from 32983 to apply correctly
Remote branch up-to-date with master is at https://gitlab.com/joubu/Koha/-/commits/bug_33066 There are 2 components left: EHoldingsEBSCOPackageTitlesList and EHoldingsEBSCOTitlesList I won't be able to finish this before the next two weeks unfortunately.
Created attachment 147971 [details] [review] Bug 33066: Restore '(#id)' to lists
Created attachment 147972 [details] [review] Bug 33066: Fix agreements and licenses cypress tests
I want to pick this up but not sure if I have the time to dedicate to it in the next few days.
Ready for signoff, the patches are on the remote branch at https://gitlab.com/joubu/Koha/-/commits/bug_33066
I've added a couple of follow-ups to the remote branch.
Created attachment 148718 [details] [review] Bug 33066: Fix table style Move table rendering outside <ol> to prevent unintended style in _forms.scss from being applied and causing table to not be full width Remove unecessary table styling
@Joubu the above patch sits on top of https://gitlab.com/joubu/Koha/-/commits/bug_33066 I believe it fixes the styling problem with the related resources table not going full width. Important: Please test EBSCO well, I have not tested EHoldingsEBSCOPackageTitlesList because I lack the EBSCO credentials at this time.
I have tested and reviewed this code and everything seems to be working nicely. Not 100% familiarized with the previous datatables code so can't say there is 100% feature parity but it seems to be. I think this is ready for squashing and sign-off at this point.
(In reply to Pedro Amorim from comment #63) > Created attachment 148718 [details] [review] [review] > Bug 33066: Fix table style > > Move table rendering outside <ol> to prevent unintended style in _forms.scss > from being applied and causing table to not be full width > Remove unecessary table styling Added to the remote branch, thanks! Remote branch rebased and some patches have been squashed.
(In reply to Jonathan Druart from comment #49) > (In reply to Jonathan Druart from comment #48) > > Created attachment 147923 [details] [review] [review] [review] > > Bug 33066: Fix style - FIXME > > > > This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 > > The table is not taking width: 100% > > I fixed it previously with the display: table in the style block, but > > here it's not applied. > > This patch is not working, I don't understand what's happening! The patch from Pedro is fixing both problems.
Signed-off from me
Added your signed-off-by lines to the remote branch, thanks a lot!
Created attachment 149158 [details] [review] Bug 33066: Introduce a KohaTable Vue component The way we deal with DataTables in Vue component is not nice, especially when we need to add buttons/link in the cell and interact with the rest of the Vue app from there. When I started to work on Vue last year there was no good solution from DataTables, now there is a Vue component. It is not perfect, you still cannot add Vue component in the DT component, but it brings something to follow. Agustin implemented something on theke/import_source_vue, but he went too far, and it will need to rewrite the whole ERM module. Additionally he didn't provide a solution that has the same features as what we have now. The goal of this patch is to not duplicate the code in datatables.js, we don't want to maintain two version of this code (one is enough already!) We split the huge function in datatables.js in small ones to make them reusable from the Vue component. This is quite ugly, and it needs to lot more addition, but it's a first start! Help, ideas, and feedback welcome (and needed!) Bug 33066: Fix agreement name in delete confirmation dialog Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149159 [details] [review] Bug 33066: Fix dt - no need to reselect Bug 33066: (follow-up) Fix dt - no need to reselect Patron search result table was not displayed correctly Uncaught TypeError: this.on is not a function Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149160 [details] [review] Bug 33066: Add colvis Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149161 [details] [review] Bug 33066: Fix "Loading..." Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149162 [details] [review] Bug 33066: Reintroduce column filters Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149163 [details] [review] Bug 33066: Fix name display Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149164 [details] [review] Bug 33066: Remove build_datatable Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149165 [details] [review] Bug 33066: Embed vendor and retrieve vendor name from the request Bug 33066: (follow-up) Embed vendor and retrieve vendor name from the request It needs "Bug 32923: Allow to embed user_roles for agreements" Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149166 [details] [review] Bug 33066: Remove duplicate 'Actions' column Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149167 [details] [review] Bug 33066: Fix default_search Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149168 [details] [review] Bug 33066: Fix default_filters Will need to be tested when EHoldingsEBSCOTitlesList.vue will be adjusted Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149169 [details] [review] Bug 33066: Fix ColVis The filter (header) was not removed alongwith the column Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149170 [details] [review] Bug 33066: Fix width after ColVis change This fixes the width to 100%, otherwise it is not recalculated correctly Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149171 [details] [review] Bug 33066: Use KohaTable for LicensesList Bug 33066: (follow-up) Use KohaTable for LicensesList There was a mismatch, we can embed the whole vendor object info. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149172 [details] [review] Bug 33066: Restore HTML escaping And we add a render function that will escape by default Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149173 [details] [review] Bug 33066: Restore filter by mine Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149174 [details] [review] Bug 33066: Use KohaTable for EHoldingsLocalPackagesList Bug 33066: (follow-up) Use KohaTable for EHoldingsLocalTitlePackagesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149175 [details] [review] Bug 33066: Use KohaTable for EHoldingsLocalPackageTitlesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149176 [details] [review] Bug 33066: Use KohaTable for EHoldingsLocalTitlesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149177 [details] [review] Bug 33066: Use KohaTable for EHoldingsEBSCOPackagesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149178 [details] [review] Bug 33066: Restore '(#id)' to lists Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149179 [details] [review] Bug 33066: Use KohaTable for EHoldingsEBSCOPackageTitlesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149180 [details] [review] Bug 33066: Use KohaTable for EHoldingsEBSCOTitlesList Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149181 [details] [review] Bug 33066: Remove useless use of useDataTable Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149182 [details] [review] Bug 33066: Fix cypress tests Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Created attachment 149183 [details] [review] Bug 33066: Fix table style Move table rendering outside <ol> to prevent unintended style in _forms.scss from being applied and causing table to not be full width Remove unecessary table styling JD: following commit has been squashed. Patch from Pedro is fixing the FIXME """ Bug 33066: Fix style - FIXME This is not working, see /cgi-bin/koha/erm/eholdings/local/packages/1 The table is not taking width: 100% I fixed it previously with the display: table in the style block, but here it's not applied. There is also the "green tick" (fa-check-square-o) that is not on the same line https://snipboard.io/jma923.jpg """ Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Agustín Moyano <agustinmoyano@theke.io>
Pushed to master for 23.05. Nice work everyone, thanks!
It looks like this broke Jenkins.
(In reply to Katrin Fischer from comment #98) > It looks like this broke Jenkins. Hey, we need the images rebuilt with the new deps. thanks for reporting.
ERM is totally broken for me :( I have tried it all: git pull, ktd down, ktd pull, ktd up, etc. But I am still stuck with that and no table will display: Source map error: Error: unsupported protocol for sourcemap request webpack://koha/node_modules/vue-select/dist/vue-select.js.map Resource URL: webpack://koha/./node_modules/vue-select/dist/vue-select.js? Source Map URL: vue-select.js.map [Vue warn]: Unhandled error during execution of render function at <DataTable columns= Array(8) [ Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, {…} ] options= Object { language: {…}, dom: '<"dt-info"i><"top pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons: Proxy, lengthMenu: (2) […], pageLength: 20, fixedHeader: true, initComplete: initComplete(settings), deferRender: true, paging: true, serverSide: true, … } data= Array [] ... > at <KohaTable ref="table" columns= Array(7) [ {…}, {…}, {…}, {…}, {…}, {…}, {…} ] url="/api/v1/erm/licenses" ... > at <LicensesList onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< Proxy { <target>: {…}, <handler>: {…} } > > at <RouterView> at <Main> runtime-core.esm-bundler.js:167:17 [Vue warn]: Unhandled error during execution of scheduler flush. This is likely a Vue internals bug. Please open an issue at https://new-issue.vuejs.org/?repo=vuejs/core at <DataTable columns= Array(8) [ Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, Proxy, {…} ] options= Object { language: {…}, dom: '<"dt-info"i><"top pager"<"table_entries"lp><"table_controls"fB>>tr<"bottom pager"ip>', buttons: Proxy, lengthMenu: (2) […], pageLength: 20, fixedHeader: true, initComplete: initComplete(settings), deferRender: true, paging: true, serverSide: true, … } data= Array [] ... > at <KohaTable ref="table" columns= Array(7) [ {…}, {…}, {…}, {…}, {…}, {…}, {…} ] url="/api/v1/erm/licenses" ... > at <LicensesList onVnodeUnmounted=fn<onVnodeUnmounted> ref=Ref< Proxy { <target>: {…}, <handler>: {…} } > > at <RouterView> at <Main> runtime-core.esm-bundler.js:167:17 Uncaught (in promise) TypeError: currentRenderingInstance is null renderSlot webpack://koha/../node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:3092 render VueJS renderComponentRoot webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:1028 componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5730 run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225 update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844 setupRenderEffect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858 mountComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640 processComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200 componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5737 run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225 update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844 setupRenderEffect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5858 mountComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5640 processComponent webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5598 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5200 mountChildren webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384 mountElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294 processElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197 mountChildren webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5384 mountElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5294 processElement webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5277 patch webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5197 componentUpdateFn webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5810 run webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:225 update webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5844 callWithErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:284 flushJobs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:514 promise callback*queueFlush webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:406 queueJob webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:400 effect webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:5842 triggerEffect webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:430 triggerEffects webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:420 trigger webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:392 set webpack://koha/./node_modules/@vue/reactivity/dist/reactivity.esm-bundler.js?:559 set webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:3311 beforeRouteEnter webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:68 promise callback*beforeRouteEnter/< webpack://koha/./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue?./node_modules/vue-loader/dist/index.js??ruleSet[1].rules[5].use[0]:68 setup webpack://koha/./node_modules/vue-router/dist/vue-router.cjs?:2385 setup webpack://koha/./node_modules/vue-router/dist/vue-router.cjs?:2385 callWithErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:284 callWithAsyncErrorHandling webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:293 job webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:1915 flushPostFlushCbs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:467 flushJobs webpack://koha/./node_modules/@vue/runtime-core/dist/runtime-core.esm-bundler.js?:521 erm_22.1200019.js line 3481 > eval:3092:9
Fixed by a yarn install before yarn build.
Enhancement - not backporting to 22.11.x Nice work everyone!
Whilst this is most certainly an enhancement.. it's an important architectural one for ERM. I've decided to overrule the decision made not to backport as I believe, especially as this is an LTS release, we need it to ensure we can continue to maintain ERM going forward for the rest of the maintanence period.
Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release
Not needed for 22.05.x, no backport.