Bugzilla – Attachment 149346 Details for
Bug 33005
Use template wrapper for breadcrumbs: Acquisitions part 3
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33001: (follow-up) Add spans for translatability
Bug-33001-follow-up-Add-spans-for-translatability.patch (text/plain), 7.79 KB, created by
Katrin Fischer
on 2023-04-09 11:21:22 UTC
(
hide
)
Description:
Bug 33001: (follow-up) Add spans for translatability
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2023-04-09 11:21:22 UTC
Size:
7.79 KB
patch
obsolete
>From 21561d85664dbac0892eff82c92a148c7e181011 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Thu, 23 Feb 2023 22:53:02 +0000 >Subject: [PATCH] Bug 33001: (follow-up) Add spans for translatability > >This patch finds places in the updated breadcrumbs markup where a >translatable string is isolated in a way that makes it hard for the >translation script to find it, and wraps these strings with <span> > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> > >https://bugs.koha-community.org/show_bug.cgi?id=33005 >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt | 4 ++-- > .../intranet-tmpl/prog/en/modules/acqui/invoice-files.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt | 2 +- > .../intranet-tmpl/prog/en/modules/acqui/moddeliverydate.tt | 2 +- > .../intranet-tmpl/prog/en/modules/acqui/modordernotes.tt | 6 +++++- > .../intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 4 ++-- > .../prog/en/modules/acqui/neworderempty_duplicate.tt | 2 +- > .../prog/en/modules/acqui/newordersubscription.tt | 2 +- > 9 files changed, 15 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt >index 4865bec71c..3ee9d7dc3b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/histsearch.tt >@@ -24,11 +24,11 @@ > <a href="/cgi-bin/koha/acqui/histsearch.pl">Orders search</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Search results >+ <span>Search results</span> > [% END %] > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Order search >+ <span>Order search</span> > [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice-files.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice-files.tt >index dfc829b1a1..c86109b326 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice-files.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice-files.tt >@@ -24,7 +24,7 @@ > <a href="/cgi-bin/koha/acqui/invoice.pl?invoiceid=[% invoiceid | uri %]">[% invoicenumber | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Files >+ <span>Files</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt >index 160ea96563..dcf0c3e0c3 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt >@@ -21,7 +21,7 @@ > <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Invoices >+ <span>Invoices</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt >index 0700170fb6..1a502c41e7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/lateorders.tt >@@ -21,7 +21,7 @@ > <a href="/cgi-bin/koha/acqui/acqui-home.pl">Acquisitions</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Late orders >+ <span>Late orders</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/moddeliverydate.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/moddeliverydate.tt >index 1c718647cf..812e28b1bb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/moddeliverydate.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/moddeliverydate.tt >@@ -21,7 +21,7 @@ > <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno | uri %]">Basket [% basketname | html %] ([% basketno | html %])</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Change estimated delivery date >+ <span>Change estimated delivery date</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/modordernotes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/modordernotes.tt >index 98e6742a63..6feb14b9a6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/modordernotes.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/modordernotes.tt >@@ -24,7 +24,11 @@ > <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno | uri %]">Basket [% basketname | html %] ([% basketno | html %])</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active=1 %] >- Change order [% IF (type == "vendor") %]vendor[% ELSE %]internal[% END %] note >+ [% IF (type == "vendor") %] >+ <span>Change order's vendor note</span> >+ [% ELSE %] >+ <span>Change order's internal note</span> >+ [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >index 4e35ed156a..2eb84b61b9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt >@@ -56,11 +56,11 @@ > [% END %] > [% IF ( ordernumber ) %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Modify order details (line #[% ordernumber | html %]) >+ <span>Modify order details (line #[% ordernumber | html %])</span> > [% END %] > [% ELSE %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- New order >+ <span>New order</span> > [% END %] > [% END %] > [% END #/ WRAPPER breadcrumbs %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty_duplicate.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty_duplicate.tt >index 2a87fe78ed..39833a96c6 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty_duplicate.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty_duplicate.tt >@@ -18,7 +18,7 @@ > <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno | uri %]">Basket [% basketno | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Duplicate warning >+ <span>Duplicate warning</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt >index 86db364bba..e2558595fd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt >@@ -27,7 +27,7 @@ > <a href="/cgi-bin/koha/acqui/basket.pl?basketno=[% basketno | uri %]">Basket [% basketno | html %]</a> > [% END %] > [% WRAPPER breadcrumb_item bc_active= 1 %] >- Add order from a subscription >+ <span>Add order from a subscription</span> > [% END %] > [% END #/ WRAPPER breadcrumbs %] > [% END #/ WRAPPER sub-header.inc %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33005
:
146922
|
147323
|
149241
|
149242
|
149340
|
149341
|
149342
|
149343
|
149344
|
149345
|
149346