Attachment 150109 Details for Bug 32871 – Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl

[patch] Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl

Bug-32871-Fix-cataloguingvaluebuilderunimarcfield2.patch (text/plain), 1.93 KB, created by Katrin Fischer on 2023-04-22 22:56:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-04-22 22:56:57 UTC

Size: 1.93 KB

patch

obsolete

>From 98e38513cbe80e21f0cd5bfe0edc7bb553f80b07 Mon Sep 17 00:00:00 2001
>From: Julian Maurice <julian.maurice@biblibre.com>
>Date: Fri, 3 Feb 2023 11:58:55 +0100
>Subject: [PATCH] Bug 32871: Fix
> cataloguing/value_builder/unimarc_field_225a.pl
>
>Use event parameter
>
>This is part of the refactoring happening in bug 30975
>
>Test plan:
>1. Verify that the plugin continues to work as before
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> cataloguing/value_builder/unimarc_field_225a.pl | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/cataloguing/value_builder/unimarc_field_225a.pl b/cataloguing/value_builder/unimarc_field_225a.pl
>index 31556ae506..d882e403a6 100755
>--- a/cataloguing/value_builder/unimarc_field_225a.pl
>+++ b/cataloguing/value_builder/unimarc_field_225a.pl
>@@ -62,8 +62,9 @@ sub plugin_javascript {
>     <script>
>     
>     
>-        function Clic$function_name(index) {
>+        function Clic$function_name(event) {
>         /* find the 010a value and the 210c. it will be used in the popup to find possibles collections */
>+            event.preventDefault();
>             var isbn_found   = 0;
>             var editor_found = 0;
>             
>@@ -81,8 +82,8 @@ sub plugin_javascript {
>                 }
>             }
>                     
>-            defaultvalue = document.getElementById(\"$field_number\").value;
>-            window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_225a.pl&index=\"+index+\"&result=\"+defaultvalue+\"&editor_found=\"+editor_found,\"unimarc225a\",'width=500,height=400,toolbar=false,scrollbars=no');
>+            defaultvalue = document.getElementById(event.data.id).value;
>+            window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=unimarc_field_225a.pl&index=\"+event.data.id+\"&result=\"+defaultvalue+\"&editor_found=\"+editor_found,\"unimarc225a\",'width=500,height=400,toolbar=false,scrollbars=no');
>     
>         }
>     </script>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32871: 146137 | 146805 | 150109