Bug 32871 - Fix cataloguing/value_builder/unimarc_field_225a.pl
Summary: Fix cataloguing/value_builder/unimarc_field_225a.pl
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Julian Maurice
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 30975
  Show dependency treegraph
 
Reported: 2023-02-03 14:02 UTC by Julian Maurice
Modified: 2023-12-28 20:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06


Attachments
Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl (1.82 KB, patch)
2023-02-03 14:03 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl (1.87 KB, patch)
2023-02-17 10:18 UTC, Julian Maurice
Details | Diff | Splinter Review
Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl (1.93 KB, patch)
2023-04-22 22:56 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Julian Maurice 2023-02-03 14:02:18 UTC
This is part of the refactoring happening in bug 30975
Comment 1 Julian Maurice 2023-02-03 14:03:11 UTC
Created attachment 146137 [details] [review]
Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 2 Julian Maurice 2023-02-17 10:18:06 UTC
Created attachment 146805 [details] [review]
Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before
Comment 3 David Nind 2023-03-30 19:42:47 UTC
I'm not familiar enough with UNIMARC to figure out how to use this plugin.

Could you describe how to use this one? For example, which subfields to add this to, how to use it, and what it does.

Thanks!

David
Comment 4 Katrin Fischer 2023-04-22 22:56:57 UTC
Created attachment 150109 [details] [review]
Bug 32871: Fix cataloguing/value_builder/unimarc_field_225a.pl

Use event parameter

This is part of the refactoring happening in bug 30975

Test plan:
1. Verify that the plugin continues to work as before

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Katrin Fischer 2023-04-22 22:57:40 UTC
This one is more complex:

 23 This plugin is used to map isbn/editor with collection.
 24 It need :
 25   in thesaurus, a category named EDITORS
 26   in this category, datas must be entered like following :
 27   isbn separator editor separator collection.
 28   for example :
 29   2204 -- Cerf -- Cogitatio fidei
 30   2204 -- Cerf -- Le Magistere de l'Eglise
 31   2204 -- Cerf -- Lectio divina
 32   2204 -- Cerf -- Lire la Bible
 33   2204 -- Cerf -- Pour lire
 34   2204 -- Cerf -- Sources chretiennes
 35 
 36   when the user clic on ... on 225a line, the popup shows the list of collections from the selected editor
 37   if the biblio has no isbn, then the search if done on editor only
 38   If the biblio ha an isbn, the search is done on isbn and editor. It's faster.
Comment 6 Katrin Fischer 2023-04-22 22:57:57 UTC
... and through to Tomas.
Comment 7 Tomás Cohen Arazi 2023-04-24 13:49:39 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 8 Jacob O'Mara 2023-05-10 12:54:18 UTC
Nice work, thanks everyone!

Pushed to 22.11.x for the next release.