Bugzilla – Attachment 15013 Details for
Bug 8733
Adding critic reviews to book pages
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8733: Follow-up The isbn sent to idream contains dash
Bug-8733-Follow-up-The-isbn-sent-to-idream-contain.patch (text/plain), 1.52 KB, created by
Jared Camins-Esakov
on 2013-02-01 15:42:01 UTC
(
hide
)
Description:
Bug 8733: Follow-up The isbn sent to idream contains dash
Filename:
MIME Type:
Creator:
Jared Camins-Esakov
Created:
2013-02-01 15:42:01 UTC
Size:
1.52 KB
patch
obsolete
>From 66bd73eab6d1e0cb41701a5e2e2796a7d34effec Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 1 Feb 2013 13:38:13 +0100 >Subject: [PATCH] Bug 8733: Follow-up The isbn sent to idream contains dash > >Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index a8e13be..07d4f68 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -186,6 +186,7 @@ $(function () { > var isbn = $(".isbn:last").text().split(" ")[1]; > if (isbn) { > isbn = isbn.replace(/\W*$/, ''); >+ isbn = isbn.replace(/-/, ''); > > if ($.browser.msie && parseInt($.browser.version, 10) >= 8 && window.XDomainRequest) { > // Use Microsoft XDR for IE version 8 or above >@@ -210,6 +211,7 @@ $(function () { > function parseIDBJSON( json ) { > if(json.total_results > 0 && json.book.rating > 0){ > var isbn = $(".isbn:last").text().split(" ")[1]; >+ isbn = isbn.replace(/-/, ''); > > [% IF ( IDreamBooksReadometer ) %] > $(".title").append('<a href="'+json.book.detail_link+'" id="idreambooksreadometer"><img src="http://idreambooks.com/remotereadometer/'+isbn+'.jpg" alt="'+json.book.title+' by '+json.book.author+'" title="Rating based on reviews of '+json.book.title+'"></a>'); >-- >1.7.9.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8733
:
11996
|
12015
|
12016
|
12017
|
12018
|
12493
|
12501
|
12583
|
12587
|
12588
|
14345
|
14980
|
15001
|
15012
|
15013
|
15024
|
15025
|
15026