Attachment 150216 Details for Bug 28315 – Bug 28315: Remove duplicate function definition

[patch] Bug 28315: Remove duplicate function definition

Bug-28315-Remove-duplicate-function-definition.patch (text/plain), 1.94 KB, created by Lucas Gass (lukeg) on 2023-04-25 20:22:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2023-04-25 20:22:28 UTC

Size: 1.94 KB

patch

obsolete

>From 5f48a77d7667b9dac5dccc6cd4127d8d1045ae98 Mon Sep 17 00:00:00 2001
>From: Philip Orr <philip.orr@lmscloud.de>
>Date: Tue, 25 Apr 2023 10:34:09 +0000
>Subject: [PATCH] Bug 28315: Remove duplicate function definition
>
>This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt.
>To test:
>1. Apply the patch
>2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc
>3. Navigate to "Cataloging" -> "Add MARC record"
>4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> .../prog/en/modules/cataloguing/addbiblio.tt       | 14 --------------
> 1 file changed, 14 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>index 7e33f115d4..6eba842bc3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
>@@ -462,20 +462,6 @@ function PopupMARCFieldDoc(field) {
>         }
>     }
> 
>-    function PopupMARCFieldDoc(field) {
>-        [% IF Koha.Preference('marcfielddocurl') %]
>-            var docurl = "[% Koha.Preference('marcfielddocurl').replace('"','&quot;') | html %]";
>-            docurl = docurl.replace("{MARC}", "[% marcflavour | html %]");
>-            docurl = docurl.replace("{FIELD}", ""+field);
>-            docurl = docurl.replace("{LANG}", "[% lang | html %]");
>-            window.open(docurl);
>-        [% ELSIF ( marcflavour == 'MARC21' ) %]
>-            _MARC21FieldDoc(field);
>-        [% ELSIF ( marcflavour == 'UNIMARC' ) %]
>-            _UNIMARCFieldDoc(field);
>-        [% END %]
>-    }
>-
>     function _MARC21FieldDoc(field) {
>         if(field == 0) {
>             window.open("http://www.loc.gov/marc/bibliographic/bdleader.html");
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 28315: 150183 | 150216 | 150366