Bug 28315 - PopupMARCFieldDoc is defined twice in addbiblio.tt
Summary: PopupMARCFieldDoc is defined twice in addbiblio.tt
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Philip Orr
QA Contact: Testopia
URL:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2021-05-11 07:58 UTC by Martin Renvoize
Modified: 2023-12-28 20:47 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.06,22.05.14,21.11.22


Attachments
Bug #28315: Remove duplicate function definition (1.89 KB, patch)
2023-04-25 10:48 UTC, Philip Orr
Details | Diff | Splinter Review
Bug 28315: Remove duplicate function definition (1.94 KB, patch)
2023-04-25 20:22 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 28315: Remove duplicate function definition (2.00 KB, patch)
2023-04-28 12:24 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2021-05-11 07:58:58 UTC
The `PopupMARCFieldDoc` JS function is defined twice in addbiblio.tt.. probably a merge error at some point.. should be easily resolved.
Comment 1 Philip Orr 2023-04-25 10:48:21 UTC
Created attachment 150183 [details] [review]
Bug #28315: Remove duplicate function definition

This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt.
To test:
1. Apply the patch
2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc
3. Navigate to "Cataloging" -> "Add MARC record"
4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab
Comment 2 Lucas Gass 2023-04-25 20:22:28 UTC
Created attachment 150216 [details] [review]
Bug 28315: Remove duplicate function definition

This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt.
To test:
1. Apply the patch
2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc
3. Navigate to "Cataloging" -> "Add MARC record"
4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Nick Clemens 2023-04-28 12:24:46 UTC
Created attachment 150366 [details] [review]
Bug 28315: Remove duplicate function definition

This patch removes the unnecessary second definition of the JS function PopupMARCFieldDoc from addbiblio.tt.
To test:
1. Apply the patch
2. Check that addbiblio.tt contains only one function definition for PopupMARCFieldDoc
3. Navigate to "Cataloging" -> "Add MARC record"
4. Check that after clicking on the question mark symbol next to any MARC field, the loc description of that MARC field is opened in a new tab

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Tomás Cohen Arazi 2023-05-09 13:51:22 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 5 Matt Blenkinsop 2023-05-15 10:09:52 UTC
Nice work everyone!

Pushed to stable for 22.11.x
Comment 6 Lucas Gass 2023-06-15 16:40:39 UTC
Backported to 22.05.x for upcoming 22.05.14
Comment 7 Danyon Sewell 2023-07-24 23:53:27 UTC
Backported to 21.11.x for upcoming 21.11.22