Attachment 150554 Details for Bug 33541 – Bug 33541: Add document type to list of suggestions when ordering

[patch] Bug 33541: Add document type to list of suggestions when ordering

Bug-33541-Add-document-type-to-list-of-suggestions.patch (text/plain), 2.27 KB, created by Katrin Fischer on 2023-05-02 22:30:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-05-02 22:30:59 UTC

Size: 2.27 KB

patch

obsolete

>From 87565b60a4ada4897afb68659abd6a1c4c71052e Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <katrin.fischer.83@web.de>
>Date: Sun, 16 Apr 2023 14:01:10 +0000
>Subject: [PATCH] Bug 33541: Add document type to list of suggestions when
> ordering
>
>This adds the document type (suggestions.itemtype) to the list
>of accepted suggestions when creating an order from a suggestion.
>
>To test:
>* Add some suggestions and make sure to pick different document types.
>* Accept those suggestions in the staff interface.
>* Go to acquisitions
>* Create a basket
>* Add an 'order from a suggestion'
>* Verify that the list shows the 'document type' nicely and correctly
>* Order one, all good? sign off.
>
>Signed-off-by: Juliet <jheltibridle@rcplib.org>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Removed IS_OPAC param from AuthorisedValues.GetByCode
>---
> .../intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt
>index 817e0eddd2..631698a61a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt
>@@ -2,6 +2,7 @@
> [% USE Branches %]
> [% USE Price %]
> [% USE Asset %]
>+[% USE AuthorisedValues %]
> [% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
>@@ -46,6 +47,7 @@
> <tr>
> <th>Mine</th>
> <th>Suggestion</th>
>+ <th>Document type</th>
> <th>Suggested by</th>
> <th>Accepted by</th>
> <th>Library</th>
>@@ -72,6 +74,7 @@
> [% IF ( suggestion.note ) %]([% suggestion.note | html %]) [% END %]
> 
> </td>
>+ <td>[% AuthorisedValues.GetByCode( 'SUGGEST_FORMAT', suggestion.itemtype ) | html %]</td>
> <td>[% INCLUDE 'patron-title.inc' patron => suggestion.suggester %]</td>
> <td>[% INCLUDE 'patron-title.inc' patron => suggestion.manager %]</td>
> <td>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33541: 149730 | 149731 | 150554 | 150562