Bug 33541 - Show 'Document type' in list of suggestions when creating an order from a suggestion
Summary: Show 'Document type' in list of suggestions when creating an order from a sug...
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Katrin Fischer
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-04-16 13:59 UTC by Katrin Fischer
Modified: 2023-06-08 16:25 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
The 'Document type' of a suggestion will now be visible in the list of accepted suggestions when creating a new order line. This is to help with ordering the right material type and also for picking the correct item type.
Version(s) released in:
23.05.00
Circulation function:


Attachments
Bug 33541: Add document type to list of suggestions when ordering (2.12 KB, patch)
2023-04-16 14:17 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33541: Add document type to list of suggestions when ordering (2.17 KB, patch)
2023-04-16 16:40 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 33541: Add document type to list of suggestions when ordering (2.27 KB, patch)
2023-05-02 22:30 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 33541: Add document type to list of suggestions when ordering (2.35 KB, patch)
2023-05-03 06:50 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2023-04-16 13:59:51 UTC

    
Comment 1 Katrin Fischer 2023-04-16 14:17:10 UTC
Created attachment 149730 [details] [review]
Bug 33541: Add document type to list of suggestions when ordering

This adds the document type (suggestions.itemtype) to the list
of accepted suggestions when creating an order from a suggestion.

To test:
* Add some suggestions and make sure to pick different document types.
* Accept those suggestions in the staff interface.
* Go to acquisitions
* Create a basket
* Add an 'order from a suggestion'
* Verify that the list shows the 'document type' nicely and correctly
* Order one, all good? sign off.
Comment 2 ByWater Sandboxes 2023-04-16 16:40:12 UTC
Created attachment 149731 [details] [review]
Bug 33541: Add document type to list of suggestions when ordering

This adds the document type (suggestions.itemtype) to the list
of accepted suggestions when creating an order from a suggestion.

To test:
* Add some suggestions and make sure to pick different document types.
* Accept those suggestions in the staff interface.
* Go to acquisitions
* Create a basket
* Add an 'order from a suggestion'
* Verify that the list shows the 'document type' nicely and correctly
* Order one, all good? sign off.

Signed-off-by: Juliet <jheltibridle@rcplib.org>
Comment 3 Katrin Fischer 2023-04-16 16:41:05 UTC
That was fast! Thank you, Juliet!
Comment 4 David Nind 2023-04-16 20:07:54 UTC
Hi Juliet.

If you could edit status to change it to 'Signed off', that would be great!

This will give you credit for the sign off in the dashboard - it will then show under Signoffs - April (https://dashboard.koha-community.org/).

David
Comment 5 Jonathan Druart 2023-04-25 18:48:41 UTC
This table can be configured, you need to update admin/columns_settings.yml

Also you don't need the third parameter (opac=0), it's the default value.
Comment 6 Katrin Fischer 2023-05-02 22:30:59 UTC
Created attachment 150554 [details] [review]
Bug 33541: Add document type to list of suggestions when ordering

This adds the document type (suggestions.itemtype) to the list
of accepted suggestions when creating an order from a suggestion.

To test:
* Add some suggestions and make sure to pick different document types.
* Accept those suggestions in the staff interface.
* Go to acquisitions
* Create a basket
* Add an 'order from a suggestion'
* Verify that the list shows the 'document type' nicely and correctly
* Order one, all good? sign off.

Signed-off-by: Juliet <jheltibridle@rcplib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Removed IS_OPAC param from AuthorisedValues.GetByCode
Comment 7 Katrin Fischer 2023-05-02 22:31:21 UTC
(In reply to Jonathan Druart from comment #5)
> This table can be configured, you need to update admin/columns_settings.yml

I think you are confusing the tables. suggestions is, but newordersuggestion is not configurable. This is the table with accepted suggestions shown when using "ordering from suggestion". It has no table configuration icons and I didn't find it in the config.

> Also you don't need the third parameter (opac=0), it's the default value.

Fixed.
Comment 8 Jonathan Druart 2023-05-03 06:50:52 UTC
Created attachment 150562 [details] [review]
Bug 33541: Add document type to list of suggestions when ordering

This adds the document type (suggestions.itemtype) to the list
of accepted suggestions when creating an order from a suggestion.

To test:
* Add some suggestions and make sure to pick different document types.
* Accept those suggestions in the staff interface.
* Go to acquisitions
* Create a basket
* Add an 'order from a suggestion'
* Verify that the list shows the 'document type' nicely and correctly
* Order one, all good? sign off.

Signed-off-by: Juliet <jheltibridle@rcplib.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Removed IS_OPAC param from AuthorisedValues.GetByCode

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 9 Jonathan Druart 2023-05-03 06:51:19 UTC
(In reply to Katrin Fischer from comment #7)
> (In reply to Jonathan Druart from comment #5)
> > This table can be configured, you need to update admin/columns_settings.yml
> 
> I think you are confusing the tables. suggestions is, but newordersuggestion
> is not configurable. This is the table with accepted suggestions shown when
> using "ordering from suggestion". It has no table configuration icons and I
> didn't find it in the config.

Indeed, I was looking at the wrong table!
Comment 10 Tomás Cohen Arazi 2023-05-16 18:19:33 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 11 Matt Blenkinsop 2023-06-08 16:25:08 UTC
Enhancement - not backporting to 22.11.x