Attachment 150576 Details for Bug 30367 – Bug 30367: (follow-up) Same adjustment for gitlab

[patch] Bug 30367: (follow-up) Same adjustment for gitlab

Bug-30367-follow-up-Same-adjustment-for-gitlab.patch (text/plain), 1.47 KB, created by Jonathan Druart on 2023-05-03 11:45:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-05-03 11:45:31 UTC

Size: 1.47 KB

patch

obsolete

>From dad52feed7620d0584f0ea813264f777484ab300 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 3 May 2023 10:58:22 +0000
>Subject: [PATCH] Bug 30367: (follow-up) Same adjustment for gitlab
>
>This adds the same update for gitlab code. I was unable to trigger the error,
>however, I confirm searching for 'PayPal' returns a result after this patch
>as well as before.
>
>JD amended patch: fix indentation
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> plugins/plugins-home.pl | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/plugins/plugins-home.pl b/plugins/plugins-home.pl
>index 6e8800e0bb3..870fcadfefc 100755
>--- a/plugins/plugins-home.pl
>+++ b/plugins/plugins-home.pl
>@@ -100,8 +100,10 @@ if ($plugins_enabled) {
>                     my $project_id   = $result->{id};
>                     my $description  = $result->{description} // '';
>                     my $web_url      = $result->{web_url};
>-                    my $releases_url = "https://gitlab.com/api/v4/projects/$project_id/releases";
>-                    my @releases     = @{ from_json( get($releases_url) ) };
>+                    my $releases_url  = "https://gitlab.com/api/v4/projects/$project_id/releases";
>+                    my $releases_info = get($releases_url);
>+                    next unless $releases_info;
>+                    my @releases = @{ from_json($releases_info) };
> 
>                     if ( scalar @releases > 0 ) {
> 
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 30367: 150523 | 150527 | 150572 | 150575 | 150576