Bug 30367 - Plugins: Search explodes in error when searching for specific keywords
Summary: Plugins: Search explodes in error when searching for specific keywords
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Plugin architecture (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-03-26 23:51 UTC by Katrin Fischer
Modified: 2022-03-27 13:15 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2022-03-26 23:51:21 UTC
This was found testing bug 29787 so I'll copy part of the test plan here:


To test:
1. Have this on your koha-conf.xml file:

 <plugin_repos>
    <repo>
        <name>ByWater Solutions</name>
        <org_name>bywatersolutions</org_name>
        <service>github</service>
    </repo>
    <repo>
        <name>Theke Solutions</name>
        <org_name>thekesolutions</org_name>
        <service>gitlab</service>
    </repo>
    <repo>
        <name>PTFS Europe</name>
        <org_name>ptfs-europe</org_name>
        <service>github</service>
    </repo>
 </plugin_repos>

2. Restart all services:
   $ restart_all
3. Search for the term 'barclaycard'

The search will give an error:

malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "(end of string)") at /usr/share/perl5/JSON.pm line 190

It might be an issue with the plugin, but we should catch errors in a nicer way for the users.
Comment 1 Katrin Fischer 2022-03-27 11:52:35 UTC
From bug 29787:

(In reply to Tomás Cohen Arazi from comment #9)
> Maybe GitHub API changed. ByWater and PTFS both are on GitHub while Theke's
> is on Gitlab.
Comment 2 Andrew Fuerste-Henry 2022-03-27 13:15:57 UTC
Thanks for filing this! We've known for a while that searching for "edifact" doesn't work, but haven't gotten around to putting a bug in. I know it used to just return no results, rather than a 500 error. I don't know when that changed.