Attachment 151491 Details for Bug 32335 – Bug 32335: Allow stock rotation items to be advanced when in transit

[patch] Bug 32335: Allow stock rotation items to be advanced when in transit

Bug-32335-Allow-stock-rotation-items-to-be-advance.patch (text/plain), 2.98 KB, created by Sam Lau on 2023-05-19 18:06:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Lau

Created: 2023-05-19 18:06:00 UTC

Size: 2.98 KB

patch

obsolete

>From 421a84552513c51a43aa694c68a61e4c8288ac2c Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 23 Nov 2022 13:24:12 +0000
>Subject: [PATCH] Bug 32335: Allow stock rotation items to be advanced when in
> transit
>
>This patch adjusts the logic so that we check:
>1 - If there are less than 2 stages we disable the 'Move to next stage' button
>2 - If the item is not in transit, we show move to next normally
>3 - If the item is in transit (and there is more than 1 stage) the button is enabled with a note about transfer
>
>To test:
>1 - Setup a rota with multiple stages
>2 - Add an item
>3 - Advance to next stage
>4 - Observe 'Move to next stage' button is disabled
>5 - Check item in at destination
>6 - Reload rota - observe 'Move to next stage' is enabled
>7 - Apply patch
>8 - Click 'Move to next stage'
>9 - Note button is not disabled
>10 - Hover and confirm note about transit
>11 - Click 'Move to next stage'
>12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>---
> .../intranet-tmpl/prog/en/modules/tools/stockrotation.tt    | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt
>index 8b74ed6630..3411ea9aff 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/stockrotation.tt
>@@ -478,10 +478,12 @@
>                                             </td>
>                                             <td class="actions">
>                                                 [% in_transit = sritem.item.get_transfer %]
>-                                                [% IF !in_transit && stages.size > 1 %]
>+                                                [% IF stages.size < 2 %]
>+                                                    <a class="btn btn-default btn-xs" title="Rota has a single stage, advancing will have no effect" disabled>
>+                                                [% ELSIF !in_transit %]
>                                                     <a class="btn btn-default btn-xs" href="?op=move_to_next_stage&amp;rota_id=[% rota.id | uri %]&amp;item_id=[% sritem.id | uri %]&amp;stage_id=[% sritem.stage.stage_id | uri %]">
>                                                 [% ELSE %]
>-                                                    <a class="btn btn-default btn-xs" disabled>
>+                                                    <a class="btn btn-default btn-xs" href="?op=move_to_next_stage&amp;rota_id=[% rota.id | uri %]&amp;item_id=[% sritem.id | uri %]&amp;stage_id=[% sritem.stage.stage_id | uri %]" title="Item is in transit, it will be directed to new stage when checked in">
>                                                 [% END %]
>                                                     <i class="fa fa-arrow-right"></i>
>                                                     Move to next stage
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 32335: 144204 | 144206 | 148747 | 148748 | 151491 | 155322 | 155323 | 155324