Bug 32335 - Allow stock rotation items to be moved several stages ahead
Summary: Allow stock rotation items to be moved several stages ahead
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Nick Clemens
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-23 13:22 UTC by Nick Clemens
Modified: 2022-11-23 13:38 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 32335: Allow stock rotation items to be advanced when in transit (2.27 KB, patch)
2022-11-23 13:28 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 32335: Allow stock rotation items to be advanced when in transit (2.34 KB, patch)
2022-11-23 13:37 UTC, Martin Renvoize
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens 2022-11-23 13:22:39 UTC
Currently when an item is added to stock rotation it can only be moved ahaead one stage, then the transfer must be filled to allow moving to the next stage.

Some libraries will want to add an item to a rotation, and move it ahead to 'catch-up' with other items.
Comment 1 Nick Clemens 2022-11-23 13:28:10 UTC
Created attachment 144204 [details] [review]
Bug 32335: Allow stock rotation items to be advanced when in transit

This patch simply removes the disabling of the 'Move to next stage' button
and adds a title to let the librarian know the item is in transit

To test:
1 - Setup a rota with multiple stages
2 - Add an item
3 - Advance to next stage
4 - Observe 'Move to next stage' button is disabled
5 - Check item in at destination
6 - Reload rota - observe 'Move to next stage' is enabled
7 - Apply patch
8 - Click 'Move to next stage'
9 - Note button is not disabled
10 - Hover and confirm note about transit
11 - Click 'Move to next stage'
12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage
Comment 2 Martin Renvoize 2022-11-23 13:37:34 UTC
Created attachment 144206 [details] [review]
Bug 32335: Allow stock rotation items to be advanced when in transit

This patch simply removes the disabling of the 'Move to next stage' button
and adds a title to let the librarian know the item is in transit

To test:
1 - Setup a rota with multiple stages
2 - Add an item
3 - Advance to next stage
4 - Observe 'Move to next stage' button is disabled
5 - Check item in at destination
6 - Reload rota - observe 'Move to next stage' is enabled
7 - Apply patch
8 - Click 'Move to next stage'
9 - Note button is not disabled
10 - Hover and confirm note about transit
11 - Click 'Move to next stage'
12 - Checkin item at wrong branch, confirm it is correctly directed to correct stage

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 3 Martin Renvoize 2022-11-23 13:38:48 UTC
Nice, discussed with Nick, and I am happy this change doesn't affect the logic in any detrimental way :)

Signing off.