Attachment 151557 Details for Bug 33792 – Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect

[patch] Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect

Bug-33792-reservesstats-Undo-homebranch-and-holdin.patch (text/plain), 1.61 KB, created by Jonathan Druart on 2023-05-23 09:31:15 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2023-05-23 09:31:15 UTC

Size: 1.61 KB

patch

obsolete

>From c7f633abb8390bc42f2c3e329e1973248e837720 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 22 May 2023 12:35:02 +0000
>Subject: [PATCH] Bug 33792: reserves_stats: Undo homebranch and holdingbranch
> preselect
>
>This preselect cuts off all next available holds that are in reserves,
>as well as holds filled by checkout without confirm (see 33791).
>
>Test plan:
>Go to reporting. Click Hold statistics.
>Verify that Holding library and Home library are not selected.
>Test that you can still filter by one of those.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/reports/reserves_stats.tt             | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt
>index b0b3298d8f8..8e0e16a1724 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/reserves_stats.tt
>@@ -338,6 +338,14 @@
> 
> [% MACRO jsinclude BLOCK %]
>     [% INCLUDE 'calendar.inc' %]
>+
>+    <script>
>+        $(document).ready(function () {
>+            // Undo the selection that Branches.all made, since there may be no item with homebranch or holdingbranch
>+            $('#holdingbranch option').prop('selected', false);
>+            $('#homebranch option').prop('selected', false);
>+        });
>+    </script>
> [% END %]
> 
> [% INCLUDE 'intranet-bottom.inc' %]
>-- 
>2.25.1

Actions: View | Diff | Splinter Review

Attachments on bug 33792: 151518 | 151531 | 151557