Bug 33792 - reserves_stats.pl ignores filled holds without itemnumber
Summary: reserves_stats.pl ignores filled holds without itemnumber
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-22 11:50 UTC by Marcel de Rooy
Modified: 2023-12-28 20:47 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.05.00,22.11.07
Circulation function:


Attachments
Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect (1.52 KB, patch)
2023-05-22 12:39 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect (1.54 KB, patch)
2023-05-22 13:57 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect (1.61 KB, patch)
2023-05-23 09:31 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2023-05-22 11:50:37 UTC
See also 33791
Comment 1 Marcel de Rooy 2023-05-22 12:13:06 UTC
Actually, it is caused by looking at homebranch/holdingbranch in the where:

items.homebranch LIKE ?  AND  items.holdingbranch LIKE ?

And since there is no item, there is no branch..
Comment 2 Marcel de Rooy 2023-05-22 12:15:40 UTC
And as mentioned on bug 23059, you can deselect that filter. But it does not work very intuitive.
Comment 3 Marcel de Rooy 2023-05-22 12:39:35 UTC
Created attachment 151518 [details] [review]
Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect

This preselect cuts off all next available holds that are in reserves,
as well as holds filled by checkout without confirm (see 33791).

Test plan:
Go to reporting. Click Hold statistics.
Verify that Holding library and Home library are not selected.
Test that you can still filter by one of those.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Kyle M Hall (khall) 2023-05-22 13:57:04 UTC
Created attachment 151531 [details] [review]
Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect

This preselect cuts off all next available holds that are in reserves,
as well as holds filled by checkout without confirm (see 33791).

Test plan:
Go to reporting. Click Hold statistics.
Verify that Holding library and Home library are not selected.
Test that you can still filter by one of those.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Jonathan Druart 2023-05-23 09:31:15 UTC
Created attachment 151557 [details] [review]
Bug 33792: reserves_stats: Undo homebranch and holdingbranch preselect

This preselect cuts off all next available holds that are in reserves,
as well as holds filled by checkout without confirm (see 33791).

Test plan:
Go to reporting. Click Hold statistics.
Verify that Holding library and Home library are not selected.
Test that you can still filter by one of those.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Tomás Cohen Arazi (tcohen) 2023-05-23 19:53:48 UTC
Pushed to master for 23.05.

Nice work everyone, thanks!
Comment 7 Matt Blenkinsop 2023-06-08 17:15:57 UTC
Nice work everyone!

Pushed to stable for 22.11.x