Attachment 151693 Details for Bug 33819 – Bug 33819: Add page numbers to opac results breadcrumb

[patch] Bug 33819: Add page numbers to opac results breadcrumb

Bug-33819-Add-page-numbers-to-opac-results-breadcr.patch (text/plain), 2.84 KB, created by Owen Leonard on 2023-05-25 14:55:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2023-05-25 14:55:47 UTC

Size: 2.84 KB

patch

obsolete

>From 265891bb7242a11254aac32e5b1bf35928193ef6 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Wed, 24 May 2023 14:57:20 +0000
>Subject: [PATCH] Bug 33819: Add page numbers to opac results breadcrumb
>
>This patch adds the page number to the breadcrumb in the opac search
>results to ensure that it is unique to the content on the page.
>Currently it is not compliant to Accessibility guidelines as the
>breadcrumb is identical on every page despite the content being
>different.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 2 +-
> opac/opac-search.pl                                      | 4 +++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>index 77816dd377..de8820351c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
>@@ -48,7 +48,7 @@
>                     [% END %]
>                     <li class="breadcrumb-item active">
>                         [% IF ( ms_value ) %]
>-                            <a href="#" aria-current="page" title="You searched [% IF ( query_desc ) %] for '[% query_desc | html %]'[% END %][% IF ( limit_desc ) %] with limit(s): '[% limit_desc | html %]'[% END %]">Results of search for '[% ms_value | html %]'</a>
>+                            <a href="#" aria-current="page" title="You searched [% IF ( query_desc ) %] for '[% query_desc | html %]'[% END %][% IF ( limit_desc ) %] with limit(s): '[% limit_desc | html %]'[% END %]">Results of search for '[% ms_value | html %]', page [% current_page_number | html%] of [% pages | html%]</a>
>                         [% ELSE %]
>                             <a href="#" aria-current="page" title="You searched [% IF ( query_desc ) %] for '[% query_desc | html %]'[% END %][% IF ( limit_desc ) %] with limit(s): '[% limit_desc | html %]'[% END %]">Search results</a>
>                         [% END %]
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index 958f4ca623..5b38f40259 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -805,7 +805,9 @@ for (my $i=0;$i<@servers;$i++) {
>                         sort_by           => \@sort_by
>                     }
>                 );
>-            $template->param( hits_to_paginate => $hits_to_paginate );
>+            $template->param(   hits_to_paginate => $hits_to_paginate,
>+                                current_page_number => $current_page_number,
>+                                pages => $pages );
>             $template->param(   PAGE_NUMBERS => $page_numbers,
>                                 last_page_offset => $last_page_offset,
>                                 previous_page_offset => $previous_page_offset) unless $pages < 2;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33819: 151637 | 151693 | 154500 | 156682