Bug 33819 - Accessibility: More description required in OPAC search breadcrumbs
Summary: Accessibility: More description required in OPAC search breadcrumbs
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Matt Blenkinsop
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 25243
  Show dependency treegraph
 
Reported: 2023-05-24 14:56 UTC by Matt Blenkinsop
Modified: 2023-10-17 17:35 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.05,22.11.11


Attachments
Bug 33819: Add page numbers to opac results breadcrumb (2.81 KB, patch)
2023-05-24 14:58 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33819: Add page numbers to opac results breadcrumb (2.84 KB, patch)
2023-05-25 14:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 33819: Add page numbers to opac results breadcrumb (3.41 KB, patch)
2023-08-17 08:39 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33819: Add page numbers to opac results breadcrumb (3.51 KB, patch)
2023-10-07 15:24 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2023-05-24 14:56:59 UTC
A report carried out for the British museum by the Shaw trust has identified that the "Search results for" breadcrumb on the opac search results page is not descriptive enough and should include the page number to assist screen readers with understanding the page content. Currently the breadcumb is the same on every page and it needs to be more unique to the page content.
Comment 1 Matt Blenkinsop 2023-05-24 14:58:55 UTC
Created attachment 151637 [details] [review]
Bug 33819: Add page numbers to opac results breadcrumb

This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different.
Comment 2 Owen Leonard 2023-05-25 14:55:47 UTC
Created attachment 151693 [details] [review]
Bug 33819: Add page numbers to opac results breadcrumb

This patch adds the page number to the breadcrumb in the opac search
results to ensure that it is unique to the content on the page.
Currently it is not compliant to Accessibility guidelines as the
breadcrumb is identical on every page despite the content being
different.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Jonathan Druart 2023-07-07 07:03:35 UTC
When there is no result:  "Results of search for 'ezaze', page of "
Comment 4 Jonathan Druart 2023-07-07 07:04:13 UTC
There are also missing space before the end of the TT tags
[% current_page_number | html%] of [% pages | html%]
Comment 5 Matt Blenkinsop 2023-08-17 08:39:39 UTC
Created attachment 154500 [details] [review]
Bug 33819: Add page numbers to opac results breadcrumb

This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different.

To test:
1) Apply patch
2) Run a search in the OPAC that will return more than 20 results.
3) The breadcrumb should say "Results of search for 'search term', page x of y"
4) Run a search that will return less than 20 results
5) The breadcrumb should say "Results of search for 'search term'
Comment 6 Katrin Fischer 2023-10-07 15:23:27 UTC
I am not entirely sure about the presentation. With a complicated search query it could get rather long and lost in the end. Maybe it could be a new 'part'/section of the breadcrumb? 

Home >
 Results of search for 'p', page 6 of 21

Could then be:

Home >
 Results of search for 'p' >
  Page 6 of 21

I guess thinking hierarchies it would not be quite right...

Also: we lost Owen's sign-off line in the rebase. I'll re-add it in QA.
Comment 7 Katrin Fischer 2023-10-07 15:24:12 UTC
Created attachment 156682 [details] [review]
Bug 33819: Add page numbers to opac results breadcrumb

This patch adds the page number to the breadcrumb in the opac search results to ensure that it is unique to the content on the page. Currently it is not compliant to Accessibility guidelines as the breadcrumb is identical on every page despite the content being different.

To test:
1) Apply patch
2) Run a search in the OPAC that will return more than 20 results.
3) The breadcrumb should say "Results of search for 'search term', page x of y"
4) Run a search that will return less than 20 results
5) The breadcrumb should say "Results of search for 'search term'

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 8 Tomás Cohen Arazi 2023-10-09 14:42:31 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 9 Fridolin Somers 2023-10-09 18:52:45 UTC
Nice small enhancement, I choose to backport.

Pushed to 23.05.x for 23.05.05
Comment 10 Matt Blenkinsop 2023-10-17 17:35:55 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x