Bugzilla – Attachment 153118 Details for
Bug 33105
Add vendor issues
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33105: (QA follow-up) Changes for Koha objects
Bug-33105-QA-follow-up-Changes-for-Koha-objects.patch (text/plain), 2.18 KB, created by
Marcel de Rooy
on 2023-07-07 07:02:58 UTC
(
hide
)
Description:
Bug 33105: (QA follow-up) Changes for Koha objects
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2023-07-07 07:02:58 UTC
Size:
2.18 KB
patch
obsolete
>From b641710021ae914b1eec0349ca9a6c60daf2e7ea Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 7 Jul 2023 06:57:37 +0000 >Subject: [PATCH] Bug 33105: (QA follow-up) Changes for Koha objects >Content-Type: text/plain; charset=utf-8 > >--- > Koha/Acquisition/Bookseller/Issue.pm | 10 +++++----- > Koha/Acquisition/Bookseller/Issues.pm | 3 +-- > 2 files changed, 6 insertions(+), 7 deletions(-) > >diff --git a/Koha/Acquisition/Bookseller/Issue.pm b/Koha/Acquisition/Bookseller/Issue.pm >index 40e19aad6e..f4d1ecd069 100644 >--- a/Koha/Acquisition/Bookseller/Issue.pm >+++ b/Koha/Acquisition/Bookseller/Issue.pm >@@ -17,14 +17,15 @@ package Koha::Acquisition::Bookseller::Issue; > > use Modern::Perl; > >- > use Koha::Database; > > use base qw(Koha::Object); > >+use constant ISSUE_TYPE_CATEGORY => 'VENDOR_ISSUE_TYPE'; >+ > =head1 NAME > >-Koha::Acquisition::Bookseller::Issue - Koha Issue Object class >+Koha::Acquisition::Bookseller::Issue - Koha vendor issue object class > > =head1 API > >@@ -40,10 +41,9 @@ sub strings_map { > my $strings = {}; > > if ( defined $self->type ) { >- my $type_av_category = 'VENDOR_ISSUE_TYPE'; > my $av = Koha::AuthorisedValues->search( > { >- category => $type_av_category, >+ category => ISSUE_TYPE_CATEGORY, > authorised_value => $self->type, > } > ); >@@ -55,7 +55,7 @@ sub strings_map { > : $self->type; > > $strings->{type} = { >- category => 'VENDOR_ISSUE_TYPE', >+ category => ISSUE_TYPE_CATEGORY, > str => $type_str, > type => 'av', > }; >diff --git a/Koha/Acquisition/Bookseller/Issues.pm b/Koha/Acquisition/Bookseller/Issues.pm >index e797aba163..172ec82a8d 100644 >--- a/Koha/Acquisition/Bookseller/Issues.pm >+++ b/Koha/Acquisition/Bookseller/Issues.pm >@@ -17,7 +17,6 @@ package Koha::Acquisition::Bookseller::Issues; > > use Modern::Perl; > >- > use Koha::Database; > > use Koha::Acquisition::Bookseller::Issue; >@@ -26,7 +25,7 @@ use base qw(Koha::Objects); > > =head1 NAME > >-Koha::Acquisition::Bookseller::Issues >+Koha::Acquisition::Bookseller::Issues - Koha vendor issues object class > > =head1 API > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33105
:
149509
|
149510
|
149511
|
149512
|
149513
|
149514
|
149515
|
149530
|
149531
|
149532
|
149556
|
149557
|
149558
|
149559
|
149560
|
149561
|
149562
|
152894
|
152895
|
152896
|
152897
|
152898
|
152899
|
152900
|
153117
|
153118
|
153119
|
153122
|
153123
|
153125
|
153126
|
153127
|
153128
|
153129
|
153130
|
153131
|
153132
|
153133
|
153134
|
153135
|
153136
|
153137
|
153730
|
153731