Bug 33105 - Add vendor issues
Summary: Add vendor issues
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 33104
Blocks:
  Show dependency treegraph
 
Reported: 2023-03-01 10:01 UTC by Jonathan Druart
Modified: 2023-04-23 12:57 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 33105: DB changes (6.34 KB, patch)
2023-04-12 09:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: DBIC schema changes (3.95 KB, patch)
2023-04-12 09:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: DBIC specific (1003 bytes, patch)
2023-04-12 09:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: Add Koha object classes (4.58 KB, patch)
2023-04-12 09:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: Add vendor issues (19.59 KB, patch)
2023-04-12 09:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: REST API specs (5.55 KB, patch)
2023-04-12 09:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: Add tests (6.58 KB, patch)
2023-04-12 09:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: Add vendor issues (19.59 KB, patch)
2023-04-12 11:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: REST API specs (5.55 KB, patch)
2023-04-12 11:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: Add tests (6.58 KB, patch)
2023-04-12 11:56 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 33105: DB changes (6.39 KB, patch)
2023-04-12 15:12 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33105: DBIC schema changes (4.00 KB, patch)
2023-04-12 15:12 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33105: DBIC specific (1.04 KB, patch)
2023-04-12 15:12 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33105: Add Koha object classes (4.63 KB, patch)
2023-04-12 15:12 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33105: Add vendor issues (19.64 KB, patch)
2023-04-12 15:12 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33105: REST API specs (5.61 KB, patch)
2023-04-12 15:12 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 33105: Add tests (6.64 KB, patch)
2023-04-12 15:12 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-03-01 10:01:02 UTC
The benefit of recording vendor issues is that you can identify problems you have had with the service and use this as a negotiating tool with vendors at contract renegotiation.
Comment 1 Jonathan Druart 2023-04-12 09:20:46 UTC
Created attachment 149509 [details] [review]
Bug 33105: DB changes
Comment 2 Jonathan Druart 2023-04-12 09:20:50 UTC
Created attachment 149510 [details] [review]
Bug 33105: DBIC schema changes
Comment 3 Jonathan Druart 2023-04-12 09:20:52 UTC
Created attachment 149511 [details] [review]
Bug 33105: DBIC specific
Comment 4 Jonathan Druart 2023-04-12 09:20:55 UTC
Created attachment 149512 [details] [review]
Bug 33105: Add Koha object classes
Comment 5 Jonathan Druart 2023-04-12 09:20:58 UTC
Created attachment 149513 [details] [review]
Bug 33105: Add vendor issues

This patch is the main patch of this patch set, it contains the
controller acqui/vendor_issues.pl, its corresponding template, and some
links to this script.

It adds:
* A new DB table aqbookseller_issues linked with the aqbooksellers table
* A new subpermission acquisition.issue_manage
* A new authorised value category VENDOR_ISSUE_TYPE and two examples
MAINTENANCE and OUTAGE
* A new controller couple acqui/vendor_issues.[pl,tt]

Test plan:
0. Apply the patches, run updatedatabase and restart_all
1. Go to the acquisition module, create a new vendor or use an existing
one
2. Create a couple of issues for this vendor
3. Edit/Delete and search for those issues

This is the basics for tracking issues with vendors.
Suggestions welcome, on follow-up bug reports.
Comment 6 Jonathan Druart 2023-04-12 09:21:01 UTC
Created attachment 149514 [details] [review]
Bug 33105: REST API specs
Comment 7 Jonathan Druart 2023-04-12 09:21:03 UTC
Created attachment 149515 [details] [review]
Bug 33105: Add tests
Comment 8 Jonathan Field 2023-04-12 11:27:56 UTC
Deletion is currently failing due to a typo in vendor_issues.pl

cgi-bin/koha/acqui/vendor_iddues.pl?op=delete_confirm&issue_id=1

iddues instead of issues. Looking good otherwise!
Comment 9 Jonathan Druart 2023-04-12 11:56:48 UTC
Created attachment 149530 [details] [review]
Bug 33105: Add vendor issues

This patch is the main patch of this patch set, it contains the
controller acqui/vendor_issues.pl, its corresponding template, and some
links to this script.

It adds:
* A new DB table aqbookseller_issues linked with the aqbooksellers table
* A new subpermission acquisition.issue_manage
* A new authorised value category VENDOR_ISSUE_TYPE and two examples
MAINTENANCE and OUTAGE
* A new controller couple acqui/vendor_issues.[pl,tt]

Test plan:
0. Apply the patches, run updatedatabase and restart_all
1. Go to the acquisition module, create a new vendor or use an existing
one
2. Create a couple of issues for this vendor
3. Edit/Delete and search for those issues

This is the basics for tracking issues with vendors.
Suggestions welcome, on follow-up bug reports.
Comment 10 Jonathan Druart 2023-04-12 11:56:51 UTC
Created attachment 149531 [details] [review]
Bug 33105: REST API specs
Comment 11 Jonathan Druart 2023-04-12 11:56:54 UTC
Created attachment 149532 [details] [review]
Bug 33105: Add tests
Comment 12 Jonathan Druart 2023-04-12 11:58:30 UTC
(In reply to Jonathan Field from comment #8)
> Deletion is currently failing due to a typo in vendor_issues.pl

oops, should be fixed now!
Comment 13 PTFS Europe Sandboxes 2023-04-12 15:12:02 UTC
Created attachment 149556 [details] [review]
Bug 33105: DB changes

Signed-off-by: Jonathan Field <jonathan.fieeld@ptfs-europe.com>
Comment 14 PTFS Europe Sandboxes 2023-04-12 15:12:05 UTC
Created attachment 149557 [details] [review]
Bug 33105: DBIC schema changes

Signed-off-by: Jonathan Field <jonathan.fieeld@ptfs-europe.com>
Comment 15 PTFS Europe Sandboxes 2023-04-12 15:12:07 UTC
Created attachment 149558 [details] [review]
Bug 33105: DBIC specific

Signed-off-by: Jonathan Field <jonathan.fieeld@ptfs-europe.com>
Comment 16 PTFS Europe Sandboxes 2023-04-12 15:12:09 UTC
Created attachment 149559 [details] [review]
Bug 33105: Add Koha object classes

Signed-off-by: Jonathan Field <jonathan.fieeld@ptfs-europe.com>
Comment 17 PTFS Europe Sandboxes 2023-04-12 15:12:12 UTC
Created attachment 149560 [details] [review]
Bug 33105: Add vendor issues

This patch is the main patch of this patch set, it contains the
controller acqui/vendor_issues.pl, its corresponding template, and some
links to this script.

It adds:
* A new DB table aqbookseller_issues linked with the aqbooksellers table
* A new subpermission acquisition.issue_manage
* A new authorised value category VENDOR_ISSUE_TYPE and two examples
MAINTENANCE and OUTAGE
* A new controller couple acqui/vendor_issues.[pl,tt]

Test plan:
0. Apply the patches, run updatedatabase and restart_all
1. Go to the acquisition module, create a new vendor or use an existing
one
2. Create a couple of issues for this vendor
3. Edit/Delete and search for those issues

This is the basics for tracking issues with vendors.
Suggestions welcome, on follow-up bug reports.

Signed-off-by: Jonathan Field <jonathan.fieeld@ptfs-europe.com>
Comment 18 PTFS Europe Sandboxes 2023-04-12 15:12:14 UTC
Created attachment 149561 [details] [review]
Bug 33105: REST API specs

Signed-off-by: Jonathan Field <jonathan.fieeld@ptfs-europe.com>
Comment 19 PTFS Europe Sandboxes 2023-04-12 15:12:16 UTC
Created attachment 149562 [details] [review]
Bug 33105: Add tests

Signed-off-by: Jonathan Field <jonathan.fieeld@ptfs-europe.com>