Bugzilla – Attachment 153153 Details for
Bug 34214
Toolbar component should make the icon configurable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34214: Make 'icon' configurable for Toolbar options
Bug-34214-Make-icon-configurable-for-Toolbar-optio.patch (text/plain), 4.30 KB, created by
Pedro Amorim
on 2023-07-07 11:14:51 UTC
(
hide
)
Description:
Bug 34214: Make 'icon' configurable for Toolbar options
Filename:
MIME Type:
Creator:
Pedro Amorim
Created:
2023-07-07 11:14:51 UTC
Size:
4.30 KB
patch
obsolete
>From 971f2388675380c5f0ad3a1c07428816c5521b27 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 6 Jul 2023 09:19:11 +0200 >Subject: [PATCH] Bug 34214: Make 'icon' configurable for Toolbar options > >Bug 33417 added a generic 'Toolbar' Vue component but always add a 'plus' icon. We should make it configurable. > >Test plan: >Regenerate the Vue app: `yarn js:build` >Go to the ERM module and confirm that the toolbar has the '+' icon. > >Sponsored-by: BULAC - http://www.bulac.fr/ >Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com> >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >--- > .../intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue | 1 + > .../prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue | 1 + > .../prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue | 2 ++ > .../intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue | 1 + > koha-tmpl/intranet-tmpl/prog/js/vue/components/Toolbar.vue | 2 +- > 5 files changed, 6 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >index 7b523be0fe..7025ad5b4f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsList.vue >@@ -153,6 +153,7 @@ export default { > toolbar_options: [ > { > to: "AgreementsFormAdd", >+ icon: "plus", > button_title: this.$__("New agreement"), > }, > ], >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >index 1999556b0b..08105b1137 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalPackagesList.vue >@@ -101,6 +101,7 @@ export default { > toolbar_options: [ > { > to: "EHoldingsLocalPackagesFormAdd", >+ icon: "plus", > button_title: this.$__("New package"), > }, > ], >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue >index 026ea0434e..c692c217ca 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/EHoldingsLocalTitlesList.vue >@@ -93,10 +93,12 @@ export default { > toolbar_options: [ > { > to: "EHoldingsLocalTitlesFormAdd", >+ icon: "plus", > button_title: this.$__("New title"), > }, > { > to: "EHoldingsLocalTitlesFormImport", >+ icon: "plus", > button_title: this.$__("Import from list"), > }, > ], >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >index dfdb767612..af7068e8b1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/LicensesList.vue >@@ -53,6 +53,7 @@ export default { > toolbar_options: [ > { > to: "LicensesFormAdd", >+ icon: "plus", > button_title: this.$__("New license"), > }, > ], >diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Toolbar.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Toolbar.vue >index ea6a79e904..47f740607c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Toolbar.vue >+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Toolbar.vue >@@ -5,7 +5,7 @@ > :key="index" > :to="{ name: option.to }" > class="btn btn-default" >- ><font-awesome-icon icon="plus" /> >+ ><font-awesome-icon :icon="option.icon" /> > {{ option.button_title }}</router-link > > > </div> >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34214
:
153083
|
153149
| 153153