Bug 34214 - Toolbar component should make the icon configurable
Summary: Toolbar component should make the icon configurable
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: ERM (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on: 33417
Blocks: 34215
  Show dependency treegraph
 
Reported: 2023-07-06 07:17 UTC by Jonathan Druart
Modified: 2023-12-28 20:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34214: Make 'icon' configurable for Toolbar options (4.18 KB, patch)
2023-07-06 07:21 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 34214: Make 'icon' configurable for Toolbar options (4.24 KB, patch)
2023-07-07 10:40 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 34214: Make 'icon' configurable for Toolbar options (4.30 KB, patch)
2023-07-07 11:14 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2023-07-06 07:17:52 UTC
Bug 33417 added a generic 'Toolbar' Vue component but always add a 'plus' icon. We should make it configurable.
Comment 1 Jonathan Druart 2023-07-06 07:21:10 UTC
Created attachment 153083 [details] [review]
Bug 34214: Make 'icon' configurable for Toolbar options

Bug 33417 added a generic 'Toolbar' Vue component but always add a 'plus' icon. We should make it configurable.

Test plan:
Regenerate the Vue app: `yarn js:build`
Go to the ERM module and confirm that the toolbar has the '+' icon.

Sponsored-by: BULAC - http://www.bulac.fr/
Comment 2 PTFS Europe Sandboxes 2023-07-07 10:40:14 UTC
Created attachment 153149 [details] [review]
Bug 34214: Make 'icon' configurable for Toolbar options

Bug 33417 added a generic 'Toolbar' Vue component but always add a 'plus' icon. We should make it configurable.

Test plan:
Regenerate the Vue app: `yarn js:build`
Go to the ERM module and confirm that the toolbar has the '+' icon.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com>
Comment 3 Pedro Amorim 2023-07-07 11:14:51 UTC
Created attachment 153153 [details] [review]
Bug 34214: Make 'icon' configurable for Toolbar options

Bug 33417 added a generic 'Toolbar' Vue component but always add a 'plus' icon. We should make it configurable.

Test plan:
Regenerate the Vue app: `yarn js:build`
Go to the ERM module and confirm that the toolbar has the '+' icon.

Sponsored-by: BULAC - http://www.bulac.fr/
Signed-off-by: Alexander Blanchard <alexander.blanchard@ptfs-europe.com>
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Comment 4 Tomás Cohen Arazi 2023-07-07 15:12:17 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Martin Renvoize 2023-07-18 09:24:50 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 6 Matt Blenkinsop 2023-07-18 13:46:44 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x