Bugzilla – Attachment 153205 Details for
Bug 34233
Pickup location pulldowns when placing holds in staff are blank
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34233: Move select2 include out of patron-search.inc
Bug-34233-Move-select2-include-out-of-patron-searc.patch (text/plain), 3.07 KB, created by
Lucas Gass (lukeg)
on 2023-07-07 22:01:55 UTC
(
hide
)
Description:
Bug 34233: Move select2 include out of patron-search.inc
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2023-07-07 22:01:55 UTC
Size:
3.07 KB
patch
obsolete
>From a8f3117c24ae32d75b700d71b5ecc25d26cc7ced Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 7 Jul 2023 21:58:55 +0000 >Subject: [PATCH] Bug 34233: Move select2 include out of patron-search.inc > >1. Apply patch >2. Place a hold and make sure the patron pickup locations are populating correctly again/ >3. Work through the test plan on Bug 28726 to make sure it still works. >4. Enable ArticleRequests, make sure you can still do a patron search there. >5. Do a patron search from members.tt, make sure that still works. >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc | 1 - > koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt | 1 + > 4 files changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >index bd203c62f4..20b1e30319 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc >@@ -211,7 +211,6 @@ > <script>console.log("Wrong call of patron_search_js - missing redirect_url");</script> > [% END %] > >- [% INCLUDE 'select2.inc' %] > <script> > let categories = [% To.json(categories) | $raw %].map(e => { > e['_id'] = e.categorycode.toLowerCase(); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >index 0aced44773..7b27c73a35 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt >@@ -353,6 +353,7 @@ > > [% MACRO jsinclude BLOCK %] > [% INCLUDE 'datatables.inc' %] >+ [% INCLUDE 'select2.inc' %] > > <script> > $('#current-article-requests').ready(function() { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index 7b747e8171..6d664186cb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -151,6 +151,7 @@ > [% INCLUDE 'columns_settings.inc' %] > [% INCLUDE 'str/members-menu.inc' %] > [% Asset.js("js/members-menu.js") | $raw %] >+ [% INCLUDE 'select2.inc' %] > <script> > function showPatronSelections( number ){ > $("#patron_search_selected").show().find("span").text(_("Patrons selected: " + number ) ); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt >index 6146eebe5c..67f056ddb8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt >@@ -42,6 +42,7 @@ > </div> > > [% MACRO jsinclude BLOCK %] >+[% INCLUDE 'select2.inc' %] > <script> > $(document).ready(function() { > $("#select_all").on("click",function(e){ >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34233
:
153205
|
153267
|
153296