There seems to be an issue with populating the pickup location pulldowns in request.pl in master. If you go to a bib record and try to place a hold, the pickup location pulldowns for both record-level and item-level holds are blank. The pulldown to change pickup location for existing holds is blank as well. Attempting to place a hold will succeed in placing a hold at the default pickup location despite the blank pulldown. The pulldown to change pickup location on moremember.pl works normally. I've replicated this on KTD and a sandbox with default settings, but no idea what's causing it.
This is being caused by Bug 28726. I think it is because we are now using [% INCLUDE 'select2.inc' %] in request.tt and inside the include 'patron-search.inc'.
Created attachment 153205 [details] [review] Bug 34233: Move select2 include out of patron-search.inc 1. Apply patch 2. Place a hold and make sure the patron pickup locations are populating correctly again/ 3. Work through the test plan on Bug 28726 to make sure it still works. 4. Enable ArticleRequests, make sure you can still do a patron search there. 5. Do a patron search from members.tt, make sure that still works.
Created attachment 153267 [details] [review] Bug 34233: Move select2 include out of patron-search.inc 1. Apply patch 2. Place a hold and make sure the patron pickup locations are populating correctly again/ 3. Work through the test plan on Bug 28726 to make sure it still works. 4. Enable ArticleRequests, make sure you can still do a patron search there. 5. Do a patron search from members.tt, make sure that still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 153296 [details] [review] Bug 34233: Move select2 include out of patron-search.inc 1. Apply patch 2. Place a hold and make sure the patron pickup locations are populating correctly again/ 3. Work through the test plan on Bug 28726 to make sure it still works. 4. Enable ArticleRequests, make sure you can still do a patron search there. 5. Do a patron search from members.tt, make sure that still works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/request-article.tt:[% PROCESS "patron-search.inc" %] koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt:[% PROCESS 'patron-search.inc' %] koha-tmpl/intranet-tmpl/prog/en/modules/members/search.tt:[% PROCESS 'patron-search.inc' %] koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt:[% PROCESS "patron-search.inc" %] Missing from request.tt
Forget that, it's there already!
Pushed to master for 23.11. Nice work everyone, thanks!
Thanks for all the hard work! Pushed to 23.05.x for the next release
Nice work everyone! Pushed to oldstable for 22.11.x