Bug 34233 - Pickup location pulldowns when placing holds in staff are blank
Summary: Pickup location pulldowns when placing holds in staff are blank
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Lucas Gass
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 28726
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-07 20:03 UTC by Emily Lamancusa
Modified: 2023-12-28 20:47 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.02,22.11.08


Attachments
Bug 34233: Move select2 include out of patron-search.inc (3.07 KB, patch)
2023-07-07 22:01 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 34233: Move select2 include out of patron-search.inc (3.12 KB, patch)
2023-07-10 12:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34233: Move select2 include out of patron-search.inc (3.18 KB, patch)
2023-07-10 20:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa 2023-07-07 20:03:56 UTC
There seems to be an issue with populating the pickup location pulldowns in request.pl in master. If you go to a bib record and try to place a hold, the pickup location pulldowns for both record-level and item-level holds are blank. The pulldown to change pickup location for existing holds is blank as well.

Attempting to place a hold will succeed in placing a hold at the default pickup location despite the blank pulldown.

The pulldown to change pickup location on moremember.pl works normally.

I've replicated this on KTD and a sandbox with default settings, but no idea what's causing it.
Comment 1 Lucas Gass 2023-07-07 21:37:57 UTC
This is being caused by Bug 28726. I think it is because we are now using [% INCLUDE 'select2.inc' %] in request.tt and inside the include 'patron-search.inc'.
Comment 2 Lucas Gass 2023-07-07 22:01:55 UTC
Created attachment 153205 [details] [review]
Bug 34233: Move select2 include out of patron-search.inc

1. Apply patch
2. Place a hold and make sure the patron pickup locations are populating correctly again/
3. Work through the test plan on Bug 28726 to make sure it still works.
4. Enable ArticleRequests, make sure you can still do a patron search there.
5. Do a patron search from members.tt, make sure that still works.
Comment 3 Owen Leonard 2023-07-10 12:58:19 UTC
Created attachment 153267 [details] [review]
Bug 34233: Move select2 include out of patron-search.inc

1. Apply patch
2. Place a hold and make sure the patron pickup locations are
   populating correctly again/
3. Work through the test plan on Bug 28726 to make sure it still works.
4. Enable ArticleRequests, make sure you can still do a patron search
   there.
5. Do a patron search from members.tt, make sure that still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Katrin Fischer 2023-07-10 20:52:29 UTC
Created attachment 153296 [details] [review]
Bug 34233: Move select2 include out of patron-search.inc

1. Apply patch
2. Place a hold and make sure the patron pickup locations are
   populating correctly again/
3. Work through the test plan on Bug 28726 to make sure it still works.
4. Enable ArticleRequests, make sure you can still do a patron search
   there.
5. Do a patron search from members.tt, make sure that still works.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 5 Jonathan Druart 2023-07-11 06:52:11 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2023-07-11 06:53:50 UTC Comment hidden (obsolete)
Comment 7 Tomás Cohen Arazi 2023-07-11 11:52:17 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 8 Martin Renvoize 2023-07-18 10:08:43 UTC
Thanks for all the hard work!

Pushed to 23.05.x for the next release
Comment 9 Matt Blenkinsop 2023-07-18 14:07:27 UTC
Nice work everyone!

Pushed to oldstable for 22.11.x