Attachment 153734 Details for Bug 34320 – Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade

[patch] Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade

Bug-34320-Hold-reordering-arrows-look-broken-after.patch (text/plain), 1.75 KB, created by Sam Lau on 2023-07-20 15:57:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Sam Lau

Created: 2023-07-20 15:57:35 UTC

Size: 1.75 KB

patch

obsolete

>From 59a1ff743e5cd51eaa7455041d65fc168a01ab24 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 20 Jul 2023 10:55:14 +0000
>Subject: [PATCH] Bug 34320: Hold reordering arrows look broken after Font
> Awesome upgrade
>
>This patch makes minor CSS corrections to the arrows on the place hold
>page in the staff interface. The corrections are necessary because of
>changes in the display of icons in Font Awesome 6.
>
>To test, apply the patch and locate a bibliographic record in the staff
>interface to place a hold on.
>
>- Place at least one hold on that title.
>- After placing the hold, you should see a table of all the existing
>  holds on that record.
>- The arrow control links should look correct, with the "move to top"
>  and "move to bottom" arrows having an extra border to differentiate
>  them from the others.
>
>Signed-off-by: Sam Lau <samalau@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>index a3f9c2328a..682b44e967 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt
>@@ -61,7 +61,8 @@
>         }
> 
>         .icon-move-hold-top {
>-            border-top: 3px solid #538200;
>+            border-top: 2px solid #538200;
>+            display: inline;
>         }
> 
>         .icon-move-hold-top::before {
>@@ -69,7 +70,8 @@
>         }
> 
>         .icon-move-hold-bottom {
>-            border-bottom: 3px solid #538200;
>+            border-bottom: 2px solid #538200;
>+            display: inline;
>         }
> 
>         .icon-move-hold-bottom::before {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34320: 153715 | 153734