Bug 34320 - Hold reordering arrows look broken after Font Awesome upgrade
Summary: Hold reordering arrows look broken after Font Awesome upgrade
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Owen Leonard
QA Contact: Emily Lamancusa
URL:
Keywords:
Depends on: 32910
Blocks:
  Show dependency treegraph
 
Reported: 2023-07-20 10:53 UTC by Owen Leonard
Modified: 2023-08-04 02:03 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00


Attachments
Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade (1.71 KB, patch)
2023-07-20 11:04 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade (1.75 KB, patch)
2023-07-20 15:57 UTC, Sam Lau
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2023-07-20 10:53:48 UTC
On the place hold screen where the interface shows existing holds, there are custom-style arrows for "Move hold to top" and "Move hold to bottom." The border on these looks wrong after the Font Awesome upgrade.
Comment 1 Owen Leonard 2023-07-20 11:04:03 UTC
Created attachment 153715 [details] [review]
Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade

This patch makes minor CSS corrections to the arrows on the place hold
page in the staff interface. The corrections are necessary because of
changes in the display of icons in Font Awesome 6.

To test, apply the patch and locate a bibliographic record in the staff
interface to place a hold on.

- Place at least one hold on that title.
- After placing the hold, you should see a table of all the existing
  holds on that record.
- The arrow control links should look correct, with the "move to top"
  and "move to bottom" arrows having an extra border to differentiate
  them from the others.
Comment 2 Sam Lau 2023-07-20 15:57:35 UTC
Created attachment 153734 [details] [review]
Bug 34320: Hold reordering arrows look broken after Font Awesome upgrade

This patch makes minor CSS corrections to the arrows on the place hold
page in the staff interface. The corrections are necessary because of
changes in the display of icons in Font Awesome 6.

To test, apply the patch and locate a bibliographic record in the staff
interface to place a hold on.

- Place at least one hold on that title.
- After placing the hold, you should see a table of all the existing
  holds on that record.
- The arrow control links should look correct, with the "move to top"
  and "move to bottom" arrows having an extra border to differentiate
  them from the others.

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 3 Emily Lamancusa 2023-07-21 19:36:43 UTC
Trivial patch, looks good and QA tool is happy. Passing QA
Comment 4 Tomás Cohen Arazi 2023-07-21 20:15:31 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 5 Fridolin Somers 2023-08-03 21:32:53 UTC
Enhancement not pushed to 23.05.x
Comment 6 Fridolin Somers 2023-08-04 02:03:03 UTC
(In reply to Fridolin Somers from comment #5)
> Enhancement not pushed to 23.05.x

I mean :
Depends on Bug 32910 not in 23.05.x