Attachment 154083 Details for Bug 33755 – Bug 33755: Set profile_id and add missing import

[patch] Bug 33755: Set profile_id and add missing import

Bug-33755-Set-profileid-and-add-missing-import.patch (text/plain), 1.98 KB, created by Matt Blenkinsop on 2023-07-31 08:57:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Matt Blenkinsop

Created: 2023-07-31 08:57:16 UTC

Size: 1.98 KB

patch

obsolete

>From 68b7d4f4f7246ed7f572fcadc2ec0501a9b87ed4 Mon Sep 17 00:00:00 2001
>From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>Date: Mon, 31 Jul 2023 08:52:23 +0000
>Subject: [PATCH] Bug 33755: Set profile_id and add missing import
>
>This patch adds a missed parameter (profile_id) in stage-marc-import.pl and also adds a missing import in the background job for staging marc files. This means that the profile used when importing can now be shown in the import batches table and also in batch details
>
>Test plan:
>1) Stage a record for import and make sure to save the import profile you use
>2) Import a record using that profile
>3) Navigate to Cataloging > Manage staged MARC records
>4) In the Profile column, no value will be shown for the staged record
>5) Click on the batch, the profile will be missing in this screen as well
>6) Apply patch
>7) Restart_all
>8) Repeat steps 2-5, the profile name should be visible in both places
>---
> Koha/BackgroundJob/StageMARCForImport.pm | 1 +
> tools/stage-marc-import.pl               | 1 +
> 2 files changed, 2 insertions(+)
>
>diff --git a/Koha/BackgroundJob/StageMARCForImport.pm b/Koha/BackgroundJob/StageMARCForImport.pm
>index 7858eae7a0..1272378279 100644
>--- a/Koha/BackgroundJob/StageMARCForImport.pm
>+++ b/Koha/BackgroundJob/StageMARCForImport.pm
>@@ -21,6 +21,7 @@ use Try::Tiny;
> use base 'Koha::BackgroundJob';
> 
> use Koha::Database;
>+use Koha::ImportBatches;
> use C4::Matcher;
> use C4::ImportBatch qw(
>     RecordsFromMARCXMLFile
>diff --git a/tools/stage-marc-import.pl b/tools/stage-marc-import.pl
>index 2fe21b1a23..e60ed7c5a6 100755
>--- a/tools/stage-marc-import.pl
>+++ b/tools/stage-marc-import.pl
>@@ -95,6 +95,7 @@ if ($fileID) {
>         item_action                => $item_action,
>         basket_id                  => $basketno,
>         vendor_id                  => $booksellerid,
>+        profile_id                 => $profile_id,
>     };
>     try {
>         my $job_id = Koha::BackgroundJob::StageMARCForImport->new->enqueue( $params );
>-- 
>2.37.1 (Apple Git-137.1)

Actions: View | Diff | Splinter Review

Attachments on bug 33755: 154083 | 154107 | 154108 | 154111