Before 22.11 if you selected a profile when staging marc records for import, when you went to see staged records it would show which profile was used both in the table and in the batch details. Post 22.11, if you select a profile, it saves the selections but doesn't save which profile was used.
profile_id is not set in StageMARCForImport call ( tools/stage-marc-import.pl )
Created attachment 154083 [details] [review] Bug 33755: Set profile_id and add missing import This patch adds a missed parameter (profile_id) in stage-marc-import.pl and also adds a missing import in the background job for staging marc files. This means that the profile used when importing can now be shown in the import batches table and also in batch details Test plan: 1) Stage a record for import and make sure to save the import profile you use 2) Import a record using that profile 3) Navigate to Cataloging > Manage staged MARC records 4) In the Profile column, no value will be shown for the staged record 5) Click on the batch, the profile will be missing in this screen as well 6) Apply patch 7) Restart_all 8) Repeat steps 2-5, the profile name should be visible in both places
Hi, Is "Restart_all" (step 7) another way to say "Restart services" from the Actions sandbox-dropdown ? That's what I did (Restart service) and I still don't see the profile name (nor in table nor in details) Emmanuel Bétemps
That should be the same yes, I've just tested again from my end and the patch applies fine and seems to be working
Created attachment 154107 [details] [review] Bug 33755: Set profile_id and add missing import This patch adds a missed parameter (profile_id) in stage-marc-import.pl and also adds a missing import in the background job for staging marc files. This means that the profile used when importing can now be shown in the import batches table and also in batch details Test plan: 1) Stage a record for import and make sure to save the import profile you use 2) Import a record using that profile 3) Navigate to Cataloging > Manage staged MARC records 4) In the Profile column, no value will be shown for the staged record 5) Click on the batch, the profile will be missing in this screen as well 6) Apply patch 7) Restart_all 8) Repeat steps 2-5, the profile name should be visible in both places Signed-off-by: Sam Lau <samalau@gmail.com>
Created attachment 154108 [details] [review] Bug 33755: Set profile_id and add missing import This patch adds a missed parameter (profile_id) in stage-marc-import.pl and also adds a missing import in the background job for staging marc files. This means that the profile used when importing can now be shown in the import batches table and also in batch details Test plan: 1) Stage a record for import and make sure to save the import profile you use 2) Import a record using that profile 3) Navigate to Cataloging > Manage staged MARC records 4) In the Profile column, no value will be shown for the staged record 5) Click on the batch, the profile will be missing in this screen as well 6) Apply patch 7) Restart_all 8) Repeat steps 2-5, the profile name should be visible in both places Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
I tried again.
Created attachment 154111 [details] [review] Bug 33755: Set profile_id and add missing import This patch adds a missed parameter (profile_id) in stage-marc-import.pl and also adds a missing import in the background job for staging marc files. This means that the profile used when importing can now be shown in the import batches table and also in batch details Test plan: 1) Stage a record for import and make sure to save the import profile you use 2) Import a record using that profile 3) Navigate to Cataloging > Manage staged MARC records 4) In the Profile column, no value will be shown for the staged record 5) Click on the batch, the profile will be missing in this screen as well 6) Apply patch 7) Restart_all 8) Repeat steps 2-5, the profile name should be visible in both places Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.03
Nice work everyone! Pushed to 22.11.x for next release