Bug 33755 - Profile used is not saved when importing records
Summary: Profile used is not saved when importing records
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Matt Blenkinsop
QA Contact: Testopia
URL:
Keywords:
Depends on: 27421
Blocks:
  Show dependency treegraph
 
Reported: 2023-05-17 16:39 UTC by Lisette Scheer
Modified: 2023-12-28 20:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
23.11.00,23.05.03,22.11.09


Attachments
Bug 33755: Set profile_id and add missing import (1.98 KB, patch)
2023-07-31 08:57 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 33755: Set profile_id and add missing import (2.00 KB, patch)
2023-07-31 18:11 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 33755: Set profile_id and add missing import (2.14 KB, patch)
2023-07-31 18:34 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 33755: Set profile_id and add missing import (2.20 KB, patch)
2023-07-31 20:09 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lisette Scheer 2023-05-17 16:39:09 UTC
Before 22.11 if you selected a profile when staging marc records for import, when you went to see staged records it would show which profile was used both in the table and in the batch details. 

Post 22.11, if you select a profile, it saves the selections but doesn't save which profile was used.
Comment 1 Didier Gautheron 2023-07-30 16:31:23 UTC
profile_id is not set in 
StageMARCForImport call ( tools/stage-marc-import.pl )
Comment 2 Matt Blenkinsop 2023-07-31 08:57:16 UTC
Created attachment 154083 [details] [review]
Bug 33755: Set profile_id and add missing import

This patch adds a missed parameter (profile_id) in stage-marc-import.pl and also adds a missing import in the background job for staging marc files. This means that the profile used when importing can now be shown in the import batches table and also in batch details

Test plan:
1) Stage a record for import and make sure to save the import profile you use
2) Import a record using that profile
3) Navigate to Cataloging > Manage staged MARC records
4) In the Profile column, no value will be shown for the staged record
5) Click on the batch, the profile will be missing in this screen as well
6) Apply patch
7) Restart_all
8) Repeat steps 2-5, the profile name should be visible in both places
Comment 3 Emmanuel Bétemps 2023-07-31 15:38:30 UTC
Hi,

Is "Restart_all" (step 7) another way to say "Restart services" from the Actions sandbox-dropdown ?

That's what I did (Restart service) and I still don't see the profile name (nor in table nor in details)


Emmanuel Bétemps
Comment 4 Matt Blenkinsop 2023-07-31 16:09:24 UTC
That should be the same yes, I've just tested again from my end and the patch applies fine and seems to be working
Comment 5 Sam Lau 2023-07-31 18:11:40 UTC
Created attachment 154107 [details] [review]
Bug 33755: Set profile_id and add missing import

This patch adds a missed parameter (profile_id) in stage-marc-import.pl and also adds a missing import in the background job for staging marc files. This means that the profile used when importing can now be shown in the import batches table and also in batch details

Test plan:
1) Stage a record for import and make sure to save the import profile you use
2) Import a record using that profile
3) Navigate to Cataloging > Manage staged MARC records
4) In the Profile column, no value will be shown for the staged record
5) Click on the batch, the profile will be missing in this screen as well
6) Apply patch
7) Restart_all
8) Repeat steps 2-5, the profile name should be visible in both places

Signed-off-by: Sam Lau <samalau@gmail.com>
Comment 6 Biblibre Sandboxes 2023-07-31 18:34:13 UTC
Created attachment 154108 [details] [review]
Bug 33755: Set profile_id and add missing import

This patch adds a missed parameter (profile_id) in stage-marc-import.pl and also adds a missing import in the background job for staging marc files. This means that the profile used when importing can now be shown in the import batches table and also in batch details

Test plan:
1) Stage a record for import and make sure to save the import profile you use
2) Import a record using that profile
3) Navigate to Cataloging > Manage staged MARC records
4) In the Profile column, no value will be shown for the staged record
5) Click on the batch, the profile will be missing in this screen as well
6) Apply patch
7) Restart_all
8) Repeat steps 2-5, the profile name should be visible in both places

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Comment 7 Emmanuel Bétemps 2023-07-31 18:35:20 UTC
I tried again.
Comment 8 Katrin Fischer 2023-07-31 20:09:18 UTC
Created attachment 154111 [details] [review]
Bug 33755: Set profile_id and add missing import

This patch adds a missed parameter (profile_id) in stage-marc-import.pl and also adds a missing import in the background job for staging marc files. This means that the profile used when importing can now be shown in the import batches table and also in batch details

Test plan:
1) Stage a record for import and make sure to save the import profile you use
2) Import a record using that profile
3) Navigate to Cataloging > Manage staged MARC records
4) In the Profile column, no value will be shown for the staged record
5) Click on the batch, the profile will be missing in this screen as well
6) Apply patch
7) Restart_all
8) Repeat steps 2-5, the profile name should be visible in both places

Signed-off-by: Sam Lau <samalau@gmail.com>
Signed-off-by: Emmanuel Bétemps <e.betemps@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 9 Tomás Cohen Arazi 2023-08-15 09:13:42 UTC
Pushed to master for 23.11.

Nice work everyone, thanks!
Comment 10 Fridolin Somers 2023-08-17 20:09:01 UTC
Pushed to 23.05.x for 23.05.03
Comment 11 Pedro Amorim 2023-08-18 13:46:03 UTC
Nice work everyone!

Pushed to 22.11.x for next release