Attachment 154609 Details for Bug 34378 – Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header

[patch] Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header

Bug-34378-Fix-inconsistencies-in-Libraries-page-ti.patch (text/plain), 3.42 KB, created by Biblibre Sandboxes on 2023-08-18 09:04:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2023-08-18 09:04:59 UTC

Size: 3.42 KB

patch

obsolete

>From 4fe6593c70cb2e278cc16ce81b16b09fde7ff348 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 18 Aug 2023 08:39:50 +0000
>Subject: [PATCH] Bug 34378: Fix inconsistencies in Libraries page titles,
> breadcrumbs, and header
>
>This patch makes changes to the libraries administration page so that
>the page title, breadcrumbs, and page headings are more consistent with
>each other.
>
>To test, apply the patch and go to Administration -> Libraries.
>
>- Click "New library"
>- The page title, breadcrumb navigation, and page heading should all
>  read "New library"
>- Enter some details, save your new library, and then click the "Delete"
>  button corresponding to your new library.
>- On the deletion conformation page, the page title and breadcrumb
>  navigation should match, "Confirm deletion of library 'X'"
>- Edit a library. On the edit page, the page title, breadcrumb
>  navigation, and page heading should match: "Modify library 'X'"
>
>Signed-off-by: paul <paul.poulain@biblibre.com>
>---
> .../prog/en/modules/admin/branches.tt          | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index 89360f79e7..9f4b1e09e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -11,9 +11,9 @@
> <title>[% FILTER collapse %]
>     [% IF op == 'add_form' %]
>         [% IF library %]
>-            [% t("Modify library") | html %]
>+            [% tx("Modify library '{library}'", { library = library.branchcode }) | html %]
>         [% ELSE %]
>-            [% tx("New library {library}", { library = library.branchcode }) | html %]
>+            [% t("New library") | html %]
>         [% END %] &rsaquo;
>     [% ELSIF op == 'delete_confirm' %]
>         [% tx("Confirm deletion of library '{library}'", { library = library.branchcode }) | html %] &rsaquo;
>@@ -49,17 +49,17 @@
>         [% IF op == 'add_form'  %]
>             [% IF library %]
>                 [% WRAPPER breadcrumb_item bc_active= 1 %]
>-                    <span>Modify library</span>
>+                    [% tx("Modify library '{library}'", { library = library.branchcode }) | html %]
>                 [% END %]
>             [% ELSE %]
>                [% WRAPPER breadcrumb_item bc_active= 1 %]
>-                    <span>New library [% library.branchcode | html %]</span>
>+                    <span>New library</span>
>                 [% END %]
>             [% END %]
> 
>         [% ELSIF op == 'delete_confirm' %]
>             [% WRAPPER breadcrumb_item bc_active= 1 %]
>-                <span>Confirm deletion of library '[% library.branchcode | html %]'</span>
>+                [% tx("Confirm deletion of library '{library}'", { library = library.branchcode }) | html %]
>             [% END %]
> 
>         [% ELSIF op == 'view' %]
>@@ -116,7 +116,13 @@
> [% END %]
> 
> [% IF op == 'add_form' %]
>-    <h1>[% IF library %]Modify library[% ELSE %]New library[% END %]</h1>
>+    <h1>
>+        [% IF library %]
>+            [% tx("Modify library '{library}'", { library = library.branchcode }) | html %]
>+        [% ELSE %]
>+            New library
>+        [% END %]
>+    </h1>
>     <form action="/cgi-bin/koha/admin/branches.pl" id="Aform" name="Aform" class="validated" method="post">
>         <fieldset class="rows">
>             <input type="hidden" name="op" value="add_validate" />
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34378: 154606 | 154609 | 154757