While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Libraries page, here is what should be changed to make it consistent with the other pages in the module: Page title - Remove library code from New X (this is only visible in the code, unless I misunderstand the line) - Add library code to Modify X in page title (e.g. Modify library 'CPL') Breadcrumb - Add library code to Modify X in breadcrumb (e.g. Modify library 'CPL') Page header - Add library code to Modify X in page header (e.g. Modify library 'CPL')
Created attachment 154606 [details] [review] Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header This patch makes changes to the libraries administration page so that the page title, breadcrumbs, and page headings are more consistent with each other. To test, apply the patch and go to Administration -> Libraries. - Click "New library" - The page title, breadcrumb navigation, and page heading should all read "New library" - Enter some details, save your new library, and then click the "Delete" button corresponding to your new library. - On the deletion conformation page, the page title and breadcrumb navigation should match, "Confirm deletion of library 'X'" - Edit a library. On the edit page, the page title, breadcrumb navigation, and page heading should match: "Modify library 'X'"
Created attachment 154609 [details] [review] Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header This patch makes changes to the libraries administration page so that the page title, breadcrumbs, and page headings are more consistent with each other. To test, apply the patch and go to Administration -> Libraries. - Click "New library" - The page title, breadcrumb navigation, and page heading should all read "New library" - Enter some details, save your new library, and then click the "Delete" button corresponding to your new library. - On the deletion conformation page, the page title and breadcrumb navigation should match, "Confirm deletion of library 'X'" - Edit a library. On the edit page, the page title, breadcrumb navigation, and page heading should match: "Modify library 'X'" Signed-off-by: paul <paul.poulain@biblibre.com>
Created attachment 154757 [details] [review] Bug 34378: Fix inconsistencies in Libraries page titles, breadcrumbs, and header This patch makes changes to the libraries administration page so that the page title, breadcrumbs, and page headings are more consistent with each other. To test, apply the patch and go to Administration -> Libraries. - Click "New library" - The page title, breadcrumb navigation, and page heading should all read "New library" - Enter some details, save your new library, and then click the "Delete" button corresponding to your new library. - On the deletion conformation page, the page title and breadcrumb navigation should match, "Confirm deletion of library 'X'" - Edit a library. On the edit page, the page title, breadcrumb navigation, and page heading should match: "Modify library 'X'" Signed-off-by: paul <paul.poulain@biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Depends on Bug 33909 not in 23.05.x