Attachment 154628 Details for Bug 33917 – Bug 33917: Improve translation of title tags: Offline circulation and patron lists

[patch] Bug 33917: Improve translation of title tags: Offline circulation and patron lists

Bug-33917-Improve-translation-of-title-tags-Offlin.patch (text/plain), 6.00 KB, created by Chris Cormack on 2023-08-18 09:43:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2023-08-18 09:43:40 UTC

Size: 6.00 KB

patch

obsolete

>From fabeeb377d800a131c1f10fc96be5c6d93a963d4 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 6 Jun 2023 15:19:20 +0000
>Subject: [PATCH] Bug 33917: Improve translation of title tags: Offline
> circulation and patron lists
>
>This patch updates offline circulation and patron lists templates so
>that title tags can be more easily translated.
>
>To test, apply the patch and confirm that the following pages have the
>correct title tags:
>
>- Circulation -> Upload offline circulation file
>  - Add to queue
>  - View pending offline circulations
>- Tools -> Patron lists
>  - New list, edit list
>  - View list
>
>Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
>---
> .../prog/en/modules/offline_circ/enqueue_koc.tt    |  8 +++++++-
> .../prog/en/modules/offline_circ/list.tt           |  7 ++++++-
> .../prog/en/modules/offline_circ/process_koc.tt    |  7 ++++++-
> .../prog/en/modules/patron_lists/add-modify.tt     | 14 +++++++++-----
> .../prog/en/modules/patron_lists/list.tt           |  9 ++++++++-
> .../prog/en/modules/patron_lists/lists.tt          |  7 ++++++-
> 6 files changed, 42 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt
>index bab38d55e56..05b7cfd2c3c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/enqueue_koc.tt
>@@ -1,5 +1,11 @@
>+[% USE raw %]
>+[% PROCESS 'i18n.inc' %]
> [% INCLUDE 'doc-head-open.inc' %]
>-<title>Add offline circulations to queue &rsaquo; Circulation &rsaquo; Koha</title>
>+<title>[% FILTER collapse %]
>+    [% t("Add offline circulations to queue") | html %] &rsaquo;
>+    [% t("Circulation") | html %] &rsaquo;
>+    [% t("Koha") | html %]
>+[% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
> </head>
> <body id="ocirc_enqueue_koc" class="circ ocirc">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt
>index 13dac4ee38d..77b88a7ce42 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/list.tt
>@@ -1,9 +1,14 @@
> [% USE raw %]
> [% USE Asset %]
> [% USE KohaDates %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
>     [% INCLUDE "doc-head-open.inc" %]
>-    <title>Offline circulation &rsaquo; Circulation &rsaquo; Koha</title>
>+    <title>[% FILTER collapse %]
>+        [% t("Offline circulation") | html %] &rsaquo;
>+        [% t("Circulation") | html %] &rsaquo;
>+        [% t("Koha") | html %]
>+    [% END %]</title>
>     [% INCLUDE "doc-head-close.inc" %]
> </head>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt
>index fcd05bb280c..cf392039fe2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/offline_circ/process_koc.tt
>@@ -1,8 +1,13 @@
> [% USE raw %]
> [% USE Asset %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
>-<title>Offline circulation file upload &rsaquo; Circulation &rsaquo; Koha</title>
>+<title>[% FILTER collapse %]
>+    [% t("Offline circulation file upload") | html %] &rsaquo;
>+    [% t("Circulation") | html %] &rsaquo;
>+    [% t("Koha") | html %]
>+[% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
> </head>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt
>index 85fabb0c84c..142efe84a37 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/add-modify.tt
>@@ -1,14 +1,18 @@
> [% USE raw %]
> [% USE Asset %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
>-<title>
>+<title>[% FILTER collapse %]
>     [% IF list.patron_list_id %]
>-        Modify patron list
>+        [% t("Modify patron list") | html %]
>     [% ELSE %]
>-        New patron list
>-    [% END %] &rsaquo; Patron lists &rsaquo; Tools &rsaquo; Koha
>-</title>
>+        [% t("New patron list") | html %]
>+    [% END %] &rsaquo;
>+    [% t("Patron lists") | html %] &rsaquo;
>+    [% t("Tools") | html %] &rsaquo;
>+    [% t("Koha") | html %]
>+[% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
> </head>
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt
>index 00a33b8c2a4..be8c885b878 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/list.tt
>@@ -2,10 +2,17 @@
> [% USE Asset %]
> [% USE KohaDates %]
> [% USE TablesSettings %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> [% INCLUDE 'columns_settings.inc' %]
>-<title>Add patrons &rsaquo; [% list.name | html %] &rsaquo; Patron lists &rsaquo; Tools &rsaquo; Koha</title>
>+<title>[% FILTER collapse %]
>+    [% t("Add patrons") | html %] &rsaquo;
>+    [% list.name | html %] &rsaquo;
>+    [% t("Patron lists") | html %] &rsaquo;
>+    [% t("Tools") | html %] &rsaquo;
>+    [% t("Koha") | html %]
>+[% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
> 
> <style>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt
>index de7eda1c40e..2404e9cd07b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patron_lists/lists.tt
>@@ -1,8 +1,13 @@
> [% USE raw %]
> [% USE Asset %]
>+[% PROCESS 'i18n.inc' %]
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
>-<title>Patron lists &rsaquo; Tools &rsaquo; Koha</title>
>+<title>[% FILTER collapse %]
>+    [% t("Patron lists") | html %] &rsaquo;
>+    [% t("Tools") | html %] &rsaquo;
>+    [% t("Koha") | html %]
>+[% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
> [% INCLUDE 'greybox.inc' %]
> </head>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33917: 152315 | 154594 | 154628 | 155088