Attachment 154763 Details for Bug 34384 – Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading

[patch] Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading

Bug-34384-Fix-inconsistencies-in-Library-transfer-.patch (text/plain), 4.23 KB, created by Katrin Fischer on 2023-08-24 22:34:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2023-08-24 22:34:00 UTC

Size: 4.23 KB

patch

obsolete

>From 0f1fc0a828022d62d8353b87bc46ec50a171a780 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 18 Aug 2023 11:18:45 +0000
>Subject: [PATCH] Bug 34384: Fix inconsistencies in Library transfer limits
> page titles, breadcrumbs, and heading
>
>This patch makes a few minor corrections to the library transfer limits
>pages, both basic and advanced, standardizing on the name "Library
>transfer limits" for page title, breadcrumb navigation, and page
>heading.
>
>To test, apply the patch and go to Administration -> Library transfer
>limits.
>
>- Confirm that the page shows "Library transfer limits for [library]
>  [library code]"
>- Breadcrumb navigation, page title, and heading should match.
>- Swith to the advanced editor
>- The title should now be simply "Library transfer limits"
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> .../prog/en/modules/admin/branch_transfer_limits.tt       | 8 +++++---
> .../prog/en/modules/admin/transfer_limits.tt              | 6 +++---
> 2 files changed, 8 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>index 198580ae25..fb5b811c8e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt
>@@ -5,7 +5,7 @@
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>[% FILTER collapse %]
>-    [% t("Library checkin and transfer policy") | html %] &rsaquo;
>+    [% tx("Library transfer limits for {library_name} ({library_code})", { library_name = Branches.GetName( branchcode), library_code = branchcode } ) | html %] &rsaquo;
>     [% t("Administration") | html %] &rsaquo;
>     [% t("Koha") | html %]
> [% END %]</title>
>@@ -24,7 +24,7 @@
>             <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a>
>         [% END %]
>         [% WRAPPER breadcrumb_item bc_active= 1 %]
>-            <span>Set library checkin and transfer policy</span>
>+            [% tx("Library transfer limits for {library_name} ({library_code})", { library_name = Branches.GetName( branchcode), library_code = branchcode } ) | html %]
>         [% END %]
>     [% END #/ WRAPPER breadcrumbs %]
> [% END #/ WRAPPER sub-header.inc %]
>@@ -34,7 +34,9 @@
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
> 
>-<h1>Library [% branchcode | html %] - [% Branches.GetName( branchcode ) | html %] Checkin and transfer policy</h1>
>+    <h1>
>+        [% tx("Library transfer limits for {library_name} ({library_code})", { library_name = Branches.GetName( branchcode), library_code = branchcode } ) | html %]
>+    </h1>
>     <form method="get" action="/cgi-bin/koha/admin/branch_transfer_limits.pl" id="selectlibrary">
>         <label for="branchselect">Select a library :</label>
>         <select name="branchcode" id="branchselect">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt
>index 58958bc2d3..b400bb7a93 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt
>@@ -9,7 +9,7 @@
> [% SET footerjs = 1 %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>[% FILTER collapse %]
>-    [% t("Library checkin and transfer policy") | html %] &rsaquo;
>+    [% t("Library transfer limits") | html %] &rsaquo;
>     [% t("Administration") | html %] &rsaquo;
>     [% t("Koha") | html %]
> [% END %]</title>
>@@ -31,7 +31,7 @@
>             <a href="/cgi-bin/koha/admin/admin-home.pl">Administration</a>
>         [% END %]
>         [% WRAPPER breadcrumb_item bc_active= 1 %]
>-            <span>Set library checkin and transfer policy</span>
>+            <span>Library transfer limits</span>
>         [% END %]
>     [% END #/ WRAPPER breadcrumbs %]
> [% END #/ WRAPPER sub-header.inc %]
>@@ -40,7 +40,7 @@
>     <div class="row">
>         <div class="col-sm-10 col-sm-push-2">
>             <main>
>-                <h1>Checkin and transfer policy</h1>
>+                <h1>Library transfer limits</h1>
> 
>                 <p>
>                     [% IF BranchTransferLimitsType == "itemtype" %]
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34384: 154640 | 154659 | 154763