While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Library transfer limits page (basic editor), here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Library checkin and transfer policy' to 'Library transfer limits' - Should the branchcode be there? (e.g. Library transfer limits for 'CPL') Breadcrumb - Change 'Set library checkin and transfer policy' to 'Library transfer limits' - Should the branchcode be there? (e.g. Library transfer limits for 'CPL') Page header - Change 'Library CPL - Centerville Checkin and transfer policy' to "Library transfer limits for 'CPL'" For the advanced editor, Page title - Change 'Library checkin and transfer policy' to 'Library transfer limits' Breadcrumb - Change 'Set library checkin and transfer policy' to 'Library transfer limits' Page header - Change 'Checkin and transfer policy' to 'Library transfer limits'
Created attachment 154640 [details] [review] Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading This patch makes a few minor corrections to the library transfer limits pages, both basic and advanced, standardizing on the name "Library transfer limits" for page title, breadcrumb navigation, and page heading. To test, apply the patch and go to Administration -> Library transfer limits. - Confirm that the page shows "Library transfer limits for [library] [library code]" - Breadcrumb navigation, page title, and heading should match. - Swith to the advanced editor - The title should now be simply "Library transfer limits"
Created attachment 154659 [details] [review] Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading This patch makes a few minor corrections to the library transfer limits pages, both basic and advanced, standardizing on the name "Library transfer limits" for page title, breadcrumb navigation, and page heading. To test, apply the patch and go to Administration -> Library transfer limits. - Confirm that the page shows "Library transfer limits for [library] [library code]" - Breadcrumb navigation, page title, and heading should match. - Swith to the advanced editor - The title should now be simply "Library transfer limits" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 154763 [details] [review] Bug 34384: Fix inconsistencies in Library transfer limits page titles, breadcrumbs, and heading This patch makes a few minor corrections to the library transfer limits pages, both basic and advanced, standardizing on the name "Library transfer limits" for page title, breadcrumb navigation, and page heading. To test, apply the patch and go to Administration -> Library transfer limits. - Confirm that the page shows "Library transfer limits for [library] [library code]" - Breadcrumb navigation, page title, and heading should match. - Swith to the advanced editor - The title should now be simply "Library transfer limits" Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 23.11. Nice work everyone, thanks!
Does not apply on 23.05.x, maybe depends on Bug 33909 ?