Attachment 154838 Details for Bug 34616 – Bug 34616: Add native bootstrap behaviour to default server dialog

[patch] Bug 34616: Add native bootstrap behaviour to default server dialog

Bug-34616-Add-native-bootstrap-behaviour-to-defaul.patch (text/plain), 2.65 KB, created by Pedro Amorim on 2023-08-25 16:46:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2023-08-25 16:46:24 UTC

Size: 2.65 KB

patch

obsolete

>From 2ec1b24a0f66b7aaa69be4e2ed2801bf99c4f835 Mon Sep 17 00:00:00 2001
>From: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Date: Fri, 25 Aug 2023 14:14:35 +0000
>Subject: [PATCH] Bug 34616: Add native bootstrap behaviour to default server
> dialog
>
>Test plan:
>Create a new SMTP server
>Tick the 'default server' checkbox
>Verify it now has a backdrop, closes if u click the backdrop or press 'esc'
>The Yes and No buttons are now styled properly
>---
> .../prog/en/modules/admin/smtp_servers.tt              | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>index 11cf1b7230..779434cb1b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>@@ -317,8 +317,8 @@
>                             <div id="default_confirm_dialog">Are you sure you want to change the default SMTP server?</div>
>                         </div>
>                         <div class="modal-footer">
>-                            <a id="default_confirm_dialog" href="#" class="btn btn-default default_confirm_modal_yes" id="default_confirm_modal_button" role="button" data-toggle="modal">Yes</a>
>-                            <button class="btn btn-link default_confirm_modal_no" data-dismiss="modal" aria-hidden="true">No</button>
>+                            <a id="default_confirm_dialog" href="#" class="btn btn-primary default_confirm_modal_yes" id="default_confirm_modal_button" role="button" data-toggle="modal">Yes</a>
>+                            <button class="btn btn-default default_confirm_modal_no" data-dismiss="modal" aria-hidden="true">No</button>
>                         </div>
>                     </div> 
>                 </div> 
>@@ -456,14 +456,14 @@
>             });
> 
>             $('#smtp_default').on( "click", function () {
>-                $("#default_confirm_modal").show();
>+                $("#default_confirm_modal").modal('show');
>             });
>             $('.default_confirm_modal_yes').on( "click", function () {
>-                $("#default_confirm_modal").hide();
>+                $("#default_confirm_modal").modal('hide');
>             });
>             $('.default_confirm_modal_no').on( "click", function () {
>                 $("#smtp_default").prop('checked', !$("#smtp_default").prop('checked') );
>-                $("#default_confirm_modal").hide();
>+                $("#default_confirm_modal").modal('hide');
>             });
> 
>             $("#delete_confirm_modal_button").on( "click", function () {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 34616: 154814 | 154838 | 154839 | 154840 | 154844 | 154845 | 154846 | 154960 | 154961 | 154962