Created attachment 154814 [details] issue To reproduce, on k-t-d: - Add a new SMTP server - Visit the edit page for that SMTP server
Hmm... can't reproduce. Must've been some changing of branches hic-up!
I can reproduce the problem. The template shows a "default configuration" dialog inside the SMTP server entry form. I don't know why. Was the intention for this dialog to show above the form? Or should it not display at all?
(In reply to Owen Leonard from comment #2) > I can reproduce the problem. The template shows a "default configuration" > dialog inside the SMTP server entry form. I don't know why. > > Was the intention for this dialog to show above the form? Or should it not > display at all? It's so weird, cause I can't reproduce it intentionally every time. It sometimes happens and other times it doesn't, at least for me! The intention, I believe, is not display at all in that edit form. That dialog should only display in the SMTP servers list page afaik.
(In reply to Owen Leonard from comment #2) > I can reproduce the problem. The template shows a "default configuration" > dialog inside the SMTP server entry form. I don't know why. > > Was the intention for this dialog to show above the form? Or should it not > display at all? Wait, I stand corrected. It seems this is intended to show on the "is_default" SMTP Server. But the styling seems to have gone crazy.
(In reply to Owen Leonard from comment #2) > I can reproduce the problem. The template shows a "default configuration" > dialog inside the SMTP server entry form. I don't know why. > > Was the intention for this dialog to show above the form? Or should it not > display at all? Wait, I stand corrected. It seems this is intended to show on servers that are not tagged as the "is_default" SMTP Server. But the styling seems to have gone crazy.
Created attachment 154838 [details] [review] Bug 34616: Add native bootstrap behaviour to default server dialog Test plan: Create a new SMTP server Tick the 'default server' checkbox Verify it now has a backdrop, closes if u click the backdrop or press 'esc' The Yes and No buttons are now styled properly
Created attachment 154839 [details] [review] Bug 34616: Fix showing default server info on edit SMTP server page
Created attachment 154840 [details] [review] Bug 34616: Move default server info outside the <fieldset> Also DRY current default information dialog block
Created attachment 154844 [details] [review] Bug 34616: Add native bootstrap behaviour to default server dialog Test plan: Create a new SMTP server Tick the 'default server' checkbox Verify it now has a backdrop, closes if u click the backdrop or press 'esc' The Yes and No buttons are now styled properly Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 154845 [details] [review] Bug 34616: Fix showing default server info on edit SMTP server page Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 154846 [details] [review] Bug 34616: Move default server info outside the <fieldset> Also DRY current default information dialog block Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 154960 [details] [review] Bug 34616: Add native bootstrap behaviour to default server dialog Test plan: Create a new SMTP server Tick the 'default server' checkbox Verify it now has a backdrop, closes if u click the backdrop or press 'esc' The Yes and No buttons are now styled properly Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 154961 [details] [review] Bug 34616: Fix showing default server info on edit SMTP server page Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 154962 [details] [review] Bug 34616: Move default server info outside the <fieldset> Also DRY current default information dialog block Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed to master for 23.11. Nice work everyone, thanks!
Pushed to 23.05.x for 23.05.04
Not backporting to 22.11.x - missing dependency 27424 Nice work everyone!