Bugzilla – Attachment 155195 Details for
Bug 32911
Remove ILL partner_code config from koha-conf.xml and turn it into a system preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 32911: (QA follow-up) Adjust tests
Bug-32911-QA-follow-up-Adjust-tests.patch (text/plain), 2.56 KB, created by
Tomás Cohen Arazi (tcohen)
on 2023-09-04 11:52:22 UTC
(
hide
)
Description:
Bug 32911: (QA follow-up) Adjust tests
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2023-09-04 11:52:22 UTC
Size:
2.56 KB
patch
obsolete
>From 1ca21fabb2a521b6c206b85e3f1feaffb2380e75 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 4 Sep 2023 08:50:52 -0300 >Subject: [PATCH] Bug 32911: (QA follow-up) Adjust tests > >This patch adjusts tests so they acknowledge the new syspref and the >fact `partner_code` will be skipped if found on the config file. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Illrequest/Config.t | 33 +++++++++++++++++++++++------- > 1 file changed, 26 insertions(+), 7 deletions(-) > >diff --git a/t/db_dependent/Illrequest/Config.t b/t/db_dependent/Illrequest/Config.t >index 8baa624234c..ae1535ef774 100755 >--- a/t/db_dependent/Illrequest/Config.t >+++ b/t/db_dependent/Illrequest/Config.t >@@ -193,7 +193,7 @@ subtest '_load_unit_config' => sub { > > subtest '_load_configuration' => sub { > >- plan tests => 9; >+ plan tests => 10; > > $schema->storage->txn_begin; > >@@ -388,20 +388,39 @@ subtest '_load_configuration' => sub { > > # Partner library category > is_deeply( >- Koha::Illrequest::Config::_load_configuration({ partner_code => 'FOOBAR' }), >+ Koha::Illrequest::Config::_load_configuration( { partner_code => 'FOOBAR' } ), > { >- backend_directory => undef, >- censorship => { >+ backend_directory => undef, >+ censorship => { > censor_notes_staff => 0, >- censor_reply_date => 0, >+ censor_reply_date => 0, > }, > limits => {}, > digital_recipients => {}, > prefixes => {}, >- partner_code => 'FOOBAR', >+ partner_code => 'IL', > raw_config => { partner_code => 'FOOBAR' }, > }, >- "load_configuration: Set partner code." >+ q{'partner_code' not read from the config file, default value 'IL' used instead} >+ ); >+ >+ t::lib::Mocks::mock_preference( 'ILLPartnerCode', 'FOOBAR' ); >+ >+ is_deeply( >+ Koha::Illrequest::Config::_load_configuration(), >+ { >+ backend_directory => undef, >+ censorship => { >+ censor_notes_staff => 0, >+ censor_reply_date => 0, >+ }, >+ limits => {}, >+ digital_recipients => {}, >+ prefixes => {}, >+ partner_code => 'FOOBAR', >+ raw_config => {}, >+ }, >+ q{'ILLPartnerCode' takes precedence over default value for 'partner_code'} > ); > > $schema->storage->txn_rollback; >-- >2.42.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 32911
:
146403
|
146404
|
146405
|
147417
|
147418
|
147419
|
150672
|
150673
|
150674
|
150750
|
150751
|
150752
|
150753
|
150768
|
150769
|
151011
|
151012
|
151013
|
151014
|
151015
|
151016
| 155195